* [PATCH][next] ubifs: remove redundant assignment to pointer fname
@ 2019-07-04 22:28 Colin King
2019-07-05 8:24 ` Sergei Shtylyov
0 siblings, 1 reply; 5+ messages in thread
From: Colin King @ 2019-07-04 22:28 UTC (permalink / raw)
To: Richard Weinberger, Artem Bityutskiy, Adrian Hunter, linux-mtd
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The pointer fname rc is being assigned with a value that is never
read because the function returns after the assignment. The assignment
is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
fs/ubifs/debug.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c
index 92fe5c5ed78a..95da71e13fc8 100644
--- a/fs/ubifs/debug.c
+++ b/fs/ubifs/debug.c
@@ -2817,7 +2817,6 @@ void dbg_debugfs_init_fs(struct ubifs_info *c)
c->vi.ubi_num, c->vi.vol_id);
if (n == UBIFS_DFS_DIR_LEN) {
/* The array size is too small */
- fname = UBIFS_DFS_DIR_NAME;
return;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH][next] ubifs: remove redundant assignment to pointer fname
2019-07-04 22:28 [PATCH][next] ubifs: remove redundant assignment to pointer fname Colin King
@ 2019-07-05 8:24 ` Sergei Shtylyov
2019-07-05 8:31 ` Colin Ian King
0 siblings, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2019-07-05 8:24 UTC (permalink / raw)
To: Colin King, Richard Weinberger, Artem Bityutskiy, Adrian Hunter,
linux-mtd
Cc: kernel-janitors, linux-kernel
Hello!
On 05.07.2019 1:28, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer fname rc is being assigned with a value that is never
rc?
> read because the function returns after the assignment. The assignment
> is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> fs/ubifs/debug.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c
> index 92fe5c5ed78a..95da71e13fc8 100644
> --- a/fs/ubifs/debug.c
> +++ b/fs/ubifs/debug.c
> @@ -2817,7 +2817,6 @@ void dbg_debugfs_init_fs(struct ubifs_info *c)
> c->vi.ubi_num, c->vi.vol_id);
> if (n == UBIFS_DFS_DIR_LEN) {
> /* The array size is too small */
> - fname = UBIFS_DFS_DIR_NAME;
> return;
> }
>
MBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][next] ubifs: remove redundant assignment to pointer fname
2019-07-05 8:24 ` Sergei Shtylyov
@ 2019-07-05 8:31 ` Colin Ian King
2019-07-05 10:51 ` Sergei Shtylyov
0 siblings, 1 reply; 5+ messages in thread
From: Colin Ian King @ 2019-07-05 8:31 UTC (permalink / raw)
To: Sergei Shtylyov, Richard Weinberger, Artem Bityutskiy,
Adrian Hunter, linux-mtd
Cc: kernel-janitors, linux-kernel
On 05/07/2019 09:24, Sergei Shtylyov wrote:
> Hello!
>
> On 05.07.2019 1:28, Colin King wrote:
>
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The pointer fname rc is being assigned with a value that is never
>
> rc?
Oops, cut'n'paste error. Do you want me to resend to can this be fixed
when it's applied?
Colin
>
>> read because the function returns after the assignment. The assignment
>> is redundant and can be removed.
>>
>> Addresses-Coverity: ("Unused value")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> fs/ubifs/debug.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c
>> index 92fe5c5ed78a..95da71e13fc8 100644
>> --- a/fs/ubifs/debug.c
>> +++ b/fs/ubifs/debug.c
>> @@ -2817,7 +2817,6 @@ void dbg_debugfs_init_fs(struct ubifs_info *c)
>> c->vi.ubi_num, c->vi.vol_id);
>> if (n == UBIFS_DFS_DIR_LEN) {
>> /* The array size is too small */
>> - fname = UBIFS_DFS_DIR_NAME;
>> return;
>> }
>>
>
> MBR, Sergei
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][next] ubifs: remove redundant assignment to pointer fname
2019-07-05 8:31 ` Colin Ian King
@ 2019-07-05 10:51 ` Sergei Shtylyov
2019-07-05 11:02 ` Richard Weinberger
0 siblings, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2019-07-05 10:51 UTC (permalink / raw)
To: Colin Ian King, Richard Weinberger, Artem Bityutskiy,
Adrian Hunter, linux-mtd
Cc: kernel-janitors, linux-kernel
On 07/05/2019 11:31 AM, Colin Ian King wrote:
>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> The pointer fname rc is being assigned with a value that is never
>>
>> rc?
>
> Oops, cut'n'paste error. Do you want me to resend to can this be fixed
> when it's applied?
That's the question to the maintainers...
MBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][next] ubifs: remove redundant assignment to pointer fname
2019-07-05 10:51 ` Sergei Shtylyov
@ 2019-07-05 11:02 ` Richard Weinberger
0 siblings, 0 replies; 5+ messages in thread
From: Richard Weinberger @ 2019-07-05 11:02 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Colin Ian King, Artem Bityutskiy, Adrian Hunter, linux-mtd,
kernel-janitors, linux-kernel
----- Ursprüngliche Mail -----
> Von: "Sergei Shtylyov" <sergei.shtylyov@cogentembedded.com>
> An: "Colin Ian King" <colin.king@canonical.com>, "richard" <richard@nod.at>, "Artem Bityutskiy" <dedekind1@gmail.com>,
> "Adrian Hunter" <adrian.hunter@intel.com>, "linux-mtd" <linux-mtd@lists.infradead.org>
> CC: kernel-janitors@vger.kernel.org, "linux-kernel" <linux-kernel@vger.kernel.org>
> Gesendet: Freitag, 5. Juli 2019 12:51:53
> Betreff: Re: [PATCH][next] ubifs: remove redundant assignment to pointer fname
> On 07/05/2019 11:31 AM, Colin Ian King wrote:
>
>>>> From: Colin Ian King <colin.king@canonical.com>
>>>>
>>>> The pointer fname rc is being assigned with a value that is never
>>>
>>> rc?
>>
>> Oops, cut'n'paste error. Do you want me to resend to can this be fixed
>> when it's applied?
>
> That's the question to the maintainers...
Please resend.
Thanks,
//richard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-07-05 11:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-04 22:28 [PATCH][next] ubifs: remove redundant assignment to pointer fname Colin King
2019-07-05 8:24 ` Sergei Shtylyov
2019-07-05 8:31 ` Colin Ian King
2019-07-05 10:51 ` Sergei Shtylyov
2019-07-05 11:02 ` Richard Weinberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).