* [linux-next:master 9908/12641] drivers/mfd/rohm-bd70528.c:109:14: sparse: sparse: symbol 'bit0_offsets' was not declared. Should it be static?
@ 2019-07-08 4:25 kbuild test robot
2019-07-08 4:25 ` [RFC PATCH linux-next] mfd: bd70528: bit0_offsets[] can be static kbuild test robot
0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2019-07-08 4:25 UTC (permalink / raw)
To: Matti Vaittinen, Matti Vaittinen; +Cc: kbuild-all, Lee Jones, linux-kernel
tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/next/linux-next.git master
head: 22c45ec32b4a9fa8c48ef4f5bf9b189b307aae12
commit: 21b7c58fc1943f3aa8c18a994ab9bed4ae5aa72d [9908/12641] mfd: bd70528: Support ROHM bd70528 PMIC core
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-rc1-7-g2b96cd8-dirty
git checkout 21b7c58fc1943f3aa8c18a994ab9bed4ae5aa72d
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/mfd/rohm-bd70528.c:109:14: sparse: sparse: symbol 'bit0_offsets' was not declared. Should it be static?
>> drivers/mfd/rohm-bd70528.c:110:14: sparse: sparse: symbol 'bit1_offsets' was not declared. Should it be static?
>> drivers/mfd/rohm-bd70528.c:111:14: sparse: sparse: symbol 'bit2_offsets' was not declared. Should it be static?
>> drivers/mfd/rohm-bd70528.c:112:14: sparse: sparse: symbol 'bit3_offsets' was not declared. Should it be static?
>> drivers/mfd/rohm-bd70528.c:113:14: sparse: sparse: symbol 'bit4_offsets' was not declared. Should it be static?
>> drivers/mfd/rohm-bd70528.c:114:14: sparse: sparse: symbol 'bit5_offsets' was not declared. Should it be static?
>> drivers/mfd/rohm-bd70528.c:115:14: sparse: sparse: symbol 'bit6_offsets' was not declared. Should it be static?
>> drivers/mfd/rohm-bd70528.c:116:14: sparse: sparse: symbol 'bit7_offsets' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 2+ messages in thread
* [RFC PATCH linux-next] mfd: bd70528: bit0_offsets[] can be static
2019-07-08 4:25 [linux-next:master 9908/12641] drivers/mfd/rohm-bd70528.c:109:14: sparse: sparse: symbol 'bit0_offsets' was not declared. Should it be static? kbuild test robot
@ 2019-07-08 4:25 ` kbuild test robot
0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2019-07-08 4:25 UTC (permalink / raw)
To: Matti Vaittinen, Matti Vaittinen; +Cc: kbuild-all, Lee Jones, linux-kernel
Fixes: 21b7c58fc194 ("mfd: bd70528: Support ROHM bd70528 PMIC core")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
rohm-bd70528.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/mfd/rohm-bd70528.c b/drivers/mfd/rohm-bd70528.c
index 55599d5..43c859f 100644
--- a/drivers/mfd/rohm-bd70528.c
+++ b/drivers/mfd/rohm-bd70528.c
@@ -106,14 +106,14 @@ static struct regmap_config bd70528_regmap = {
*/
/* bit [0] - Shutdown register */
-unsigned int bit0_offsets[] = {0}; /* Shutdown register */
-unsigned int bit1_offsets[] = {1}; /* Power failure register */
-unsigned int bit2_offsets[] = {2}; /* VR FAULT register */
-unsigned int bit3_offsets[] = {3}; /* PMU register interrupts */
-unsigned int bit4_offsets[] = {4, 5}; /* Charger 1 and Charger 2 registers */
-unsigned int bit5_offsets[] = {6}; /* RTC register */
-unsigned int bit6_offsets[] = {7}; /* GPIO register */
-unsigned int bit7_offsets[] = {8}; /* Invalid operation register */
+static unsigned int bit0_offsets[] = {0}; /* Shutdown register */
+static unsigned int bit1_offsets[] = {1}; /* Power failure register */
+static unsigned int bit2_offsets[] = {2}; /* VR FAULT register */
+static unsigned int bit3_offsets[] = {3}; /* PMU register interrupts */
+static unsigned int bit4_offsets[] = {4, 5}; /* Charger 1 and Charger 2 registers */
+static unsigned int bit5_offsets[] = {6}; /* RTC register */
+static unsigned int bit6_offsets[] = {7}; /* GPIO register */
+static unsigned int bit7_offsets[] = {8}; /* Invalid operation register */
static struct regmap_irq_sub_irq_map bd70528_sub_irq_offsets[] = {
REGMAP_IRQ_MAIN_REG_OFFSET(bit0_offsets),
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-08 4:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-08 4:25 [linux-next:master 9908/12641] drivers/mfd/rohm-bd70528.c:109:14: sparse: sparse: symbol 'bit0_offsets' was not declared. Should it be static? kbuild test robot
2019-07-08 4:25 ` [RFC PATCH linux-next] mfd: bd70528: bit0_offsets[] can be static kbuild test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).