From: Denis Efremov <efremov@linux.com>
To: Sven Schmidt <4sschmid@informatik.uni-hamburg.de>
Cc: Denis Efremov <efremov@linux.com>, Arnd Bergmann <arnd@arndb.de>,
Bongkyu Kim <bongkyu.kim@lge.com>,
Rui Salvaterra <rsalvaterra@gmail.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>,
Kees Cook <keescook@chromium.org>,
Tony Luck <tony.luck@intel.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] lib/lz4: remove the exporting of LZ4HC_setExternalDict
Date: Mon, 8 Jul 2019 18:15:55 +0300 [thread overview]
Message-ID: <20190708151555.8070-1-efremov@linux.com> (raw)
The function LZ4HC_setExternalDict is declared static and marked
EXPORT_SYMBOL, which is at best an odd combination. Because the function
is not used outside of the lib/lz4/lz4hc_compress.c file it is defined in,
this commit removes the EXPORT_SYMBOL() marking.
Signed-off-by: Denis Efremov <efremov@linux.com>
---
lib/lz4/lz4hc_compress.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/lz4/lz4hc_compress.c b/lib/lz4/lz4hc_compress.c
index 176f03b83e56..1b61d874e337 100644
--- a/lib/lz4/lz4hc_compress.c
+++ b/lib/lz4/lz4hc_compress.c
@@ -663,7 +663,6 @@ static void LZ4HC_setExternalDict(
/* match referencing will resume from there */
ctxPtr->nextToUpdate = ctxPtr->dictLimit;
}
-EXPORT_SYMBOL(LZ4HC_setExternalDict);
static int LZ4_compressHC_continue_generic(
LZ4_streamHC_t *LZ4_streamHCPtr,
--
2.21.0
next reply other threads:[~2019-07-08 15:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 15:15 Denis Efremov [this message]
2019-09-10 12:13 ` [PATCH] lib/lz4: remove the exporting of LZ4HC_setExternalDict Denis Efremov
2019-09-10 12:16 ` Masahiro Yamada
2019-09-10 12:47 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190708151555.8070-1-efremov@linux.com \
--to=efremov@linux.com \
--cc=4sschmid@informatik.uni-hamburg.de \
--cc=anton@enomsg.org \
--cc=arnd@arndb.de \
--cc=bongkyu.kim@lge.com \
--cc=ccross@android.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rsalvaterra@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).