linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [linux-next:master 9992/12641] drivers/mfd/rk808.c:754:1: sparse: sparse: symbol 'rk8xx_pm_ops' was not declared. Should it be static?
@ 2019-07-08  7:08 kbuild test robot
  2019-07-08  7:08 ` [RFC PATCH linux-next] mfd: rk808: rk8xx_pm_ops can be static kbuild test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2019-07-08  7:08 UTC (permalink / raw)
  To: Tony Xie; +Cc: kbuild-all, Lee Jones, linux-kernel

tree:   https://kernel.googlesource.com/pub/scm/linux/kernel/git/next/linux-next.git master
head:   22c45ec32b4a9fa8c48ef4f5bf9b189b307aae12
commit: 586c1b4125b3c7bf5b482fcafab5d568b8a3c285 [9992/12641] mfd: rk808: Add RK817 and RK809 support
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-rc1-7-g2b96cd8-dirty
        git checkout 586c1b4125b3c7bf5b482fcafab5d568b8a3c285
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> drivers/mfd/rk808.c:754:1: sparse: sparse: symbol 'rk8xx_pm_ops' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [RFC PATCH linux-next] mfd: rk808: rk8xx_pm_ops can be static
  2019-07-08  7:08 [linux-next:master 9992/12641] drivers/mfd/rk808.c:754:1: sparse: sparse: symbol 'rk8xx_pm_ops' was not declared. Should it be static? kbuild test robot
@ 2019-07-08  7:08 ` kbuild test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2019-07-08  7:08 UTC (permalink / raw)
  To: Tony Xie; +Cc: kbuild-all, Lee Jones, linux-kernel


Fixes: 586c1b4125b3 ("mfd: rk808: Add RK817 and RK809 support")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 rk808.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c
index 6ee1c46..52666a9 100644
--- a/drivers/mfd/rk808.c
+++ b/drivers/mfd/rk808.c
@@ -751,7 +751,7 @@ static int rk8xx_resume(struct device *dev)
 
 	return ret;
 }
-SIMPLE_DEV_PM_OPS(rk8xx_pm_ops, rk8xx_suspend, rk8xx_resume);
+static SIMPLE_DEV_PM_OPS(rk8xx_pm_ops, rk8xx_suspend, rk8xx_resume);
 
 static struct i2c_driver rk808_i2c_driver = {
 	.driver = {

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-07-08  7:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-08  7:08 [linux-next:master 9992/12641] drivers/mfd/rk808.c:754:1: sparse: sparse: symbol 'rk8xx_pm_ops' was not declared. Should it be static? kbuild test robot
2019-07-08  7:08 ` [RFC PATCH linux-next] mfd: rk808: rk8xx_pm_ops can be static kbuild test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).