* [PATCH] scsi: libsas: remove the exporting of sas_wait_eh
@ 2019-07-08 16:43 Denis Efremov
2019-07-09 1:58 ` Jason Yan
2019-07-12 0:34 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Denis Efremov @ 2019-07-08 16:43 UTC (permalink / raw)
To: Dan Williams
Cc: Denis Efremov, James E.J. Bottomley, Martin K. Petersen,
linux-scsi, linux-kernel
The function sas_wait_eh is declared static and marked
EXPORT_SYMBOL, which is at best an odd combination. Because the
function is not used outside of the drivers/scsi/libsas/sas_scsi_host.c
file it is defined in, this commit removes the EXPORT_SYMBOL() marking.
Signed-off-by: Denis Efremov <efremov@linux.com>
---
drivers/scsi/libsas/sas_scsi_host.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c
index ede0674d8399..5564d3f1243a 100644
--- a/drivers/scsi/libsas/sas_scsi_host.c
+++ b/drivers/scsi/libsas/sas_scsi_host.c
@@ -414,7 +414,6 @@ static void sas_wait_eh(struct domain_device *dev)
goto retry;
}
}
-EXPORT_SYMBOL(sas_wait_eh);
static int sas_queue_reset(struct domain_device *dev, int reset_type,
u64 lun, int wait)
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: libsas: remove the exporting of sas_wait_eh
2019-07-08 16:43 [PATCH] scsi: libsas: remove the exporting of sas_wait_eh Denis Efremov
@ 2019-07-09 1:58 ` Jason Yan
2019-07-12 0:34 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Jason Yan @ 2019-07-09 1:58 UTC (permalink / raw)
To: Denis Efremov, Dan Williams
Cc: James E.J. Bottomley, Martin K. Petersen, linux-scsi, linux-kernel
On 2019/7/9 0:43, Denis Efremov wrote:
> The function sas_wait_eh is declared static and marked
> EXPORT_SYMBOL, which is at best an odd combination. Because the
> function is not used outside of the drivers/scsi/libsas/sas_scsi_host.c
> file it is defined in, this commit removes the EXPORT_SYMBOL() marking.
>
> Signed-off-by: Denis Efremov <efremov@linux.com>
> ---
> drivers/scsi/libsas/sas_scsi_host.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c
> index ede0674d8399..5564d3f1243a 100644
> --- a/drivers/scsi/libsas/sas_scsi_host.c
> +++ b/drivers/scsi/libsas/sas_scsi_host.c
> @@ -414,7 +414,6 @@ static void sas_wait_eh(struct domain_device *dev)
> goto retry;
> }
> }
> -EXPORT_SYMBOL(sas_wait_eh);
>
> static int sas_queue_reset(struct domain_device *dev, int reset_type,
> u64 lun, int wait)
>
Reviewed-by: Jason Yan <yanaijie@huawei.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: libsas: remove the exporting of sas_wait_eh
2019-07-08 16:43 [PATCH] scsi: libsas: remove the exporting of sas_wait_eh Denis Efremov
2019-07-09 1:58 ` Jason Yan
@ 2019-07-12 0:34 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2019-07-12 0:34 UTC (permalink / raw)
To: Denis Efremov
Cc: Dan Williams, James E.J. Bottomley, Martin K. Petersen,
linux-scsi, linux-kernel
Denis,
> The function sas_wait_eh is declared static and marked
> EXPORT_SYMBOL, which is at best an odd combination. Because the
> function is not used outside of the drivers/scsi/libsas/sas_scsi_host.c
> file it is defined in, this commit removes the EXPORT_SYMBOL() marking.
Applied to 5.3/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-12 0:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-08 16:43 [PATCH] scsi: libsas: remove the exporting of sas_wait_eh Denis Efremov
2019-07-09 1:58 ` Jason Yan
2019-07-12 0:34 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).