[RFC PATCH linux-next] nfsd: force_expire_client() can be static

[RFC PATCH linux-next] nfsd: force_expire_client() can be static

[kbuild test robot]

Fixes: 89c905beccbb ("nfsd: allow forced expiration of NFSv4 clients")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 nfs4state.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index e6229bf..9012d78 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -2505,7 +2505,7 @@ static const struct file_operations client_states_fops = {
  * so the caller has a guarantee that the client's locks are gone by
  * the time the write returns:
  */
-void force_expire_client(struct nfs4_client *clp)
+static void force_expire_client(struct nfs4_client *clp)
 {
 	struct nfsd_net *nn = net_generic(clp->net, nfsd_net_id);
 	bool already_expired;

[linux-next:master 11868/13492] fs/nfsd/nfs4state.c:2508:6: sparse: sparse: symbol 'force_expire_client' was not declared. Should it be static?

[kbuild test robot]

tree:   https://kernel.googlesource.com/pub/scm/linux/kernel/git/next/linux-next.git master
head:   4608a726c66807c27bc7d91bdf8a288254e29985
commit: 89c905beccbbafa88490c8c4c35eaec5ce4c1329 [11868/13492] nfsd: allow forced expiration of NFSv4 clients
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-rc1-7-g2b96cd8-dirty
        git checkout 89c905beccbbafa88490c8c4c35eaec5ce4c1329
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

   fs/nfsd/nfs4state.c:2352:23: sparse: sparse: unknown escape sequence: '%'
   fs/nfsd/nfs4state.c:2352:23: sparse: sparse: unknown escape sequence: '%'
   fs/nfsd/nfs4state.c:2355:23: sparse: sparse: unknown escape sequence: '%'
   fs/nfsd/nfs4state.c:2355:23: sparse: sparse: unknown escape sequence: '%'
   fs/nfsd/nfs4state.c:1907:6: sparse: sparse: symbol 'drop_client' was not declared. Should it be static?
>> fs/nfsd/nfs4state.c:2508:6: sparse: sparse: symbol 'force_expire_client' was not declared. Should it be static?
   include/linux/rculist.h:455:20: sparse: sparse: context imbalance in 'put_nfs4_file' - unexpected unlock
   include/linux/list.h:125:25: sparse: sparse: context imbalance in 'put_clnt_odstate' - unexpected unlock
   fs/nfsd/nfs4state.c:915:9: sparse: sparse: context imbalance in 'nfs4_put_stid' - unexpected unlock

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation