linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	Vincent Whitchurch <vincent.whitchurch@axis.com>,
	Vincent Whitchurch <rabinv@axis.com>,
	sergey.senozhatsky@gmail.com, rostedt@goodmis.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] printk: Do not lose last line in kmsg dump
Date: Wed, 10 Jul 2019 17:39:10 +0900	[thread overview]
Message-ID: <20190710083910.GA12600@jagdpanzerIV> (raw)
In-Reply-To: <20190709142939.luqhbd6x6bzdkydr@pathway.suse.cz>

On (07/09/19 16:29), Petr Mladek wrote:
> 
> Anyway, if nobody vetoes the patch, I would schedule it for 5.4.
> We are already in the merge window and it deserves some testing
> in linux-next.
> 

I don't really want to veto it, but I'm not comfortable with fixing
off-by-one error by introducing another off-by-one error. The former
one leads to a missing message, the latter one to memory corruption.
Given that Vincent did find the code which does `buf[len] = 0x00'
[kudos to Vincent] let's have a better solution here. Otherwise, the
patch can make it to -stable via AUTOSEL machinery and then "we have
a problem".

Objections?

	-ss

      parent reply	other threads:[~2019-07-10  8:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-09  8:10 [PATCH] printk: Do not lose last line in kmsg dump Vincent Whitchurch
2019-07-09 10:12 ` Sergey Senozhatsky
2019-07-09 14:29   ` Petr Mladek
2019-07-09 15:20     ` Steven Rostedt
2019-07-10  8:04     ` Vincent Whitchurch
2019-07-10  8:19       ` Sergey Senozhatsky
2019-07-10 12:10         ` Petr Mladek
2019-07-10 12:47           ` Steven Rostedt
2019-07-10  8:39     ` Sergey Senozhatsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190710083910.GA12600@jagdpanzerIV \
    --to=sergey.senozhatsky.work@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=rabinv@axis.com \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=vincent.whitchurch@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).