* [PATCH 2/2] Fixed a brace styling issue
@ 2019-07-10 10:01 sheetalsingala
2019-07-11 7:03 ` Marcel Holtmann
0 siblings, 1 reply; 2+ messages in thread
From: sheetalsingala @ 2019-07-10 10:01 UTC (permalink / raw)
To: marcel; +Cc: linux-bluetooth, linux-kernel, sheetalsingala
Fixed a coding style issue
Signed-off-by: Sheetal Singala <2396sheetal@gmail.com>
---
drivers/bluetooth/btintel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
index bb99c8653aab..4a8b812605f3 100644
--- a/drivers/bluetooth/btintel.c
+++ b/drivers/bluetooth/btintel.c
@@ -18,7 +18,7 @@
#define VERSION "0.1"
-#define BDADDR_INTEL (&(bdaddr_t) {{0x00, 0x8b, 0x9e, 0x19, 0x03, 0x00}})
+#define BDADDR_INTEL (&(bdaddr_t) {0x00, 0x8b, 0x9e, 0x19, 0x03, 0x00})
int btintel_check_bdaddr(struct hci_dev *hdev)
{
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] Fixed a brace styling issue
2019-07-10 10:01 [PATCH 2/2] Fixed a brace styling issue sheetalsingala
@ 2019-07-11 7:03 ` Marcel Holtmann
0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2019-07-11 7:03 UTC (permalink / raw)
To: sheetalsingala; +Cc: marcel, Linux Bluetooth mailing list, linux-kernel
Hi,
> Fixed a coding style issue
>
> Signed-off-by: Sheetal Singala <2396sheetal@gmail.com>
> ---
> drivers/bluetooth/btintel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
> index bb99c8653aab..4a8b812605f3 100644
> --- a/drivers/bluetooth/btintel.c
> +++ b/drivers/bluetooth/btintel.c
> @@ -18,7 +18,7 @@
>
> #define VERSION "0.1"
>
> -#define BDADDR_INTEL (&(bdaddr_t) {{0x00, 0x8b, 0x9e, 0x19, 0x03, 0x00}})
> +#define BDADDR_INTEL (&(bdaddr_t) {0x00, 0x8b, 0x9e, 0x19, 0x03, 0x00})
maybe you want to test your patches before sending them.
CC drivers/bluetooth/btintel.o
drivers/bluetooth/btintel.c: In function ‘btintel_check_bdaddr’:
drivers/bluetooth/btintel.c:21:24: warning: missing braces around initializer [-Wmissing-braces]
21 | #define BDADDR_INTEL (&(bdaddr_t) {0x00, 0x8b, 0x9e, 0x19, 0x03, 0x00})
| ^
drivers/bluetooth/btintel.c:50:27: note: in expansion of macro ‘BDADDR_INTEL’
50 | if (!bacmp(&bda->bdaddr, BDADDR_INTEL)) {
| ^~~~~~~~~~~~
Regards
Marcel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-11 7:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-10 10:01 [PATCH 2/2] Fixed a brace styling issue sheetalsingala
2019-07-11 7:03 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).