From: Peter Zijlstra <peterz@infradead.org>
To: Jiri Kosina <jikos@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Xi Ruoyao <xry111@mengyan1223.wang>,
Kees Cook <keescook@chromium.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
Borislav Petkov <bp@alien8.de>, Len Brown <lenb@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Tony Luck <tony.luck@intel.com>,
Bob Moore <robert.moore@intel.com>,
Erik Schmauss <erik.schmauss@intel.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Nadav Amit <namit@vmware.com>
Subject: Re: [GIT PULL] x86/topology changes for v5.3
Date: Wed, 10 Jul 2019 15:21:44 +0200 [thread overview]
Message-ID: <20190710132144.GM3402@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <nycvar.YFH.7.76.1907101425290.5899@cbobk.fhfr.pm>
On Wed, Jul 10, 2019 at 02:31:29PM +0200, Jiri Kosina wrote:
> On Wed, 10 Jul 2019, Thomas Gleixner wrote:
>
> > From the log:
> >
> > BUG: unable to handle page fault for address: ffffffff9edc1598
> > #PF: supervisor write access in kernel mode
> > #PF: error_code(0x0003) - permissions violation
> > PGD 1a20c067 P4D 1a20c067 PUD 1a20d063 PMD 8000000019e000e1
> > Oops: 0003 [#1] SMP PTI
> > 2 PID: 151 Comm: systemd-udevd Not tainted 5.2.0+ #54
> > Hardware name: LENOVO 20175/INVALID, BIOS 66CN54WW 01/21/2013
> > RIP: 0010:static_key_set_mod.isra.0+0x10/0x30
> > Code: 48 8b 37 83 e6 03 48 09 c6 48 89 37 c3 66 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f0 a8 03 75 0d 48 8b 37 83 e6 03 48 09 c6 <48> 89 37 c3 0f 0b 48 8b 37 83 e6 03 48 09 c6 48 89 37 c3 66 66 2e
> > RSP: 0000:ffffa606c032bc98 EFLAGS: 00010286
> > RAX: ffff9981ddce30a0 RBX: ffffffff9edc1590 RCX: 0000000000000000
> > RDX: 0000000000000020 RSI: ffff9981ddce30a0 RDI: ffffffff9edc1598
> > RBP: ffffffffc06f4000 R08: ffff9981e6003980 R09: ffff9981ddce30a0
> > R10: 0000000000000000 R11: 0000000000028b56 R12: ffffffffc06f8880
> > R13: ffff9981ddce3080 R14: ffffffffc06f4008 R15: ffffffffc06f6dc0
> > FS: 00007f992dd9a680(0000) GS:ffff9981e7080000(0000) knlGS:0000000000000000
> > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > CR2: ffffffff9edc1598 CR3: 00000002233aa001 CR4: 00000000001606e0
> > Call Trace:
> > jump_label_module_notify+0x1e7/0x2b0
> > notifier_call_chain+0x44/0x70
> > blocking_notifier_call_chain+0x43/0x60
> > load_module+0x1bcb/0x2490
> > ? vfs_read+0x11f/0x150
> > ? __do_sys_finit_module+0xbf/0xe0
> > __do_sys_finit_module+0xbf/0xe0
> > do_syscall_64+0x43/0x110
> > entry_SYSCALL_64_after_hwframe+0x44/0xa9
> >
> > Josh, didn't you mention that yesterday or so?
>
> That's what Tony yesterday indicated on IRC that his system is suffering
> from as well.
>
> Adding Daniel to check whether this couldn't be some fallout of jumplabel
> batching.
AFAICT this is _before_ we get to patching. The function that explodes
is static_key_set_mod(), as called from jump_label_add_module().
What that function does is for all patch sites in the module, find the
corresponding key; if that key is not also in that module, allocate a
static_key_mod structure and link the module entries to the key. Such
that we can find all instances from a given key.
I don't think anything here has changed in a while.
next prev parent reply other threads:[~2019-07-10 13:22 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 16:27 [GIT PULL] x86/topology changes for v5.3 Ingo Molnar
2019-07-09 1:45 ` pr-tracker-bot
2019-07-09 21:20 ` Linus Torvalds
2019-07-09 21:26 ` Linus Torvalds
2019-07-09 21:45 ` Linus Torvalds
2019-07-09 22:00 ` Linus Torvalds
2019-07-09 22:07 ` Linus Torvalds
2019-07-09 22:27 ` Thomas Gleixner
2019-07-09 23:00 ` Thomas Gleixner
2019-07-09 23:17 ` Thomas Gleixner
2019-07-10 0:31 ` Kees Cook
2019-07-10 11:27 ` Xi Ruoyao
2019-07-10 12:01 ` Xi Ruoyao
2019-07-10 12:19 ` Thomas Gleixner
2019-07-10 12:31 ` Jiri Kosina
2019-07-10 13:21 ` Peter Zijlstra [this message]
2019-07-10 13:27 ` Jiri Kosina
2019-07-10 13:28 ` Jiri Kosina
2019-07-10 13:31 ` Xi Ruoyao
2019-07-10 13:25 ` Xi Ruoyao
2019-07-10 13:44 ` Peter Zijlstra
2019-07-10 14:03 ` Thomas Gleixner
2019-07-10 14:26 ` Thomas Gleixner
2019-07-10 14:22 ` Jiri Kosina
2019-07-10 14:26 ` Peter Zijlstra
2019-07-10 15:13 ` Thomas Gleixner
2019-07-10 15:58 ` Xi Ruoyao
2019-07-10 19:42 ` [PATCH] x86/asm: Move native_write_cr0/3() out of line Thomas Gleixner
2019-07-10 19:59 ` Kees Cook
2019-07-10 20:00 ` Thomas Gleixner
2019-07-10 20:02 ` Peter Zijlstra
2019-07-10 20:19 ` [tip:x86/urgent] x86/asm: Move native_write_cr0/4() " tip-bot for Thomas Gleixner
2019-07-10 14:44 ` [GIT PULL] x86/topology changes for v5.3 Xi Ruoyao
2019-07-11 7:11 ` Nadav Amit
2019-07-11 7:16 ` Thomas Gleixner
2019-07-11 8:01 ` Peter Zijlstra
2019-07-11 15:08 ` Kees Cook
2019-07-11 17:09 ` Nadav Amit
2019-07-10 0:59 ` Linus Torvalds
2019-07-10 1:08 ` Linus Torvalds
2019-07-10 3:21 ` Linus Torvalds
2019-07-10 5:15 ` Linus Torvalds
2019-07-10 5:33 ` Kees Cook
2019-07-10 18:40 ` Linus Torvalds
2019-07-10 10:03 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190710132144.GM3402@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=bristot@redhat.com \
--cc=erik.schmauss@intel.com \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=keescook@chromium.org \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namit@vmware.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=xry111@mengyan1223.wang \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).