From: David Miller <davem@davemloft.net>
To: cai@lca.pw
Cc: sathya.perla@broadcom.com, ajit.khaparde@broadcom.com,
sriharsha.basavapatna@broadcom.com, somnath.kotur@broadcom.com,
arnd@arndb.de, dhowells@redhat.com, hpa@zytor.com,
netdev@vger.kernel.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] be2net: fix adapter->big_page_size miscaculation
Date: Fri, 12 Jul 2019 15:46:06 -0700 (PDT) [thread overview]
Message-ID: <20190712.154606.493382088615011132.davem@davemloft.net> (raw)
In-Reply-To: <1562959401-19815-1-git-send-email-cai@lca.pw>
From: Qian Cai <cai@lca.pw>
Date: Fri, 12 Jul 2019 15:23:21 -0400
> The commit d66acc39c7ce ("bitops: Optimise get_order()") introduced a
> problem for the be2net driver as "rx_frag_size" could be a module
> parameter that can be changed while loading the module.
Why is this a problem?
> That commit checks __builtin_constant_p() first in get_order() which
> cause "adapter->big_page_size" to be assigned a value based on the
> the default "rx_frag_size" value at the compilation time. It also
> generate a compilation warning,
rx_frag_size is not a constant, therefore the __builtin_constant_p()
test should not pass.
This explanation doesn't seem valid.
next prev parent reply other threads:[~2019-07-12 22:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 19:23 [PATCH] be2net: fix adapter->big_page_size miscaculation Qian Cai
2019-07-12 22:46 ` David Miller [this message]
2019-07-13 0:27 ` Qian Cai
2019-07-13 0:50 ` David Miller
2019-07-18 21:01 ` Qian Cai
2019-07-18 21:10 ` Nick Desaulniers
2019-07-18 21:21 ` Bill Wendling
2019-07-18 23:26 ` Qian Cai
2019-07-18 23:29 ` David Miller
2019-07-19 21:47 ` Qian Cai
2019-07-22 21:13 ` Qian Cai
2019-07-22 22:58 ` James Y Knight
2019-07-23 3:08 ` Qian Cai
[not found] ` <CAGG=3QWkgm+YhC=TWEWwt585Lbm8ZPG-uFre-kBRv+roPzZFbA@mail.gmail.com>
2019-07-18 21:22 ` Nick Desaulniers
2019-07-18 21:28 ` Bill Wendling
2019-07-19 10:32 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190712.154606.493382088615011132.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ajit.khaparde@broadcom.com \
--cc=arnd@arndb.de \
--cc=cai@lca.pw \
--cc=dhowells@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sathya.perla@broadcom.com \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).