From: David Miller <davem@davemloft.net>
To: cai@lca.pw
Cc: morbo@google.com, ndesaulniers@google.com, jyknight@google.com,
sathya.perla@broadcom.com, ajit.khaparde@broadcom.com,
sriharsha.basavapatna@broadcom.com, somnath.kotur@broadcom.com,
arnd@arndb.de, dhowells@redhat.com, hpa@zytor.com,
netdev@vger.kernel.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org, natechancellor@gmail.com
Subject: Re: [PATCH] be2net: fix adapter->big_page_size miscaculation
Date: Thu, 18 Jul 2019 16:29:28 -0700 (PDT) [thread overview]
Message-ID: <20190718.162928.124906203979938369.davem@davemloft.net> (raw)
In-Reply-To: <75B428FC-734C-4B15-B1A7-A3FC5F9F2FE5@lca.pw>
From: Qian Cai <cai@lca.pw>
Date: Thu, 18 Jul 2019 19:26:47 -0400
>
>
>> On Jul 18, 2019, at 5:21 PM, Bill Wendling <morbo@google.com> wrote:
>>
>> [My previous response was marked as spam...]
>>
>> Top-of-tree clang says that it's const:
>>
>> $ gcc a.c -O2 && ./a.out
>> a is a const.
>>
>> $ clang a.c -O2 && ./a.out
>> a is a const.
>
>
> I used clang-7.0.1. So, this is getting worse where both GCC and clang will start to suffer the
> same problem.
Then rewrite the module parameter macros such that the non-constness
is evident to all compilers regardless of version.
That is the place to fix this, otherwise we will just be adding hacks
all over the place rather than in just one spot.
Thanks.
next prev parent reply other threads:[~2019-07-18 23:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 19:23 [PATCH] be2net: fix adapter->big_page_size miscaculation Qian Cai
2019-07-12 22:46 ` David Miller
2019-07-13 0:27 ` Qian Cai
2019-07-13 0:50 ` David Miller
2019-07-18 21:01 ` Qian Cai
2019-07-18 21:10 ` Nick Desaulniers
2019-07-18 21:21 ` Bill Wendling
2019-07-18 23:26 ` Qian Cai
2019-07-18 23:29 ` David Miller [this message]
2019-07-19 21:47 ` Qian Cai
2019-07-22 21:13 ` Qian Cai
2019-07-22 22:58 ` James Y Knight
2019-07-23 3:08 ` Qian Cai
[not found] ` <CAGG=3QWkgm+YhC=TWEWwt585Lbm8ZPG-uFre-kBRv+roPzZFbA@mail.gmail.com>
2019-07-18 21:22 ` Nick Desaulniers
2019-07-18 21:28 ` Bill Wendling
2019-07-19 10:32 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190718.162928.124906203979938369.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ajit.khaparde@broadcom.com \
--cc=arnd@arndb.de \
--cc=cai@lca.pw \
--cc=dhowells@redhat.com \
--cc=hpa@zytor.com \
--cc=jyknight@google.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=morbo@google.com \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=sathya.perla@broadcom.com \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).