* [PATCH] drm/atmel-hlcdc: set layer REP bit to enable replication logic
@ 2019-07-09 15:35 Joshua.Henderson
2019-07-09 16:24 ` Nicolas.Ferre
0 siblings, 1 reply; 5+ messages in thread
From: Joshua.Henderson @ 2019-07-09 15:35 UTC (permalink / raw)
To: boris.brezillon, airlied, Nicolas.Ferre, alexandre.belloni
Cc: dri-devel, linux-arm-kernel, linux-kernel
This bit enables replication logic to expand an RGB color less than 24
bits, to 24 bits, which is used internally for all formats. Otherwise,
the least significant bits are always set to zero and the color may not
be what is expected.
Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>
---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
index eb7c4cf..6f6cf61 100644
--- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
+++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
@@ -389,7 +389,7 @@ atmel_hlcdc_plane_update_general_settings(struct atmel_hlcdc_plane *plane,
atmel_hlcdc_layer_write_cfg(&plane->layer, ATMEL_HLCDC_LAYER_DMA_CFG,
cfg);
- cfg = ATMEL_HLCDC_LAYER_DMA;
+ cfg = ATMEL_HLCDC_LAYER_DMA | ATMEL_HLCDC_LAYER_REP;
if (plane->base.type != DRM_PLANE_TYPE_PRIMARY) {
cfg |= ATMEL_HLCDC_LAYER_OVR | ATMEL_HLCDC_LAYER_ITER2BL |
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/atmel-hlcdc: set layer REP bit to enable replication logic
2019-07-09 15:35 [PATCH] drm/atmel-hlcdc: set layer REP bit to enable replication logic Joshua.Henderson
@ 2019-07-09 16:24 ` Nicolas.Ferre
2019-07-12 16:21 ` Sam Ravnborg
0 siblings, 1 reply; 5+ messages in thread
From: Nicolas.Ferre @ 2019-07-09 16:24 UTC (permalink / raw)
To: Joshua.Henderson, bbrezillon, airlied, alexandre.belloni
Cc: dri-devel, linux-arm-kernel, linux-kernel, sam
On 09/07/2019 at 17:35, Joshua Henderson wrote:
> This bit enables replication logic to expand an RGB color less than 24
> bits, to 24 bits, which is used internally for all formats. Otherwise,
> the least significant bits are always set to zero and the color may not
> be what is expected.
>
> Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Here is patchwork entry:
https://patchwork.kernel.org/patch/11037167/
Thanks, best regards,
Nicolas
> ---
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> index eb7c4cf..6f6cf61 100644
> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> @@ -389,7 +389,7 @@ atmel_hlcdc_plane_update_general_settings(struct atmel_hlcdc_plane *plane,
> atmel_hlcdc_layer_write_cfg(&plane->layer, ATMEL_HLCDC_LAYER_DMA_CFG,
> cfg);
>
> - cfg = ATMEL_HLCDC_LAYER_DMA;
> + cfg = ATMEL_HLCDC_LAYER_DMA | ATMEL_HLCDC_LAYER_REP;
>
> if (plane->base.type != DRM_PLANE_TYPE_PRIMARY) {
> cfg |= ATMEL_HLCDC_LAYER_OVR | ATMEL_HLCDC_LAYER_ITER2BL |
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/atmel-hlcdc: set layer REP bit to enable replication logic
2019-07-09 16:24 ` Nicolas.Ferre
@ 2019-07-12 16:21 ` Sam Ravnborg
2019-07-12 16:27 ` Boris Brezillon
2019-07-12 16:32 ` Boris Brezillon
0 siblings, 2 replies; 5+ messages in thread
From: Sam Ravnborg @ 2019-07-12 16:21 UTC (permalink / raw)
To: Nicolas.Ferre, Joshua Henderson
Cc: Joshua.Henderson, bbrezillon, airlied, alexandre.belloni,
linux-arm-kernel, dri-devel, linux-kernel
Hi Joshua.
On Tue, Jul 09, 2019 at 04:24:49PM +0000, Nicolas.Ferre@microchip.com wrote:
> On 09/07/2019 at 17:35, Joshua Henderson wrote:
> > This bit enables replication logic to expand an RGB color less than 24
> > bits, to 24 bits, which is used internally for all formats. Otherwise,
> > the least significant bits are always set to zero and the color may not
> > be what is expected.
> >
> > Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>
>
> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
>
> Here is patchwork entry:
> https://patchwork.kernel.org/patch/11037167/
>
> Thanks, best regards,
> Nicolas
>
> > ---
> > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > index eb7c4cf..6f6cf61 100644
> > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > @@ -389,7 +389,7 @@ atmel_hlcdc_plane_update_general_settings(struct atmel_hlcdc_plane *plane,
> > atmel_hlcdc_layer_write_cfg(&plane->layer, ATMEL_HLCDC_LAYER_DMA_CFG,
> > cfg);
> >
> > - cfg = ATMEL_HLCDC_LAYER_DMA;
> > + cfg = ATMEL_HLCDC_LAYER_DMA | ATMEL_HLCDC_LAYER_REP;
> >
> > if (plane->base.type != DRM_PLANE_TYPE_PRIMARY) {
> > cfg |= ATMEL_HLCDC_LAYER_OVR | ATMEL_HLCDC_LAYER_ITER2BL |
Thanks - this gave me an opportunity to read a bit more in the datasheet
of the controller.
Applied to drm-misc-next with Ack from Nicolas.
Sam
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/atmel-hlcdc: set layer REP bit to enable replication logic
2019-07-12 16:21 ` Sam Ravnborg
@ 2019-07-12 16:27 ` Boris Brezillon
2019-07-12 16:32 ` Boris Brezillon
1 sibling, 0 replies; 5+ messages in thread
From: Boris Brezillon @ 2019-07-12 16:27 UTC (permalink / raw)
To: Sam Ravnborg
Cc: Nicolas.Ferre, Joshua Henderson, bbrezillon, airlied,
alexandre.belloni, linux-arm-kernel, dri-devel, linux-kernel
On Fri, 12 Jul 2019 18:21:17 +0200
Sam Ravnborg <sam@ravnborg.org> wrote:
> Hi Joshua.
>
> On Tue, Jul 09, 2019 at 04:24:49PM +0000, Nicolas.Ferre@microchip.com wrote:
> > On 09/07/2019 at 17:35, Joshua Henderson wrote:
> > > This bit enables replication logic to expand an RGB color less than 24
> > > bits, to 24 bits, which is used internally for all formats. Otherwise,
> > > the least significant bits are always set to zero and the color may not
> > > be what is expected.
> > >
> > > Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>
> >
> > Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> >
> > Here is patchwork entry:
> > https://patchwork.kernel.org/patch/11037167/
> >
> > Thanks, best regards,
> > Nicolas
> >
> > > ---
> > > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > > index eb7c4cf..6f6cf61 100644
> > > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > > @@ -389,7 +389,7 @@ atmel_hlcdc_plane_update_general_settings(struct atmel_hlcdc_plane *plane,
> > > atmel_hlcdc_layer_write_cfg(&plane->layer, ATMEL_HLCDC_LAYER_DMA_CFG,
> > > cfg);
> > >
> > > - cfg = ATMEL_HLCDC_LAYER_DMA;
> > > + cfg = ATMEL_HLCDC_LAYER_DMA | ATMEL_HLCDC_LAYER_REP;
> > >
> > > if (plane->base.type != DRM_PLANE_TYPE_PRIMARY) {
> > > cfg |= ATMEL_HLCDC_LAYER_OVR | ATMEL_HLCDC_LAYER_ITER2BL |
>
> Thanks - this gave me an opportunity to read a bit more in the datasheet
> of the controller.
> Applied to drm-misc-next with Ack from Nicolas.
I was about to add my R-b and ask you to apply the patch :-). I'm glad
you didn't wait for my feedback to apply the fix, that means I'll be
able to remove my name from the Atmel HLCDC entry soon ;-).
>
> Sam
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/atmel-hlcdc: set layer REP bit to enable replication logic
2019-07-12 16:21 ` Sam Ravnborg
2019-07-12 16:27 ` Boris Brezillon
@ 2019-07-12 16:32 ` Boris Brezillon
1 sibling, 0 replies; 5+ messages in thread
From: Boris Brezillon @ 2019-07-12 16:32 UTC (permalink / raw)
To: Sam Ravnborg
Cc: Nicolas.Ferre, Joshua Henderson, bbrezillon, airlied,
alexandre.belloni, linux-arm-kernel, dri-devel, linux-kernel
On Fri, 12 Jul 2019 18:21:17 +0200
Sam Ravnborg <sam@ravnborg.org> wrote:
> Hi Joshua.
>
> On Tue, Jul 09, 2019 at 04:24:49PM +0000, Nicolas.Ferre@microchip.com wrote:
> > On 09/07/2019 at 17:35, Joshua Henderson wrote:
> > > This bit enables replication logic to expand an RGB color less than 24
> > > bits, to 24 bits, which is used internally for all formats. Otherwise,
> > > the least significant bits are always set to zero and the color may not
> > > be what is expected.
> > >
> > > Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>
> >
> > Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> >
> > Here is patchwork entry:
> > https://patchwork.kernel.org/patch/11037167/
> >
> > Thanks, best regards,
> > Nicolas
> >
> > > ---
> > > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > > index eb7c4cf..6f6cf61 100644
> > > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > > @@ -389,7 +389,7 @@ atmel_hlcdc_plane_update_general_settings(struct atmel_hlcdc_plane *plane,
> > > atmel_hlcdc_layer_write_cfg(&plane->layer, ATMEL_HLCDC_LAYER_DMA_CFG,
> > > cfg);
> > >
> > > - cfg = ATMEL_HLCDC_LAYER_DMA;
> > > + cfg = ATMEL_HLCDC_LAYER_DMA | ATMEL_HLCDC_LAYER_REP;
> > >
> > > if (plane->base.type != DRM_PLANE_TYPE_PRIMARY) {
> > > cfg |= ATMEL_HLCDC_LAYER_OVR | ATMEL_HLCDC_LAYER_ITER2BL |
>
> Thanks - this gave me an opportunity to read a bit more in the datasheet
> of the controller.
> Applied to drm-misc-next with Ack from Nicolas.
Was about to add my R-b and ask you to apply the patch. I'm glad you
didn't wait for my feedback though, that means I'll soon be able to
remove my name from the Atmel HLCDC entry in MAINTAINERS ;-).
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-02-13 16:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-09 15:35 [PATCH] drm/atmel-hlcdc: set layer REP bit to enable replication logic Joshua.Henderson
2019-07-09 16:24 ` Nicolas.Ferre
2019-07-12 16:21 ` Sam Ravnborg
2019-07-12 16:27 ` Boris Brezillon
2019-07-12 16:32 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).