[PATCH] perf version: Fix segfault

[PATCH] perf version: Fix segfault

[Ravi Bangoria]

'perf version' on powerpc segfaults when used with non-supported
option:
  # perf version -a
  Segmentation fault (core dumped)

Fix this.

Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Reviewed-by: Kamalesh babulal <kamalesh@linux.vnet.ibm.com>
Tested-by: Mamatha Inamdar <mamatha4@linux.vnet.ibm.com>
---
 tools/perf/builtin-version.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/perf/builtin-version.c b/tools/perf/builtin-version.c
index f470144d1a70..bf114ca9ca87 100644
--- a/tools/perf/builtin-version.c
+++ b/tools/perf/builtin-version.c
@@ -19,6 +19,7 @@ static struct version version;
 static struct option version_options[] = {
 	OPT_BOOLEAN(0, "build-options", &version.build_options,
 		    "display the build options"),
+	OPT_END(),
 };
 
 static const char * const version_usage[] = {
-- 
2.20.1

Re: [PATCH] perf version: Fix segfault

[Arnaldo Carvalho de Melo]

Em Tue, Jun 11, 2019 at 08:31:09AM +0530, Ravi Bangoria escreveu:
> 'perf version' on powerpc segfaults when used with non-supported
> option:
>   # perf version -a
>   Segmentation fault (core dumped)
> 
> Fix this.
> 
> Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
> Reviewed-by: Kamalesh babulal <kamalesh@linux.vnet.ibm.com>
> Tested-by: Mamatha Inamdar <mamatha4@linux.vnet.ibm.com>
> ---
>  tools/perf/builtin-version.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/perf/builtin-version.c b/tools/perf/builtin-version.c
> index f470144d1a70..bf114ca9ca87 100644
> --- a/tools/perf/builtin-version.c
> +++ b/tools/perf/builtin-version.c
> @@ -19,6 +19,7 @@ static struct version version;
>  static struct option version_options[] = {
>  	OPT_BOOLEAN(0, "build-options", &version.build_options,
>  		    "display the build options"),
> +	OPT_END(),
>  };

Thanks, applied.

- Arnaldo

[tip:perf/urgent] perf version: Fix segfault due to missing OPT_END()

[tip-bot for Ravi Bangoria]

Commit-ID:  916c31fff946fae0e05862f9b2435fdb29fd5090
Gitweb:     https://git.kernel.org/tip/916c31fff946fae0e05862f9b2435fdb29fd5090
Author:     Ravi Bangoria <ravi.bangoria@linux.ibm.com>
AuthorDate: Tue, 11 Jun 2019 08:31:09 +0530
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 15 Jul 2019 07:59:05 -0300

perf version: Fix segfault due to missing OPT_END()

'perf version' on powerpc segfaults when used with non-supported
option:
  # perf version -a
  Segmentation fault (core dumped)

Fix this.

Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Reviewed-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Tested-by: Mamatha Inamdar <mamatha4@linux.vnet.ibm.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Link: http://lkml.kernel.org/r/20190611030109.20228-1-ravi.bangoria@linux.ibm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-version.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/perf/builtin-version.c b/tools/perf/builtin-version.c
index f470144d1a70..bf114ca9ca87 100644
--- a/tools/perf/builtin-version.c
+++ b/tools/perf/builtin-version.c
@@ -19,6 +19,7 @@ static struct version version;
 static struct option version_options[] = {
 	OPT_BOOLEAN(0, "build-options", &version.build_options,
 		    "display the build options"),
+	OPT_END(),
 };
 
 static const char * const version_usage[] = {