* [PATCH 1/6] clk: Sync prototypes for clk_bulk_enable()
@ 2019-07-15 20:12 Andrey Smirnov
2019-07-15 20:12 ` [PATCH 2/6] clk: Sync prototypes for clk_bulk_prepare() Andrey Smirnov
` (5 more replies)
0 siblings, 6 replies; 8+ messages in thread
From: Andrey Smirnov @ 2019-07-15 20:12 UTC (permalink / raw)
To: linux-clk; +Cc: Andrey Smirnov, Russell King, Chris Healy, linux-kernel
No-op version of clk_bulk_enable() should have the same protoype as
the real implementation, so constify the last argument to make it so.
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Russell King <linux@armlinux.org.uk>
Cc: Chris Healy <cphealy@gmail.com>
Cc: linux-clk@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
include/linux/clk.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/clk.h b/include/linux/clk.h
index 3c096c7a51dc..a35868ccc912 100644
--- a/include/linux/clk.h
+++ b/include/linux/clk.h
@@ -819,7 +819,8 @@ static inline int clk_enable(struct clk *clk)
return 0;
}
-static inline int __must_check clk_bulk_enable(int num_clks, struct clk_bulk_data *clks)
+static inline int __must_check clk_bulk_enable(int num_clks,
+ const struct clk_bulk_data *clks)
{
return 0;
}
--
2.21.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/6] clk: Sync prototypes for clk_bulk_prepare()
2019-07-15 20:12 [PATCH 1/6] clk: Sync prototypes for clk_bulk_enable() Andrey Smirnov
@ 2019-07-15 20:12 ` Andrey Smirnov
2019-07-15 20:12 ` [PATCH 3/6] clk: Constify second argument of clk_bulk_prepare_enable() Andrey Smirnov
` (4 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Andrey Smirnov @ 2019-07-15 20:12 UTC (permalink / raw)
To: linux-clk; +Cc: Andrey Smirnov, Russell King, Chris Healy, linux-kernel
No-op version of clk_bulk_prepare() should have the same protoype as
the real implementation, so constify the last argument to make it so.
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Russell King <linux@armlinux.org.uk>
Cc: Chris Healy <cphealy@gmail.com>
Cc: linux-clk@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
include/linux/clk.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/clk.h b/include/linux/clk.h
index a35868ccc912..8af6b943bb9a 100644
--- a/include/linux/clk.h
+++ b/include/linux/clk.h
@@ -239,7 +239,8 @@ static inline int clk_prepare(struct clk *clk)
return 0;
}
-static inline int __must_check clk_bulk_prepare(int num_clks, struct clk_bulk_data *clks)
+static inline int __must_check
+clk_bulk_prepare(int num_clks, const struct clk_bulk_data *clks)
{
might_sleep();
return 0;
--
2.21.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 3/6] clk: Constify second argument of clk_bulk_prepare_enable()
2019-07-15 20:12 [PATCH 1/6] clk: Sync prototypes for clk_bulk_enable() Andrey Smirnov
2019-07-15 20:12 ` [PATCH 2/6] clk: Sync prototypes for clk_bulk_prepare() Andrey Smirnov
@ 2019-07-15 20:12 ` Andrey Smirnov
2019-07-15 20:12 ` [PATCH 4/6] clk: Sync prototypes for clk_bulk_disable() Andrey Smirnov
` (3 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Andrey Smirnov @ 2019-07-15 20:12 UTC (permalink / raw)
To: linux-clk; +Cc: Andrey Smirnov, Russell King, Chris Healy, linux-kernel
Both clk_bulk_prepare() and clk_bulk_enable() take const struct
clk_bulk_data, so change clk_bulk_prepare_enable() to do so as
well. No functional change intended.
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Russell King <linux@armlinux.org.uk>
Cc: Chris Healy <cphealy@gmail.com>
Cc: linux-clk@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
include/linux/clk.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/clk.h b/include/linux/clk.h
index 8af6b943bb9a..fafa63ea06b9 100644
--- a/include/linux/clk.h
+++ b/include/linux/clk.h
@@ -919,8 +919,8 @@ static inline void clk_disable_unprepare(struct clk *clk)
clk_unprepare(clk);
}
-static inline int __must_check clk_bulk_prepare_enable(int num_clks,
- struct clk_bulk_data *clks)
+static inline int __must_check
+clk_bulk_prepare_enable(int num_clks, const struct clk_bulk_data *clks)
{
int ret;
--
2.21.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 4/6] clk: Sync prototypes for clk_bulk_disable()
2019-07-15 20:12 [PATCH 1/6] clk: Sync prototypes for clk_bulk_enable() Andrey Smirnov
2019-07-15 20:12 ` [PATCH 2/6] clk: Sync prototypes for clk_bulk_prepare() Andrey Smirnov
2019-07-15 20:12 ` [PATCH 3/6] clk: Constify second argument of clk_bulk_prepare_enable() Andrey Smirnov
@ 2019-07-15 20:12 ` Andrey Smirnov
2019-07-15 20:12 ` [PATCH 5/6] clk: Sync prototypes for clk_bulk_unprepare() Andrey Smirnov
` (2 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Andrey Smirnov @ 2019-07-15 20:12 UTC (permalink / raw)
To: linux-clk; +Cc: Andrey Smirnov, Russell King, Chris Healy, linux-kernel
No-op version of clk_bulk_disable() should have the same protoype as
the real implementation, so constify the last argument to make it so.
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Russell King <linux@armlinux.org.uk>
Cc: Chris Healy <cphealy@gmail.com>
Cc: linux-clk@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
include/linux/clk.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/clk.h b/include/linux/clk.h
index fafa63ea06b9..2d3f2a55795a 100644
--- a/include/linux/clk.h
+++ b/include/linux/clk.h
@@ -830,7 +830,7 @@ static inline void clk_disable(struct clk *clk) {}
static inline void clk_bulk_disable(int num_clks,
- struct clk_bulk_data *clks) {}
+ const struct clk_bulk_data *clks) {}
static inline unsigned long clk_get_rate(struct clk *clk)
{
--
2.21.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 5/6] clk: Sync prototypes for clk_bulk_unprepare()
2019-07-15 20:12 [PATCH 1/6] clk: Sync prototypes for clk_bulk_enable() Andrey Smirnov
` (2 preceding siblings ...)
2019-07-15 20:12 ` [PATCH 4/6] clk: Sync prototypes for clk_bulk_disable() Andrey Smirnov
@ 2019-07-15 20:12 ` Andrey Smirnov
2019-07-15 20:12 ` [PATCH 6/6] clk: Constify second argument of clk_bulk_disable_unprepare() Andrey Smirnov
2019-07-15 22:00 ` [PATCH 1/6] clk: Sync prototypes for clk_bulk_enable() Stephen Boyd
5 siblings, 0 replies; 8+ messages in thread
From: Andrey Smirnov @ 2019-07-15 20:12 UTC (permalink / raw)
To: linux-clk; +Cc: Andrey Smirnov, Russell King, Chris Healy, linux-kernel
No-op version of clk_bulk_unprepare() should have the same protoype as
the real implementation, so constify the last argument to make it so.
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Russell King <linux@armlinux.org.uk>
Cc: Chris Healy <cphealy@gmail.com>
Cc: linux-clk@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
include/linux/clk.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/clk.h b/include/linux/clk.h
index 2d3f2a55795a..3956ae05b1cf 100644
--- a/include/linux/clk.h
+++ b/include/linux/clk.h
@@ -264,7 +264,8 @@ static inline void clk_unprepare(struct clk *clk)
{
might_sleep();
}
-static inline void clk_bulk_unprepare(int num_clks, struct clk_bulk_data *clks)
+static inline void clk_bulk_unprepare(int num_clks,
+ const struct clk_bulk_data *clks)
{
might_sleep();
}
--
2.21.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 6/6] clk: Constify second argument of clk_bulk_disable_unprepare()
2019-07-15 20:12 [PATCH 1/6] clk: Sync prototypes for clk_bulk_enable() Andrey Smirnov
` (3 preceding siblings ...)
2019-07-15 20:12 ` [PATCH 5/6] clk: Sync prototypes for clk_bulk_unprepare() Andrey Smirnov
@ 2019-07-15 20:12 ` Andrey Smirnov
2019-07-15 22:00 ` [PATCH 1/6] clk: Sync prototypes for clk_bulk_enable() Stephen Boyd
5 siblings, 0 replies; 8+ messages in thread
From: Andrey Smirnov @ 2019-07-15 20:12 UTC (permalink / raw)
To: linux-clk; +Cc: Andrey Smirnov, Russell King, Chris Healy, linux-kernel
Both clk_bulk_disable() and clk_bulk_unprepare() take const struct
clk_bulk_data, so change clk_bulk_disable_unprepare() to do so as
well. No functional change intended.
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Russell King <linux@armlinux.org.uk>
Cc: Chris Healy <cphealy@gmail.com>
Cc: linux-clk@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
include/linux/clk.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/clk.h b/include/linux/clk.h
index 3956ae05b1cf..7a795fd6d141 100644
--- a/include/linux/clk.h
+++ b/include/linux/clk.h
@@ -936,7 +936,7 @@ clk_bulk_prepare_enable(int num_clks, const struct clk_bulk_data *clks)
}
static inline void clk_bulk_disable_unprepare(int num_clks,
- struct clk_bulk_data *clks)
+ const struct clk_bulk_data *clks)
{
clk_bulk_disable(num_clks, clks);
clk_bulk_unprepare(num_clks, clks);
--
2.21.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/6] clk: Sync prototypes for clk_bulk_enable()
2019-07-15 20:12 [PATCH 1/6] clk: Sync prototypes for clk_bulk_enable() Andrey Smirnov
` (4 preceding siblings ...)
2019-07-15 20:12 ` [PATCH 6/6] clk: Constify second argument of clk_bulk_disable_unprepare() Andrey Smirnov
@ 2019-07-15 22:00 ` Stephen Boyd
2019-07-17 14:53 ` Andrey Smirnov
5 siblings, 1 reply; 8+ messages in thread
From: Stephen Boyd @ 2019-07-15 22:00 UTC (permalink / raw)
To: Andrey Smirnov, linux-clk
Cc: Andrey Smirnov, Russell King, Chris Healy, linux-kernel
Quoting Andrey Smirnov (2019-07-15 13:12:29)
> No-op version of clk_bulk_enable() should have the same protoype as
> the real implementation, so constify the last argument to make it so.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: Chris Healy <cphealy@gmail.com>
> Cc: linux-clk@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
No cover letter, but I'm inclined to squash these all together into one
patch instead of 6. I'm not sure why each function gets a different
patch.
> include/linux/clk.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/6] clk: Sync prototypes for clk_bulk_enable()
2019-07-15 22:00 ` [PATCH 1/6] clk: Sync prototypes for clk_bulk_enable() Stephen Boyd
@ 2019-07-17 14:53 ` Andrey Smirnov
0 siblings, 0 replies; 8+ messages in thread
From: Andrey Smirnov @ 2019-07-17 14:53 UTC (permalink / raw)
To: Stephen Boyd; +Cc: linux-clk, Russell King, Chris Healy, linux-kernel
On Mon, Jul 15, 2019 at 3:00 PM Stephen Boyd <sboyd@kernel.org> wrote:
>
> Quoting Andrey Smirnov (2019-07-15 13:12:29)
> > No-op version of clk_bulk_enable() should have the same protoype as
> > the real implementation, so constify the last argument to make it so.
> >
> > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> > Cc: Russell King <linux@armlinux.org.uk>
> > Cc: Chris Healy <cphealy@gmail.com>
> > Cc: linux-clk@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > ---
>
> No cover letter, but I'm inclined to squash these all together into one
> patch instead of 6. I'm not sure why each function gets a different
> patch.
>
Sure, will squash all in v2.
Thanks,
Andrey Smirnov
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-07-17 14:53 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-15 20:12 [PATCH 1/6] clk: Sync prototypes for clk_bulk_enable() Andrey Smirnov
2019-07-15 20:12 ` [PATCH 2/6] clk: Sync prototypes for clk_bulk_prepare() Andrey Smirnov
2019-07-15 20:12 ` [PATCH 3/6] clk: Constify second argument of clk_bulk_prepare_enable() Andrey Smirnov
2019-07-15 20:12 ` [PATCH 4/6] clk: Sync prototypes for clk_bulk_disable() Andrey Smirnov
2019-07-15 20:12 ` [PATCH 5/6] clk: Sync prototypes for clk_bulk_unprepare() Andrey Smirnov
2019-07-15 20:12 ` [PATCH 6/6] clk: Constify second argument of clk_bulk_disable_unprepare() Andrey Smirnov
2019-07-15 22:00 ` [PATCH 1/6] clk: Sync prototypes for clk_bulk_enable() Stephen Boyd
2019-07-17 14:53 ` Andrey Smirnov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).