From: Sam Ravnborg <sam@ravnborg.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Thierry Reding <thierry.reding@gmail.com>,
Sean Paul <seanpaul@chromium.org>,
Boris Brezillon <boris.brezillon@collabora.com>
Subject: Re: [PATCH] drm/panel: simple: Doxygenize 'struct panel_desc'; rename a few functions
Date: Sun, 21 Jul 2019 11:38:15 +0200 [thread overview]
Message-ID: <20190721093815.GA4375@ravnborg.org> (raw)
In-Reply-To: <20190717173317.GA4862@ravnborg.org>
Hi Doug.
On Wed, Jul 17, 2019 at 07:33:17PM +0200, Sam Ravnborg wrote:
> Hi Doug.
>
> On Fri, Jul 12, 2019 at 09:33:33AM -0700, Douglas Anderson wrote:
> > This attempts to address outstanding review feedback from commit
> > b8a2948fa2b3 ("drm/panel: simple: Add ability to override typical
> > timing"). Specifically:
> >
> > * It was requested that I document (in the structure definition) that
> > the device tree override had no effect if 'struct drm_display_mode'
> > was used in the panel description. I have provided full Doxygen
> > comments for 'struct panel_desc' to accomplish that.
> > * panel_simple_get_fixed_modes() was thought to be a confusing name,
> > so it has been renamed to panel_simple_get_display_modes().
> > * panel_simple_parse_override_mode() was thought to be better named as
> > panel_simple_parse_panel_timing_node().
> >
> > Suggested-by: Sam Ravnborg <sam@ravnborg.org>
> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
>
> Thanks.
>
> I updated the $subject to:
> drm/panel: simple: document panel_desc; rename a few functions
>
> And pushed out to drm-misc-next.
I see the following error printed at each boot:
/panel: could not find node 'panel-timing'
The error originates from this snip (from panel-simple.c):
if (!of_get_display_timing(dev->of_node, "panel-timing", &dt))
panel_simple_parse_panel_timing_node(dev, panel, &dt);
of_get_display_timing() returns -2 (-ENOENT).
In the setup I use there is no panel-timing node as the timing specified
in panel-simple.c is fine.
This is the typical setup - and there should not in the normal case
be printed error messages like this during boot.
Will you please take a look at this.
Sam
next prev parent reply other threads:[~2019-07-21 9:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 16:33 [PATCH] drm/panel: simple: Doxygenize 'struct panel_desc'; rename a few functions Douglas Anderson
2019-07-17 17:33 ` Sam Ravnborg
2019-07-21 9:38 ` Sam Ravnborg [this message]
2019-07-22 18:26 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190721093815.GA4375@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=boris.brezillon@collabora.com \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seanpaul@chromium.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).