linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] power: supply: max17042_battery: Fix a typo in function names
@ 2019-07-21 16:03 Christophe JAILLET
  2019-09-02 19:03 ` Sebastian Reichel
  0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2019-07-21 16:03 UTC (permalink / raw)
  To: sre; +Cc: linux-pm, linux-kernel, kernel-janitors, Christophe JAILLET

It is likely that 'max10742_[un]lock_model()' functions should be
'max17042_[un]lock_model()'
(0 and 7 switched in 10742)

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/power/supply/max17042_battery.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/power/supply/max17042_battery.c b/drivers/power/supply/max17042_battery.c
index 581c6bd23388..da3904822929 100644
--- a/drivers/power/supply/max17042_battery.c
+++ b/drivers/power/supply/max17042_battery.c
@@ -511,7 +511,7 @@ static inline void max17042_override_por(struct regmap *map,
 		regmap_write(map, reg, value);
 }
 
-static inline void max10742_unlock_model(struct max17042_chip *chip)
+static inline void max17042_unlock_model(struct max17042_chip *chip)
 {
 	struct regmap *map = chip->regmap;
 
@@ -519,7 +519,7 @@ static inline void max10742_unlock_model(struct max17042_chip *chip)
 	regmap_write(map, MAX17042_MLOCKReg2, MODEL_UNLOCK2);
 }
 
-static inline void max10742_lock_model(struct max17042_chip *chip)
+static inline void max17042_lock_model(struct max17042_chip *chip)
 {
 	struct regmap *map = chip->regmap;
 
@@ -577,7 +577,7 @@ static int max17042_init_model(struct max17042_chip *chip)
 	if (!temp_data)
 		return -ENOMEM;
 
-	max10742_unlock_model(chip);
+	max17042_unlock_model(chip);
 	max17042_write_model_data(chip, MAX17042_MODELChrTbl,
 				table_size);
 	max17042_read_model_data(chip, MAX17042_MODELChrTbl, temp_data,
@@ -589,7 +589,7 @@ static int max17042_init_model(struct max17042_chip *chip)
 		temp_data,
 		table_size);
 
-	max10742_lock_model(chip);
+	max17042_lock_model(chip);
 	kfree(temp_data);
 
 	return ret;
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] power: supply: max17042_battery: Fix a typo in function names
  2019-07-21 16:03 [PATCH] power: supply: max17042_battery: Fix a typo in function names Christophe JAILLET
@ 2019-09-02 19:03 ` Sebastian Reichel
  0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2019-09-02 19:03 UTC (permalink / raw)
  To: Christophe JAILLET; +Cc: linux-pm, linux-kernel, kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 1960 bytes --]

Hi,

On Sun, Jul 21, 2019 at 06:03:28PM +0200, Christophe JAILLET wrote:
> It is likely that 'max10742_[un]lock_model()' functions should be
> 'max17042_[un]lock_model()'
> (0 and 7 switched in 10742)
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/supply/max17042_battery.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/power/supply/max17042_battery.c b/drivers/power/supply/max17042_battery.c
> index 581c6bd23388..da3904822929 100644
> --- a/drivers/power/supply/max17042_battery.c
> +++ b/drivers/power/supply/max17042_battery.c
> @@ -511,7 +511,7 @@ static inline void max17042_override_por(struct regmap *map,
>  		regmap_write(map, reg, value);
>  }
>  
> -static inline void max10742_unlock_model(struct max17042_chip *chip)
> +static inline void max17042_unlock_model(struct max17042_chip *chip)
>  {
>  	struct regmap *map = chip->regmap;
>  
> @@ -519,7 +519,7 @@ static inline void max10742_unlock_model(struct max17042_chip *chip)
>  	regmap_write(map, MAX17042_MLOCKReg2, MODEL_UNLOCK2);
>  }
>  
> -static inline void max10742_lock_model(struct max17042_chip *chip)
> +static inline void max17042_lock_model(struct max17042_chip *chip)
>  {
>  	struct regmap *map = chip->regmap;
>  
> @@ -577,7 +577,7 @@ static int max17042_init_model(struct max17042_chip *chip)
>  	if (!temp_data)
>  		return -ENOMEM;
>  
> -	max10742_unlock_model(chip);
> +	max17042_unlock_model(chip);
>  	max17042_write_model_data(chip, MAX17042_MODELChrTbl,
>  				table_size);
>  	max17042_read_model_data(chip, MAX17042_MODELChrTbl, temp_data,
> @@ -589,7 +589,7 @@ static int max17042_init_model(struct max17042_chip *chip)
>  		temp_data,
>  		table_size);
>  
> -	max10742_lock_model(chip);
> +	max17042_lock_model(chip);
>  	kfree(temp_data);
>  
>  	return ret;
> -- 
> 2.20.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-09-02 19:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-21 16:03 [PATCH] power: supply: max17042_battery: Fix a typo in function names Christophe JAILLET
2019-09-02 19:03 ` Sebastian Reichel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).