From: shiva.linuxworks@gmail.com
To: Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Boris Brezillon <bbrezillon@kernel.org>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Frieder Schrempf <frieder.schrempf@kontron.de>,
Shivamurthy Shastri <sshivamurthy@micron.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
Jeff Kletsky <git-commits@allycomm.com>,
Chuanhong Guo <gch981213@gmail.com>,
liaoweixiong <liaoweixiong@allwinnertech.com>
Subject: [PATCH 7/8] mtd: spinand: micron: Fix read failure in Micron M70A flashes
Date: Mon, 22 Jul 2019 07:56:20 +0200 [thread overview]
Message-ID: <20190722055621.23526-8-sshivamurthy@micron.com> (raw)
In-Reply-To: <20190722055621.23526-1-sshivamurthy@micron.com>
From: Shivamurthy Shastri <sshivamurthy@micron.com>
M70A series flashes by default enable continuous read feature (BIT0 in
configuration register). This feature will not expose the ECC to host
and causing read failure.
Signed-off-by: Shivamurthy Shastri <sshivamurthy@micron.com>
---
drivers/mtd/nand/spi/micron.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/mtd/nand/spi/micron.c b/drivers/mtd/nand/spi/micron.c
index 6fde93ec23a1..1e28ea3d1362 100644
--- a/drivers/mtd/nand/spi/micron.c
+++ b/drivers/mtd/nand/spi/micron.c
@@ -127,6 +127,15 @@ static int micron_spinand_detect(struct spinand_device *spinand)
return 1;
}
+static int micron_spinand_init(struct spinand_device *spinand)
+{
+ /*
+ * Some of the Micron flashes enable this BIT by default,
+ * and there is a chance of read failure due to this.
+ */
+ return spinand_upd_cfg(spinand, CFG_QUAD_ENABLE, 0);
+}
+
static void micron_fixup_param_page(struct spinand_device *spinand,
struct nand_onfi_params *p)
{
@@ -150,6 +159,7 @@ static void micron_fixup_param_page(struct spinand_device *spinand,
static const struct spinand_manufacturer_ops micron_spinand_manuf_ops = {
.detect = micron_spinand_detect,
+ .init = micron_spinand_init,
.fixup_param_page = micron_fixup_param_page,
};
--
2.17.1
next prev parent reply other threads:[~2019-07-22 5:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 5:56 [PATCH 0/8] Introduce generic ONFI support shiva.linuxworks
2019-07-22 5:56 ` [PATCH 1/8] mtd: nand: move ONFI related functions to onfi.h shiva.linuxworks
2019-08-07 8:34 ` Miquel Raynal
2019-08-19 8:35 ` [EXT] " Shivamurthy Shastri (sshivamurthy)
2019-07-22 5:56 ` [PATCH 2/8] mtd: nand: move support functions for ONFI to nand/onfi.c shiva.linuxworks
2019-08-07 9:03 ` Miquel Raynal
2019-08-19 8:36 ` [EXT] " Shivamurthy Shastri (sshivamurthy)
2019-07-22 5:56 ` [PATCH 3/8] mtd: nand: create ONFI table parsing instance shiva.linuxworks
2019-08-07 9:09 ` Miquel Raynal
2019-07-22 5:56 ` [PATCH 4/8] mtd: spinand: enabled parameter page support shiva.linuxworks
2019-08-07 9:48 ` Miquel Raynal
2019-08-19 8:51 ` [EXT] " Shivamurthy Shastri (sshivamurthy)
2019-08-19 9:21 ` Miquel Raynal
2019-09-30 13:23 ` Shivamurthy Shastri (sshivamurthy)
2019-10-07 7:52 ` Boris Brezillon
2019-07-22 5:56 ` [PATCH 5/8] mtd: spinand: micron: prepare for generalizing driver shiva.linuxworks
2019-08-07 9:51 ` Miquel Raynal
2019-07-22 5:56 ` [PATCH 6/8] mtd: spinand: micron: Turn driver implementation generic shiva.linuxworks
2019-08-07 10:04 ` Miquel Raynal
2019-08-19 9:03 ` [EXT] " Shivamurthy Shastri (sshivamurthy)
2019-08-19 9:19 ` Miquel Raynal
2019-09-16 10:41 ` Shivamurthy Shastri (sshivamurthy)
2019-10-07 8:13 ` Boris Brezillon
2019-10-14 12:49 ` Shivamurthy Shastri (sshivamurthy)
2019-07-22 5:56 ` shiva.linuxworks [this message]
2019-08-07 10:05 ` [PATCH 7/8] mtd: spinand: micron: Fix read failure in Micron M70A flashes Miquel Raynal
2019-07-22 5:56 ` [PATCH 8/8] mtd: spinand: micron: Enable micron flashes with multi-die shiva.linuxworks
2019-08-07 10:08 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190722055621.23526-8-sshivamurthy@micron.com \
--to=shiva.linuxworks@gmail.com \
--cc=bbrezillon@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=frieder.schrempf@kontron.de \
--cc=gch981213@gmail.com \
--cc=git-commits@allycomm.com \
--cc=liaoweixiong@allwinnertech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marcel.ziswiler@toradex.com \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=sshivamurthy@micron.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).