linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	Colin King <colin.king@canonical.com>,
	linux-clk@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] clk: Si5341/Si5340: remove redundant assignment to n_den
Date: Mon, 22 Jul 2019 15:24:25 -0700	[thread overview]
Message-ID: <20190722222426.4980221985@mail.kernel.org> (raw)
In-Reply-To: <a92ca50d-b33e-8779-294c-301535d0f0d5@wanadoo.fr>

Quoting Christophe JAILLET (2019-07-22 15:00:24)
>
> I don't use it explicitly, but the suggestions I get include some git 
> history, so I guess that it is on by default.
> 
> I was thinking at parsing files to see if MODULE_AUTHOR includes an email.
> 

Ok. Feel free to write a patch. Just know that MODULE_AUTHOR isn't
always there so it's not a substitute for looking at git history or git
blame to figure out who wrote the code.

I suspect it's better to try to work on code and infrastructure to make
these sorts of patches and questions irrelevant by detecting these
problems before the code is merged, instead of after, by trawling the
mailing lists and trying to apply patches and test them for common
problems and then notifying the people working on the code. I don't have
unlimited time in my life, so getting patches like this just makes me
spend more time doing mundane tasks I don't want to do.

TL;DR: Please help automate this sort of stuff!


  parent reply	other threads:[~2019-07-22 22:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-01 16:50 [PATCH][next] clk: Si5341/Si5340: remove redundant assignment to n_den Colin King
2019-07-22 21:24 ` Stephen Boyd
2019-07-22 21:43   ` Christophe JAILLET
2019-07-22 21:43     ` Christophe JAILLET
2019-07-22 21:53     ` Stephen Boyd
2019-07-22 22:00       ` Christophe JAILLET
2019-07-22 22:00         ` Christophe JAILLET
2019-07-22 22:24         ` Stephen Boyd [this message]
2019-07-23 12:29   ` Mike Looijmans
2019-08-07 21:23 ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190722222426.4980221985@mail.kernel.org \
    --to=sboyd@kernel.org \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=colin.king@canonical.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).