From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Stephen Boyd <sboyd@kernel.org>,
Colin King <colin.king@canonical.com>,
linux-clk@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] clk: Si5341/Si5340: remove redundant assignment to n_den
Date: Tue, 23 Jul 2019 00:00:24 +0200 [thread overview]
Message-ID: <a92ca50d-b33e-8779-294c-301535d0f0d5@wanadoo.fr> (raw)
In-Reply-To: <20190722215314.9F4F121951@mail.kernel.org>
Le 22/07/2019 à 23:53, Stephen Boyd a écrit :
> Quoting Christophe JAILLET (2019-07-22 14:43:32)
>> Le 22/07/2019 à 23:24, Stephen Boyd a écrit :
>>> Please Cc authors of drivers so they can ack/review.
>>>
>>> Adding Mike to take a look.
>>>
>>> Quoting Colin King (2019-07-01 09:50:20)
>>>> From: Colin Ian King <colin.king@canonical.com>
>>>>
>>>> The variable n_den is initialized however that value is never read
>>>> as n_den is re-assigned a little later in the two paths of a
>>>> following if-statement. Remove the redundant assignment.
>>>>
>>>> Addresses-Coverity: ("Unused value")
>>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>>> ---
>>>> drivers/clk/clk-si5341.c | 1 -
>>>> 1 file changed, 1 deletion(-)
>>>>
>>>> diff --git a/drivers/clk/clk-si5341.c b/drivers/clk/clk-si5341.c
>>>> index 72424eb7e5f8..6e780c2a9e6b 100644
>>>> --- a/drivers/clk/clk-si5341.c
>>>> +++ b/drivers/clk/clk-si5341.c
>>>> @@ -547,7 +547,6 @@ static int si5341_synth_clk_set_rate(struct clk_hw *hw, unsigned long rate,
>>>> bool is_integer;
>>>>
>>>> n_num = synth->data->freq_vco;
>>>> - n_den = rate;
>>>>
>>>> /* see if there's an integer solution */
>>>> r = do_div(n_num, rate);
>> Hi,
>>
>> I got the same advise from some else no later than yesterday (i.e. email
>> the author...)
>> Maybe 'get_maintainer.pl' could be improved to search for it and propose
>> the mail automatically?
>>
>> just my 2c.
>>
> Use --git option of get_maintainer.pl?
>
>
I don't use it explicitly, but the suggestions I get include some git
history, so I guess that it is on by default.
I was thinking at parsing files to see if MODULE_AUTHOR includes an email.
CJ
WARNING: multiple messages have this Message-ID (diff)
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: linux-kernel@vger.kernel.org
Cc: linux-clk@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH][next] clk: Si5341/Si5340: remove redundant assignment to n_den
Date: Tue, 23 Jul 2019 00:00:24 +0200 [thread overview]
Message-ID: <a92ca50d-b33e-8779-294c-301535d0f0d5@wanadoo.fr> (raw)
Message-ID: <20190722220024.7Fb8B1VMHGMqGFSgX1iGnowV3z037SNZ73H4ZTTRTsY@z> (raw)
In-Reply-To: <20190722215314.9F4F121951@mail.kernel.org>
Le 22/07/2019 à 23:53, Stephen Boyd a écrit :
> Quoting Christophe JAILLET (2019-07-22 14:43:32)
>> Le 22/07/2019 à 23:24, Stephen Boyd a écrit :
>>> Please Cc authors of drivers so they can ack/review.
>>>
>>> Adding Mike to take a look.
>>>
>>> Quoting Colin King (2019-07-01 09:50:20)
>>>> From: Colin Ian King <colin.king@canonical.com>
>>>>
>>>> The variable n_den is initialized however that value is never read
>>>> as n_den is re-assigned a little later in the two paths of a
>>>> following if-statement. Remove the redundant assignment.
>>>>
>>>> Addresses-Coverity: ("Unused value")
>>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>>> ---
>>>> drivers/clk/clk-si5341.c | 1 -
>>>> 1 file changed, 1 deletion(-)
>>>>
>>>> diff --git a/drivers/clk/clk-si5341.c b/drivers/clk/clk-si5341.c
>>>> index 72424eb7e5f8..6e780c2a9e6b 100644
>>>> --- a/drivers/clk/clk-si5341.c
>>>> +++ b/drivers/clk/clk-si5341.c
>>>> @@ -547,7 +547,6 @@ static int si5341_synth_clk_set_rate(struct clk_hw *hw, unsigned long rate,
>>>> bool is_integer;
>>>>
>>>> n_num = synth->data->freq_vco;
>>>> - n_den = rate;
>>>>
>>>> /* see if there's an integer solution */
>>>> r = do_div(n_num, rate);
>> Hi,
>>
>> I got the same advise from some else no later than yesterday (i.e. email
>> the author...)
>> Maybe 'get_maintainer.pl' could be improved to search for it and propose
>> the mail automatically?
>>
>> just my 2c.
>>
> Use --git option of get_maintainer.pl?
>
>
I don't use it explicitly, but the suggestions I get include some git
history, so I guess that it is on by default.
I was thinking at parsing files to see if MODULE_AUTHOR includes an email.
CJ
next prev parent reply other threads:[~2019-07-22 22:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 16:50 [PATCH][next] clk: Si5341/Si5340: remove redundant assignment to n_den Colin King
2019-07-22 21:24 ` Stephen Boyd
2019-07-22 21:43 ` Christophe JAILLET
2019-07-22 21:43 ` Christophe JAILLET
2019-07-22 21:53 ` Stephen Boyd
2019-07-22 22:00 ` Christophe JAILLET [this message]
2019-07-22 22:00 ` Christophe JAILLET
2019-07-22 22:24 ` Stephen Boyd
2019-07-23 12:29 ` Mike Looijmans
2019-08-07 21:23 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a92ca50d-b33e-8779-294c-301535d0f0d5@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).