* [PATCH] mm/hotplug: remove unneeded return for void function
@ 2019-07-23 13:08 Weitao Hou
2019-07-23 13:13 ` David Hildenbrand
2019-07-23 13:14 ` Oscar Salvador
0 siblings, 2 replies; 3+ messages in thread
From: Weitao Hou @ 2019-07-23 13:08 UTC (permalink / raw)
To: akpm, osalvador, mhocko, david, pasha.tatashin, dan.j.williams
Cc: linux-mm, linux-kernel, Weitao Hou
return is unneeded in void function
Signed-off-by: Weitao Hou <houweitaoo@gmail.com>
---
mm/memory_hotplug.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 2a9bbddb0e55..c73f09913165 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -132,7 +132,6 @@ static void release_memory_resource(struct resource *res)
return;
release_resource(res);
kfree(res);
- return;
}
#ifdef CONFIG_MEMORY_HOTPLUG_SPARSE
@@ -979,7 +978,6 @@ static void rollback_node_hotadd(int nid)
arch_refresh_nodedata(nid, NULL);
free_percpu(pgdat->per_cpu_nodestats);
arch_free_nodedata(pgdat);
- return;
}
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mm/hotplug: remove unneeded return for void function
2019-07-23 13:08 [PATCH] mm/hotplug: remove unneeded return for void function Weitao Hou
@ 2019-07-23 13:13 ` David Hildenbrand
2019-07-23 13:14 ` Oscar Salvador
1 sibling, 0 replies; 3+ messages in thread
From: David Hildenbrand @ 2019-07-23 13:13 UTC (permalink / raw)
To: Weitao Hou, akpm, osalvador, mhocko, pasha.tatashin, dan.j.williams
Cc: linux-mm, linux-kernel
On 23.07.19 15:08, Weitao Hou wrote:
> return is unneeded in void function
>
> Signed-off-by: Weitao Hou <houweitaoo@gmail.com>
> ---
> mm/memory_hotplug.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 2a9bbddb0e55..c73f09913165 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -132,7 +132,6 @@ static void release_memory_resource(struct resource *res)
> return;
> release_resource(res);
> kfree(res);
> - return;
> }
>
> #ifdef CONFIG_MEMORY_HOTPLUG_SPARSE
> @@ -979,7 +978,6 @@ static void rollback_node_hotadd(int nid)
> arch_refresh_nodedata(nid, NULL);
> free_percpu(pgdat->per_cpu_nodestats);
> arch_free_nodedata(pgdat);
> - return;
> }
>
>
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm/hotplug: remove unneeded return for void function
2019-07-23 13:08 [PATCH] mm/hotplug: remove unneeded return for void function Weitao Hou
2019-07-23 13:13 ` David Hildenbrand
@ 2019-07-23 13:14 ` Oscar Salvador
1 sibling, 0 replies; 3+ messages in thread
From: Oscar Salvador @ 2019-07-23 13:14 UTC (permalink / raw)
To: Weitao Hou
Cc: akpm, mhocko, david, pasha.tatashin, dan.j.williams, linux-mm,
linux-kernel
On Tue, Jul 23, 2019 at 09:08:14PM +0800, Weitao Hou wrote:
> return is unneeded in void function
>
> Signed-off-by: Weitao Hou <houweitaoo@gmail.com>
Reviewed-by: Oscar Salvador <osalvador@suse.de>
> ---
> mm/memory_hotplug.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 2a9bbddb0e55..c73f09913165 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -132,7 +132,6 @@ static void release_memory_resource(struct resource *res)
> return;
> release_resource(res);
> kfree(res);
> - return;
> }
>
> #ifdef CONFIG_MEMORY_HOTPLUG_SPARSE
> @@ -979,7 +978,6 @@ static void rollback_node_hotadd(int nid)
> arch_refresh_nodedata(nid, NULL);
> free_percpu(pgdat->per_cpu_nodestats);
> arch_free_nodedata(pgdat);
> - return;
> }
>
>
> --
> 2.18.0
>
--
Oscar Salvador
SUSE L3
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-23 13:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-23 13:08 [PATCH] mm/hotplug: remove unneeded return for void function Weitao Hou
2019-07-23 13:13 ` David Hildenbrand
2019-07-23 13:14 ` Oscar Salvador
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).