* [PATCH] perf/x86/intel: Fix SLOTS pebs event constraint
@ 2019-07-23 20:04 kan.liang
2019-07-25 7:54 ` Peter Zijlstra
2019-07-25 16:05 ` [tip:perf/urgent] perf/x86/intel: Fix SLOTS PEBS " tip-bot for Kan Liang
0 siblings, 2 replies; 3+ messages in thread
From: kan.liang @ 2019-07-23 20:04 UTC (permalink / raw)
To: peterz, mingo, linux-kernel; +Cc: ak, Kan Liang, stable
From: Kan Liang <kan.liang@linux.intel.com>
Sampling SLOTS event and ref-cycles event in a group on Icelake gives
EINVAL.
SLOTS event is the event stands for the fixed counter 3, not fixed
counter 2. Wrong mask was set to SLOTS event in
intel_icl_pebs_event_constraints[].
Fixes: 6017608936c1 ("perf/x86/intel: Add Icelake support")
Reported-by: Andi Kleen <ak@linux.intel.com>
Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
Cc: stable@vger.kernel.org
---
arch/x86/events/intel/ds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/events/intel/ds.c b/arch/x86/events/intel/ds.c
index 505c73dc6a73..6601b8759c92 100644
--- a/arch/x86/events/intel/ds.c
+++ b/arch/x86/events/intel/ds.c
@@ -851,7 +851,7 @@ struct event_constraint intel_skl_pebs_event_constraints[] = {
struct event_constraint intel_icl_pebs_event_constraints[] = {
INTEL_FLAGS_UEVENT_CONSTRAINT(0x1c0, 0x100000000ULL), /* INST_RETIRED.PREC_DIST */
- INTEL_FLAGS_UEVENT_CONSTRAINT(0x0400, 0x400000000ULL), /* SLOTS */
+ INTEL_FLAGS_UEVENT_CONSTRAINT(0x0400, 0x800000000ULL), /* SLOTS */
INTEL_PLD_CONSTRAINT(0x1cd, 0xff), /* MEM_TRANS_RETIRED.LOAD_LATENCY */
INTEL_FLAGS_UEVENT_CONSTRAINT_DATALA_LD(0x1d0, 0xf), /* MEM_INST_RETIRED.LOAD */
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] perf/x86/intel: Fix SLOTS pebs event constraint
2019-07-23 20:04 [PATCH] perf/x86/intel: Fix SLOTS pebs event constraint kan.liang
@ 2019-07-25 7:54 ` Peter Zijlstra
2019-07-25 16:05 ` [tip:perf/urgent] perf/x86/intel: Fix SLOTS PEBS " tip-bot for Kan Liang
1 sibling, 0 replies; 3+ messages in thread
From: Peter Zijlstra @ 2019-07-25 7:54 UTC (permalink / raw)
To: kan.liang; +Cc: mingo, linux-kernel, ak, stable
On Tue, Jul 23, 2019 at 01:04:29PM -0700, kan.liang@linux.intel.com wrote:
> From: Kan Liang <kan.liang@linux.intel.com>
>
> Sampling SLOTS event and ref-cycles event in a group on Icelake gives
> EINVAL.
>
> SLOTS event is the event stands for the fixed counter 3, not fixed
> counter 2. Wrong mask was set to SLOTS event in
> intel_icl_pebs_event_constraints[].
>
> Fixes: 6017608936c1 ("perf/x86/intel: Add Icelake support")
> Reported-by: Andi Kleen <ak@linux.intel.com>
> Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:perf/urgent] perf/x86/intel: Fix SLOTS PEBS event constraint
2019-07-23 20:04 [PATCH] perf/x86/intel: Fix SLOTS pebs event constraint kan.liang
2019-07-25 7:54 ` Peter Zijlstra
@ 2019-07-25 16:05 ` tip-bot for Kan Liang
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Kan Liang @ 2019-07-25 16:05 UTC (permalink / raw)
To: linux-tip-commits
Cc: ak, torvalds, kan.liang, hpa, peterz, mingo, linux-kernel, tglx
Commit-ID: 3d0c3953601d250175c7684ec0d9df612061dae5
Gitweb: https://git.kernel.org/tip/3d0c3953601d250175c7684ec0d9df612061dae5
Author: Kan Liang <kan.liang@linux.intel.com>
AuthorDate: Tue, 23 Jul 2019 13:04:29 -0700
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 25 Jul 2019 15:41:29 +0200
perf/x86/intel: Fix SLOTS PEBS event constraint
Sampling SLOTS event and ref-cycles event in a group on Icelake gives
EINVAL.
SLOTS event is the event stands for the fixed counter 3, not fixed
counter 2. Wrong mask was set to SLOTS event in
intel_icl_pebs_event_constraints[].
Reported-by: Andi Kleen <ak@linux.intel.com>
Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: 6017608936c1 ("perf/x86/intel: Add Icelake support")
Link: https://lkml.kernel.org/r/20190723200429.8180-1-kan.liang@linux.intel.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/events/intel/ds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/events/intel/ds.c b/arch/x86/events/intel/ds.c
index 2c8db2c19328..f1269e804e9b 100644
--- a/arch/x86/events/intel/ds.c
+++ b/arch/x86/events/intel/ds.c
@@ -851,7 +851,7 @@ struct event_constraint intel_skl_pebs_event_constraints[] = {
struct event_constraint intel_icl_pebs_event_constraints[] = {
INTEL_FLAGS_UEVENT_CONSTRAINT(0x1c0, 0x100000000ULL), /* INST_RETIRED.PREC_DIST */
- INTEL_FLAGS_UEVENT_CONSTRAINT(0x0400, 0x400000000ULL), /* SLOTS */
+ INTEL_FLAGS_UEVENT_CONSTRAINT(0x0400, 0x800000000ULL), /* SLOTS */
INTEL_PLD_CONSTRAINT(0x1cd, 0xff), /* MEM_TRANS_RETIRED.LOAD_LATENCY */
INTEL_FLAGS_UEVENT_CONSTRAINT_DATALA_LD(0x1d0, 0xf), /* MEM_INST_RETIRED.LOAD */
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-25 16:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-23 20:04 [PATCH] perf/x86/intel: Fix SLOTS pebs event constraint kan.liang
2019-07-25 7:54 ` Peter Zijlstra
2019-07-25 16:05 ` [tip:perf/urgent] perf/x86/intel: Fix SLOTS PEBS " tip-bot for Kan Liang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).