* [PATCH -next] drm/mga: remove set but not used variable 'buf_priv'
@ 2019-07-24 1:46 YueHaibing
2019-07-24 7:40 ` Thomas Zimmermann
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-07-24 1:46 UTC (permalink / raw)
To: David Airlie, Daniel Vetter, Thomas Zimmermann, Sam Ravnborg
Cc: YueHaibing, dri-devel, linux-kernel, kernel-janitors, Hulk Robot
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/mga/mga_state.c: In function 'mga_dma_iload':
drivers/gpu/drm/mga/mga_state.c:945:22: warning:
variable 'buf_priv' set but not used [-Wunused-but-set-variable]
It is never used, so can be removed.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/mga/mga_state.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/mga/mga_state.c b/drivers/gpu/drm/mga/mga_state.c
index 77a0b006f066..0dec4062e5a2 100644
--- a/drivers/gpu/drm/mga/mga_state.c
+++ b/drivers/gpu/drm/mga/mga_state.c
@@ -942,7 +942,6 @@ static int mga_dma_iload(struct drm_device *dev, void *data, struct drm_file *fi
struct drm_device_dma *dma = dev->dma;
drm_mga_private_t *dev_priv = dev->dev_private;
struct drm_buf *buf;
- drm_mga_buf_priv_t *buf_priv;
drm_mga_iload_t *iload = data;
DRM_DEBUG("\n");
@@ -959,7 +958,6 @@ static int mga_dma_iload(struct drm_device *dev, void *data, struct drm_file *fi
return -EINVAL;
buf = dma->buflist[iload->idx];
- buf_priv = buf->dev_private;
if (mga_verify_iload(dev_priv, iload->dstorg, iload->length)) {
mga_freelist_put(dev, buf);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] drm/mga: remove set but not used variable 'buf_priv'
2019-07-24 1:46 [PATCH -next] drm/mga: remove set but not used variable 'buf_priv' YueHaibing
@ 2019-07-24 7:40 ` Thomas Zimmermann
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Zimmermann @ 2019-07-24 7:40 UTC (permalink / raw)
To: YueHaibing, David Airlie, Daniel Vetter, Sam Ravnborg
Cc: kernel-janitors, linux-kernel, dri-devel, Hulk Robot
[-- Attachment #1.1: Type: text/plain, Size: 1807 bytes --]
Am 24.07.19 um 03:46 schrieb YueHaibing:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/mga/mga_state.c: In function 'mga_dma_iload':
> drivers/gpu/drm/mga/mga_state.c:945:22: warning:
> variable 'buf_priv' set but not used [-Wunused-but-set-variable]
>
> It is never used, so can be removed.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/gpu/drm/mga/mga_state.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/mga/mga_state.c b/drivers/gpu/drm/mga/mga_state.c
> index 77a0b006f066..0dec4062e5a2 100644
> --- a/drivers/gpu/drm/mga/mga_state.c
> +++ b/drivers/gpu/drm/mga/mga_state.c
> @@ -942,7 +942,6 @@ static int mga_dma_iload(struct drm_device *dev, void *data, struct drm_file *fi
> struct drm_device_dma *dma = dev->dma;
> drm_mga_private_t *dev_priv = dev->dev_private;
> struct drm_buf *buf;
> - drm_mga_buf_priv_t *buf_priv;
> drm_mga_iload_t *iload = data;
> DRM_DEBUG("\n");
>
> @@ -959,7 +958,6 @@ static int mga_dma_iload(struct drm_device *dev, void *data, struct drm_file *fi
> return -EINVAL;
>
> buf = dma->buflist[iload->idx];
> - buf_priv = buf->dev_private;
>
> if (mga_verify_iload(dev_priv, iload->dstorg, iload->length)) {
> mga_freelist_put(dev, buf);
>
Thanks!
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-24 7:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-24 1:46 [PATCH -next] drm/mga: remove set but not used variable 'buf_priv' YueHaibing
2019-07-24 7:40 ` Thomas Zimmermann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).