* [PATCH] Input: elantech - mark expected switch fall-through
@ 2019-07-24 17:52 Gustavo A. R. Silva
2019-07-24 19:25 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2019-07-24 17:52 UTC (permalink / raw)
To: Dmitry Torokhov, Kai-Heng Feng
Cc: linux-input, linux-kernel, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/input/mouse/elantech.c: In function 'elantech_use_host_notify':
drivers/input/mouse/elantech.c:1843:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (dmi_get_bios_year() >= 2018)
^
drivers/input/mouse/elantech.c:1845:2: note: here
default:
^~~~~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.
Notice that -Wimplicit-fallthrough will be globally
enabled in v5.3.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/input/mouse/elantech.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
index 73544776a9ed..04fe43440a3c 100644
--- a/drivers/input/mouse/elantech.c
+++ b/drivers/input/mouse/elantech.c
@@ -1842,6 +1842,7 @@ static bool elantech_use_host_notify(struct psmouse *psmouse,
/* SMbus implementation is stable since 2018 */
if (dmi_get_bios_year() >= 2018)
return true;
+ /* fall through */
default:
psmouse_dbg(psmouse,
"Ignoring SMBus bus provider %d\n", info->bus);
--
2.22.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: elantech - mark expected switch fall-through
2019-07-24 17:52 [PATCH] Input: elantech - mark expected switch fall-through Gustavo A. R. Silva
@ 2019-07-24 19:25 ` Dmitry Torokhov
2019-07-24 19:29 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Torokhov @ 2019-07-24 19:25 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: Kai-Heng Feng, linux-input, linux-kernel
Hi Gustavo,
On Wed, Jul 24, 2019 at 12:52:02PM -0500, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/input/mouse/elantech.c: In function 'elantech_use_host_notify':
> drivers/input/mouse/elantech.c:1843:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (dmi_get_bios_year() >= 2018)
> ^
> drivers/input/mouse/elantech.c:1845:2: note: here
> default:
> ^~~~~~~
Thank you for the patch but I already pushed out similar patch.
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: elantech - mark expected switch fall-through
2019-07-24 19:25 ` Dmitry Torokhov
@ 2019-07-24 19:29 ` Gustavo A. R. Silva
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2019-07-24 19:29 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Kai-Heng Feng, linux-input, linux-kernel
>
> Thank you for the patch but I already pushed out similar patch.
>
Great. Good to know it's already fixed. :)
Thanks
--
Gustavo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-24 20:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-24 17:52 [PATCH] Input: elantech - mark expected switch fall-through Gustavo A. R. Silva
2019-07-24 19:25 ` Dmitry Torokhov
2019-07-24 19:29 ` Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).