* [PATCH] ptp: ptp_dte: remove redundant dev_err message
@ 2019-07-23 8:54 Ding Xiang
2019-07-25 18:38 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Ding Xiang @ 2019-07-23 8:54 UTC (permalink / raw)
To: richardcochran; +Cc: netdev, linux-kernel
devm_ioremap_resource already contains error message, so remove
the redundant dev_err message
Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
---
drivers/ptp/ptp_dte.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/ptp/ptp_dte.c b/drivers/ptp/ptp_dte.c
index 5b6393e..0dcfdc8 100644
--- a/drivers/ptp/ptp_dte.c
+++ b/drivers/ptp/ptp_dte.c
@@ -248,11 +248,8 @@ static int ptp_dte_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
ptp_dte->regs = devm_ioremap_resource(dev, res);
- if (IS_ERR(ptp_dte->regs)) {
- dev_err(dev,
- "%s: io remap failed\n", __func__);
+ if (IS_ERR(ptp_dte->regs))
return PTR_ERR(ptp_dte->regs);
- }
spin_lock_init(&ptp_dte->lock);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ptp: ptp_dte: remove redundant dev_err message
2019-07-23 8:54 [PATCH] ptp: ptp_dte: remove redundant dev_err message Ding Xiang
@ 2019-07-25 18:38 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-07-25 18:38 UTC (permalink / raw)
To: dingxiang; +Cc: richardcochran, netdev, linux-kernel
From: Ding Xiang <dingxiang@cmss.chinamobile.com>
Date: Tue, 23 Jul 2019 16:54:05 +0800
> devm_ioremap_resource already contains error message, so remove
> the redundant dev_err message
>
> Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
Applied to net-next.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-25 18:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-23 8:54 [PATCH] ptp: ptp_dte: remove redundant dev_err message Ding Xiang
2019-07-25 18:38 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).