* [PATCH] fsl/fman: Remove comment referring to non-existent function
@ 2019-07-23 23:35 Chris Packham
2019-07-25 18:53 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Chris Packham @ 2019-07-23 23:35 UTC (permalink / raw)
To: madalin.bucur, davem; +Cc: netdev, linux-kernel, Chris Packham
fm_set_max_frm() existed in the Freescale SDK as a callback for an
early_param. When this code was ported to the upstream kernel the
early_param was converted to a module_param making the reference to the
function incorrect. The rest of the comment already does a good job of
explaining the parameter so removing the reference to the non-existent
function seems like the best thing to do.
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
drivers/net/ethernet/freescale/fman/fman.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fman/fman.c b/drivers/net/ethernet/freescale/fman/fman.c
index e80fedb27cee..210749bf1eac 100644
--- a/drivers/net/ethernet/freescale/fman/fman.c
+++ b/drivers/net/ethernet/freescale/fman/fman.c
@@ -2439,9 +2439,6 @@ MODULE_PARM_DESC(fsl_fm_rx_extra_headroom, "Extra headroom for Rx buffers");
* buffers when not using jumbo frames.
* Must be large enough to accommodate the network MTU, but small enough
* to avoid wasting skb memory.
- *
- * Could be overridden once, at boot-time, via the
- * fm_set_max_frm() callback.
*/
static int fsl_fm_max_frm = FSL_FM_MAX_FRAME_SIZE;
module_param(fsl_fm_max_frm, int, 0);
--
2.22.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fsl/fman: Remove comment referring to non-existent function
2019-07-23 23:35 [PATCH] fsl/fman: Remove comment referring to non-existent function Chris Packham
@ 2019-07-25 18:53 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-07-25 18:53 UTC (permalink / raw)
To: chris.packham; +Cc: madalin.bucur, netdev, linux-kernel
From: Chris Packham <chris.packham@alliedtelesis.co.nz>
Date: Wed, 24 Jul 2019 11:35:01 +1200
> fm_set_max_frm() existed in the Freescale SDK as a callback for an
> early_param. When this code was ported to the upstream kernel the
> early_param was converted to a module_param making the reference to the
> function incorrect. The rest of the comment already does a good job of
> explaining the parameter so removing the reference to the non-existent
> function seems like the best thing to do.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-25 18:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-23 23:35 [PATCH] fsl/fman: Remove comment referring to non-existent function Chris Packham
2019-07-25 18:53 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).