* [PATCH] ARM: signal: Mark expected switch fall-through
@ 2019-07-29 0:13 Gustavo A. R. Silva
2019-07-29 16:36 ` Kees Cook
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2019-07-29 0:13 UTC (permalink / raw)
To: Russell King
Cc: linux-arm-kernel, linux-kernel, Gustavo A. R. Silva,
Stephen Rothwell, Kees Cook
Mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
arch/arm/kernel/signal.c: In function 'do_signal':
arch/arm/kernel/signal.c:598:12: warning: this statement may fall through [-Wimplicit-fallthrough=]
restart -= 2;
~~~~~~~~^~~~
arch/arm/kernel/signal.c:599:3: note: here
case -ERESTARTNOHAND:
^~~~
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
arch/arm/kernel/signal.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/kernel/signal.c b/arch/arm/kernel/signal.c
index 09f6fdd41974..ab2568996ddb 100644
--- a/arch/arm/kernel/signal.c
+++ b/arch/arm/kernel/signal.c
@@ -596,6 +596,7 @@ static int do_signal(struct pt_regs *regs, int syscall)
switch (retval) {
case -ERESTART_RESTARTBLOCK:
restart -= 2;
+ /* Fall through */
case -ERESTARTNOHAND:
case -ERESTARTSYS:
case -ERESTARTNOINTR:
--
2.22.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: signal: Mark expected switch fall-through
2019-07-29 0:13 [PATCH] ARM: signal: Mark expected switch fall-through Gustavo A. R. Silva
@ 2019-07-29 16:36 ` Kees Cook
0 siblings, 0 replies; 2+ messages in thread
From: Kees Cook @ 2019-07-29 16:36 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Russell King, linux-arm-kernel, linux-kernel, Stephen Rothwell
On Sun, Jul 28, 2019 at 07:13:14PM -0500, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> arch/arm/kernel/signal.c: In function 'do_signal':
> arch/arm/kernel/signal.c:598:12: warning: this statement may fall through [-Wimplicit-fallthrough=]
> restart -= 2;
> ~~~~~~~~^~~~
> arch/arm/kernel/signal.c:599:3: note: here
> case -ERESTARTNOHAND:
> ^~~~
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
> ---
> arch/arm/kernel/signal.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/kernel/signal.c b/arch/arm/kernel/signal.c
> index 09f6fdd41974..ab2568996ddb 100644
> --- a/arch/arm/kernel/signal.c
> +++ b/arch/arm/kernel/signal.c
> @@ -596,6 +596,7 @@ static int do_signal(struct pt_regs *regs, int syscall)
> switch (retval) {
> case -ERESTART_RESTARTBLOCK:
> restart -= 2;
> + /* Fall through */
> case -ERESTARTNOHAND:
> case -ERESTARTSYS:
> case -ERESTARTNOINTR:
> --
> 2.22.0
>
--
Kees Cook
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-29 16:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-29 0:13 [PATCH] ARM: signal: Mark expected switch fall-through Gustavo A. R. Silva
2019-07-29 16:36 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).