* [PATCH] arcnet: com20020-isa: Mark expected switch fall-throughs
@ 2019-07-29 14:25 Gustavo A. R. Silva
2019-07-29 16:01 ` Kees Cook
2019-07-29 17:24 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2019-07-29 14:25 UTC (permalink / raw)
To: Michael Grzeschik, David S. Miller
Cc: netdev, linux-kernel, Gustavo A. R. Silva, Geert Uytterhoeven, Kees Cook
Mark switch cases where we are expecting to fall through.
This patch fixes the following warnings:
drivers/net/arcnet/com20020-isa.c: warning: this statement may fall
through [-Wimplicit-fallthrough=]: => 205:13, 203:10, 209:7, 201:11,
207:8
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/net/arcnet/com20020-isa.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/arcnet/com20020-isa.c b/drivers/net/arcnet/com20020-isa.c
index 28510e33924f..cd27fdc1059b 100644
--- a/drivers/net/arcnet/com20020-isa.c
+++ b/drivers/net/arcnet/com20020-isa.c
@@ -197,16 +197,22 @@ static int __init com20020isa_setup(char *s)
switch (ints[0]) {
default: /* ERROR */
pr_info("Too many arguments\n");
+ /* Fall through */
case 6: /* Timeout */
timeout = ints[6];
+ /* Fall through */
case 5: /* CKP value */
clockp = ints[5];
+ /* Fall through */
case 4: /* Backplane flag */
backplane = ints[4];
+ /* Fall through */
case 3: /* Node ID */
node = ints[3];
+ /* Fall through */
case 2: /* IRQ */
irq = ints[2];
+ /* Fall through */
case 1: /* IO address */
io = ints[1];
}
--
2.22.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arcnet: com20020-isa: Mark expected switch fall-throughs
2019-07-29 14:25 [PATCH] arcnet: com20020-isa: Mark expected switch fall-throughs Gustavo A. R. Silva
@ 2019-07-29 16:01 ` Kees Cook
2019-07-29 17:24 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Kees Cook @ 2019-07-29 16:01 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Michael Grzeschik, David S. Miller, netdev, linux-kernel,
Geert Uytterhoeven
On Mon, Jul 29, 2019 at 09:25:03AM -0500, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warnings:
>
> drivers/net/arcnet/com20020-isa.c: warning: this statement may fall
> through [-Wimplicit-fallthrough=]: => 205:13, 203:10, 209:7, 201:11,
> 207:8
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
> ---
> drivers/net/arcnet/com20020-isa.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/arcnet/com20020-isa.c b/drivers/net/arcnet/com20020-isa.c
> index 28510e33924f..cd27fdc1059b 100644
> --- a/drivers/net/arcnet/com20020-isa.c
> +++ b/drivers/net/arcnet/com20020-isa.c
> @@ -197,16 +197,22 @@ static int __init com20020isa_setup(char *s)
> switch (ints[0]) {
> default: /* ERROR */
> pr_info("Too many arguments\n");
> + /* Fall through */
> case 6: /* Timeout */
> timeout = ints[6];
> + /* Fall through */
> case 5: /* CKP value */
> clockp = ints[5];
> + /* Fall through */
> case 4: /* Backplane flag */
> backplane = ints[4];
> + /* Fall through */
> case 3: /* Node ID */
> node = ints[3];
> + /* Fall through */
> case 2: /* IRQ */
> irq = ints[2];
> + /* Fall through */
> case 1: /* IO address */
> io = ints[1];
> }
> --
> 2.22.0
>
--
Kees Cook
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arcnet: com20020-isa: Mark expected switch fall-throughs
2019-07-29 14:25 [PATCH] arcnet: com20020-isa: Mark expected switch fall-throughs Gustavo A. R. Silva
2019-07-29 16:01 ` Kees Cook
@ 2019-07-29 17:24 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-07-29 17:24 UTC (permalink / raw)
To: gustavo; +Cc: m.grzeschik, netdev, linux-kernel, geert, keescook
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Date: Mon, 29 Jul 2019 09:25:03 -0500
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warnings:
>
> drivers/net/arcnet/com20020-isa.c: warning: this statement may fall
> through [-Wimplicit-fallthrough=]: => 205:13, 203:10, 209:7, 201:11,
> 207:8
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-29 17:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-29 14:25 [PATCH] arcnet: com20020-isa: Mark expected switch fall-throughs Gustavo A. R. Silva
2019-07-29 16:01 ` Kees Cook
2019-07-29 17:24 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).