* [PATCH] watchdog: scx200_wdt: Mark expected switch fall-through
@ 2019-07-29 20:06 Gustavo A. R. Silva
2019-07-29 20:20 ` Guenter Roeck
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2019-07-29 20:06 UTC (permalink / raw)
To: Jim Cromie, Wim Van Sebroeck, Guenter Roeck
Cc: linux-watchdog, linux-kernel, Gustavo A. R. Silva, Kees Cook
Mark switch cases where we are expecting to fall through.
This patch fixes the following warning (Building: i386):
drivers/watchdog/scx200_wdt.c: In function ‘scx200_wdt_ioctl’:
drivers/watchdog/scx200_wdt.c:188:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
scx200_wdt_ping();
^~~~~~~~~~~~~~~~~
drivers/watchdog/scx200_wdt.c:189:2: note: here
case WDIOC_GETTIMEOUT:
^~~~
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/watchdog/scx200_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/scx200_wdt.c b/drivers/watchdog/scx200_wdt.c
index efd7996694de..46268309ee9b 100644
--- a/drivers/watchdog/scx200_wdt.c
+++ b/drivers/watchdog/scx200_wdt.c
@@ -186,6 +186,7 @@ static long scx200_wdt_ioctl(struct file *file, unsigned int cmd,
margin = new_margin;
scx200_wdt_update_margin();
scx200_wdt_ping();
+ /* Fall through */
case WDIOC_GETTIMEOUT:
if (put_user(margin, p))
return -EFAULT;
--
2.22.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] watchdog: scx200_wdt: Mark expected switch fall-through
2019-07-29 20:06 [PATCH] watchdog: scx200_wdt: Mark expected switch fall-through Gustavo A. R. Silva
@ 2019-07-29 20:20 ` Guenter Roeck
2019-07-29 21:47 ` Kees Cook
2019-07-30 17:08 ` Guenter Roeck
2 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2019-07-29 20:20 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Jim Cromie, Wim Van Sebroeck, linux-watchdog, linux-kernel, Kees Cook
On Mon, Jul 29, 2019 at 03:06:02PM -0500, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warning (Building: i386):
>
> drivers/watchdog/scx200_wdt.c: In function ‘scx200_wdt_ioctl’:
> drivers/watchdog/scx200_wdt.c:188:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> scx200_wdt_ping();
> ^~~~~~~~~~~~~~~~~
> drivers/watchdog/scx200_wdt.c:189:2: note: here
> case WDIOC_GETTIMEOUT:
> ^~~~
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/scx200_wdt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/scx200_wdt.c b/drivers/watchdog/scx200_wdt.c
> index efd7996694de..46268309ee9b 100644
> --- a/drivers/watchdog/scx200_wdt.c
> +++ b/drivers/watchdog/scx200_wdt.c
> @@ -186,6 +186,7 @@ static long scx200_wdt_ioctl(struct file *file, unsigned int cmd,
> margin = new_margin;
> scx200_wdt_update_margin();
> scx200_wdt_ping();
> + /* Fall through */
> case WDIOC_GETTIMEOUT:
> if (put_user(margin, p))
> return -EFAULT;
> --
> 2.22.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] watchdog: scx200_wdt: Mark expected switch fall-through
2019-07-29 20:06 [PATCH] watchdog: scx200_wdt: Mark expected switch fall-through Gustavo A. R. Silva
2019-07-29 20:20 ` Guenter Roeck
@ 2019-07-29 21:47 ` Kees Cook
2019-07-30 17:08 ` Guenter Roeck
2 siblings, 0 replies; 4+ messages in thread
From: Kees Cook @ 2019-07-29 21:47 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Jim Cromie, Wim Van Sebroeck, Guenter Roeck, linux-watchdog,
linux-kernel
On Mon, Jul 29, 2019 at 03:06:02PM -0500, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warning (Building: i386):
>
> drivers/watchdog/scx200_wdt.c: In function ‘scx200_wdt_ioctl’:
> drivers/watchdog/scx200_wdt.c:188:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> scx200_wdt_ping();
> ^~~~~~~~~~~~~~~~~
> drivers/watchdog/scx200_wdt.c:189:2: note: here
> case WDIOC_GETTIMEOUT:
> ^~~~
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
> ---
> drivers/watchdog/scx200_wdt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/scx200_wdt.c b/drivers/watchdog/scx200_wdt.c
> index efd7996694de..46268309ee9b 100644
> --- a/drivers/watchdog/scx200_wdt.c
> +++ b/drivers/watchdog/scx200_wdt.c
> @@ -186,6 +186,7 @@ static long scx200_wdt_ioctl(struct file *file, unsigned int cmd,
> margin = new_margin;
> scx200_wdt_update_margin();
> scx200_wdt_ping();
> + /* Fall through */
> case WDIOC_GETTIMEOUT:
> if (put_user(margin, p))
> return -EFAULT;
> --
> 2.22.0
>
--
Kees Cook
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] watchdog: scx200_wdt: Mark expected switch fall-through
2019-07-29 20:06 [PATCH] watchdog: scx200_wdt: Mark expected switch fall-through Gustavo A. R. Silva
2019-07-29 20:20 ` Guenter Roeck
2019-07-29 21:47 ` Kees Cook
@ 2019-07-30 17:08 ` Guenter Roeck
2 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2019-07-30 17:08 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Jim Cromie, Wim Van Sebroeck, linux-watchdog, linux-kernel, Kees Cook
On Mon, Jul 29, 2019 at 03:06:02PM -0500, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warning (Building: i386):
>
> drivers/watchdog/scx200_wdt.c: In function ‘scx200_wdt_ioctl’:
> drivers/watchdog/scx200_wdt.c:188:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> scx200_wdt_ping();
> ^~~~~~~~~~~~~~~~~
> drivers/watchdog/scx200_wdt.c:189:2: note: here
> case WDIOC_GETTIMEOUT:
> ^~~~
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/scx200_wdt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/scx200_wdt.c b/drivers/watchdog/scx200_wdt.c
> index efd7996694de..46268309ee9b 100644
> --- a/drivers/watchdog/scx200_wdt.c
> +++ b/drivers/watchdog/scx200_wdt.c
> @@ -186,6 +186,7 @@ static long scx200_wdt_ioctl(struct file *file, unsigned int cmd,
> margin = new_margin;
> scx200_wdt_update_margin();
> scx200_wdt_ping();
> + /* Fall through */
> case WDIOC_GETTIMEOUT:
> if (put_user(margin, p))
> return -EFAULT;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-07-30 17:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-29 20:06 [PATCH] watchdog: scx200_wdt: Mark expected switch fall-through Gustavo A. R. Silva
2019-07-29 20:20 ` Guenter Roeck
2019-07-29 21:47 ` Kees Cook
2019-07-30 17:08 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).