* [PATCH 2/5] [UPDATED] coresight: Convert pr_warn to dev_warn for obsolete bindings [not found] <20190729170035.GB26214@xps15> @ 2019-07-30 9:37 ` Suzuki K Poulose 2019-07-30 17:12 ` Mathieu Poirier 0 siblings, 1 reply; 2+ messages in thread From: Suzuki K Poulose @ 2019-07-30 9:37 UTC (permalink / raw) To: linux-arm-kernel; +Cc: linux-kernel, mathieu.poirier, Suzuki K Poulose We warn the users of obsolete bindings in the DT for coresight replicator and funnel drivers. However we use pr_warn_once() which doesn't give a clue about which device it is bound to. Let us use dev_warn_once() to give the context. Cc: Mathieu Poirier <mathieu.poirier@linaro.org> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> --- Changes since previous version: - Update replicator driver too. --- drivers/hwtracing/coresight/coresight-funnel.c | 2 +- drivers/hwtracing/coresight/coresight-replicator.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-funnel.c b/drivers/hwtracing/coresight/coresight-funnel.c index fa97cb9ab4f9..84ca30f4e5ec 100644 --- a/drivers/hwtracing/coresight/coresight-funnel.c +++ b/drivers/hwtracing/coresight/coresight-funnel.c @@ -192,7 +192,7 @@ static int funnel_probe(struct device *dev, struct resource *res) if (is_of_node(dev_fwnode(dev)) && of_device_is_compatible(dev->of_node, "arm,coresight-funnel")) - pr_warn_once("Uses OBSOLETE CoreSight funnel binding\n"); + dev_warn_once(dev, "Uses OBSOLETE CoreSight funnel binding\n"); desc.name = coresight_alloc_device_name(&funnel_devs, dev); if (!desc.name) diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c index b7d6d59d56db..b29ba640eb25 100644 --- a/drivers/hwtracing/coresight/coresight-replicator.c +++ b/drivers/hwtracing/coresight/coresight-replicator.c @@ -184,7 +184,8 @@ static int replicator_probe(struct device *dev, struct resource *res) if (is_of_node(dev_fwnode(dev)) && of_device_is_compatible(dev->of_node, "arm,coresight-replicator")) - pr_warn_once("Uses OBSOLETE CoreSight replicator binding\n"); + dev_warn_once(dev, + "Uses OBSOLETE CoreSight replicator binding\n"); desc.name = coresight_alloc_device_name(&replicator_devs, dev); if (!desc.name) -- 2.21.0 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/5] [UPDATED] coresight: Convert pr_warn to dev_warn for obsolete bindings 2019-07-30 9:37 ` [PATCH 2/5] [UPDATED] coresight: Convert pr_warn to dev_warn for obsolete bindings Suzuki K Poulose @ 2019-07-30 17:12 ` Mathieu Poirier 0 siblings, 0 replies; 2+ messages in thread From: Mathieu Poirier @ 2019-07-30 17:12 UTC (permalink / raw) To: Suzuki K Poulose; +Cc: linux-arm-kernel, Linux Kernel Mailing List On Tue, 30 Jul 2019 at 03:37, Suzuki K Poulose <suzuki.poulose@arm.com> wrote: > > We warn the users of obsolete bindings in the DT for coresight replicator > and funnel drivers. However we use pr_warn_once() which doesn't give a clue > about which device it is bound to. Let us use dev_warn_once() to give the > context. > > Cc: Mathieu Poirier <mathieu.poirier@linaro.org> > Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> > --- > > Changes since previous version: > - Update replicator driver too. > --- > drivers/hwtracing/coresight/coresight-funnel.c | 2 +- > drivers/hwtracing/coresight/coresight-replicator.c | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-funnel.c b/drivers/hwtracing/coresight/coresight-funnel.c > index fa97cb9ab4f9..84ca30f4e5ec 100644 > --- a/drivers/hwtracing/coresight/coresight-funnel.c > +++ b/drivers/hwtracing/coresight/coresight-funnel.c > @@ -192,7 +192,7 @@ static int funnel_probe(struct device *dev, struct resource *res) > > if (is_of_node(dev_fwnode(dev)) && > of_device_is_compatible(dev->of_node, "arm,coresight-funnel")) > - pr_warn_once("Uses OBSOLETE CoreSight funnel binding\n"); > + dev_warn_once(dev, "Uses OBSOLETE CoreSight funnel binding\n"); > > desc.name = coresight_alloc_device_name(&funnel_devs, dev); > if (!desc.name) > diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c > index b7d6d59d56db..b29ba640eb25 100644 > --- a/drivers/hwtracing/coresight/coresight-replicator.c > +++ b/drivers/hwtracing/coresight/coresight-replicator.c > @@ -184,7 +184,8 @@ static int replicator_probe(struct device *dev, struct resource *res) > > if (is_of_node(dev_fwnode(dev)) && > of_device_is_compatible(dev->of_node, "arm,coresight-replicator")) > - pr_warn_once("Uses OBSOLETE CoreSight replicator binding\n"); > + dev_warn_once(dev, > + "Uses OBSOLETE CoreSight replicator binding\n"); Applied - thanks Mathieu > > desc.name = coresight_alloc_device_name(&replicator_devs, dev); > if (!desc.name) > -- > 2.21.0 > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-30 17:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190729170035.GB26214@xps15>
2019-07-30 9:37 ` [PATCH 2/5] [UPDATED] coresight: Convert pr_warn to dev_warn for obsolete bindings Suzuki K Poulose
2019-07-30 17:12 ` Mathieu Poirier
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).