* [PATCH] net: dsa: mv88e6xxx: use link-down-define instead of plain value
@ 2019-07-30 10:11 Hubert Feurstein
2019-07-30 14:00 ` Andrew Lunn
2019-07-30 16:56 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Hubert Feurstein @ 2019-07-30 10:11 UTC (permalink / raw)
To: netdev, linux-kernel
Cc: Hubert Feurstein, Andrew Lunn, Vivien Didelot, Florian Fainelli,
David S. Miller
Using the define here makes the code more expressive.
Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
---
drivers/net/dsa/mv88e6xxx/chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index 58e298cc90e0..85638b868d8e 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -430,7 +430,7 @@ int mv88e6xxx_port_setup_mac(struct mv88e6xxx_chip *chip, int port, int link,
return 0;
/* Port's MAC control must not be changed unless the link is down */
- err = chip->info->ops->port_set_link(chip, port, 0);
+ err = chip->info->ops->port_set_link(chip, port, LINK_FORCED_DOWN);
if (err)
return err;
--
2.22.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: dsa: mv88e6xxx: use link-down-define instead of plain value
2019-07-30 10:11 [PATCH] net: dsa: mv88e6xxx: use link-down-define instead of plain value Hubert Feurstein
@ 2019-07-30 14:00 ` Andrew Lunn
2019-07-30 16:56 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2019-07-30 14:00 UTC (permalink / raw)
To: Hubert Feurstein
Cc: netdev, linux-kernel, Vivien Didelot, Florian Fainelli, David S. Miller
On Tue, Jul 30, 2019 at 12:11:42PM +0200, Hubert Feurstein wrote:
> Using the define here makes the code more expressive.
>
> Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: dsa: mv88e6xxx: use link-down-define instead of plain value
2019-07-30 10:11 [PATCH] net: dsa: mv88e6xxx: use link-down-define instead of plain value Hubert Feurstein
2019-07-30 14:00 ` Andrew Lunn
@ 2019-07-30 16:56 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-07-30 16:56 UTC (permalink / raw)
To: h.feurstein; +Cc: netdev, linux-kernel, andrew, vivien.didelot, f.fainelli
From: Hubert Feurstein <h.feurstein@gmail.com>
Date: Tue, 30 Jul 2019 12:11:42 +0200
> Using the define here makes the code more expressive.
>
> Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-30 16:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-30 10:11 [PATCH] net: dsa: mv88e6xxx: use link-down-define instead of plain value Hubert Feurstein
2019-07-30 14:00 ` Andrew Lunn
2019-07-30 16:56 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).