* Re: [PATCH] h8300: Add missing symbol "BOOT_LINK_OFFSET"
@ 2019-07-30 15:49 Guenter Roeck
2019-08-13 10:21 ` Yoshinori Sato
0 siblings, 1 reply; 2+ messages in thread
From: Guenter Roeck @ 2019-07-30 15:49 UTC (permalink / raw)
To: Yoshinori Sato; +Cc: uclinux-h8-devel, linux-kernel
On Wed, Jul 17, 2019 at 10:55:00PM +0900, Yoshinori Sato wrote:
> Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> ---
> arch/h8300/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/h8300/Kconfig b/arch/h8300/Kconfig
> index ecfc4b4b6373..6974513b1ae9 100644
> --- a/arch/h8300/Kconfig
> +++ b/arch/h8300/Kconfig
> @@ -45,4 +45,7 @@ config NR_CPUS
> int
> default 1
>
> +config BOOT_LINK_OFFSET
> + hex "zImage link offset"
> +
"hex" requires a default value. The above declaration generates
"CONFIG_BOOT_LINK_OFFSET=" in the configuration file, which is invalid
and can not be fixed with "make ARCH=h8300 olddefconfig". This in turn
results in "make" requesting a value when it encounters the symbol,
meaning that automated builds of h8300 images are no longer possible,
at least not without workarounds.
Guenter
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] h8300: Add missing symbol "BOOT_LINK_OFFSET"
2019-07-30 15:49 [PATCH] h8300: Add missing symbol "BOOT_LINK_OFFSET" Guenter Roeck
@ 2019-08-13 10:21 ` Yoshinori Sato
0 siblings, 0 replies; 2+ messages in thread
From: Yoshinori Sato @ 2019-08-13 10:21 UTC (permalink / raw)
To: Guenter Roeck; +Cc: uclinux-h8-devel, linux-kernel
On Wed, 31 Jul 2019 00:49:06 +0900,
Guenter Roeck wrote:
>
> On Wed, Jul 17, 2019 at 10:55:00PM +0900, Yoshinori Sato wrote:
> > Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> > ---
> > arch/h8300/Kconfig | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/arch/h8300/Kconfig b/arch/h8300/Kconfig
> > index ecfc4b4b6373..6974513b1ae9 100644
> > --- a/arch/h8300/Kconfig
> > +++ b/arch/h8300/Kconfig
> > @@ -45,4 +45,7 @@ config NR_CPUS
> > int
> > default 1
> >
> > +config BOOT_LINK_OFFSET
> > + hex "zImage link offset"
> > +
>
> "hex" requires a default value. The above declaration generates
> "CONFIG_BOOT_LINK_OFFSET=" in the configuration file, which is invalid
> and can not be fixed with "make ARCH=h8300 olddefconfig". This in turn
> results in "make" requesting a value when it encounters the symbol,
> meaning that automated builds of h8300 images are no longer possible,
> at least not without workarounds.
>
> Guenter
Sorry too late reply.
OK fixed it.
Thanks your comment.
--
Yosinori Sato
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-13 10:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-30 15:49 [PATCH] h8300: Add missing symbol "BOOT_LINK_OFFSET" Guenter Roeck
2019-08-13 10:21 ` Yoshinori Sato
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).