* [PATCH] mmc: atmel-mci: Mark expected switch fall-throughs
@ 2019-07-29 0:01 Gustavo A. R. Silva
2019-07-29 16:35 ` Kees Cook
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Gustavo A. R. Silva @ 2019-07-29 0:01 UTC (permalink / raw)
To: Ludovic Desroches, Ulf Hansson, Nicolas Ferre, Alexandre Belloni
Cc: linux-mmc, linux-arm-kernel, linux-kernel, Gustavo A. R. Silva,
Stephen Rothwell, Kees Cook
Mark switch cases where we are expecting to fall through.
This patch fixes the following warnings:
drivers/mmc/host/atmel-mci.c: In function 'atmci_get_cap':
drivers/mmc/host/atmel-mci.c:2415:30: warning: this statement may fall through [-Wimplicit-fallthrough=]
host->caps.has_odd_clk_div = 1;
~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
drivers/mmc/host/atmel-mci.c:2416:2: note: here
case 0x400:
^~~~
drivers/mmc/host/atmel-mci.c:2422:28: warning: this statement may fall through [-Wimplicit-fallthrough=]
host->caps.has_highspeed = 1;
~~~~~~~~~~~~~~~~~~~~~~~~~^~~
drivers/mmc/host/atmel-mci.c:2423:2: note: here
case 0x200:
^~~~
drivers/mmc/host/atmel-mci.c:2426:40: warning: this statement may fall through [-Wimplicit-fallthrough=]
host->caps.need_notbusy_for_read_ops = 1;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
drivers/mmc/host/atmel-mci.c:2427:2: note: here
case 0x100:
^~~~
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/mmc/host/atmel-mci.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
index 9ee0bc0ce6d0..c26fbe5f2222 100644
--- a/drivers/mmc/host/atmel-mci.c
+++ b/drivers/mmc/host/atmel-mci.c
@@ -2413,6 +2413,7 @@ static void atmci_get_cap(struct atmel_mci *host)
case 0x600:
case 0x500:
host->caps.has_odd_clk_div = 1;
+ /* Fall through */
case 0x400:
case 0x300:
host->caps.has_dma_conf_reg = 1;
@@ -2420,13 +2421,16 @@ static void atmci_get_cap(struct atmel_mci *host)
host->caps.has_cfg_reg = 1;
host->caps.has_cstor_reg = 1;
host->caps.has_highspeed = 1;
+ /* Fall through */
case 0x200:
host->caps.has_rwproof = 1;
host->caps.need_blksz_mul_4 = 0;
host->caps.need_notbusy_for_read_ops = 1;
+ /* Fall through */
case 0x100:
host->caps.has_bad_data_ordering = 0;
host->caps.need_reset_after_xfer = 0;
+ /* Fall through */
case 0x0:
break;
default:
--
2.22.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] mmc: atmel-mci: Mark expected switch fall-throughs
2019-07-29 0:01 [PATCH] mmc: atmel-mci: Mark expected switch fall-throughs Gustavo A. R. Silva
@ 2019-07-29 16:35 ` Kees Cook
2019-07-31 11:32 ` Ludovic Desroches
2019-08-02 15:16 ` Ulf Hansson
2 siblings, 0 replies; 6+ messages in thread
From: Kees Cook @ 2019-07-29 16:35 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Ludovic Desroches, Ulf Hansson, Nicolas Ferre, Alexandre Belloni,
linux-mmc, linux-arm-kernel, linux-kernel, Stephen Rothwell
On Sun, Jul 28, 2019 at 07:01:23PM -0500, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warnings:
>
> drivers/mmc/host/atmel-mci.c: In function 'atmci_get_cap':
> drivers/mmc/host/atmel-mci.c:2415:30: warning: this statement may fall through [-Wimplicit-fallthrough=]
> host->caps.has_odd_clk_div = 1;
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
> drivers/mmc/host/atmel-mci.c:2416:2: note: here
> case 0x400:
> ^~~~
> drivers/mmc/host/atmel-mci.c:2422:28: warning: this statement may fall through [-Wimplicit-fallthrough=]
> host->caps.has_highspeed = 1;
> ~~~~~~~~~~~~~~~~~~~~~~~~~^~~
> drivers/mmc/host/atmel-mci.c:2423:2: note: here
> case 0x200:
> ^~~~
> drivers/mmc/host/atmel-mci.c:2426:40: warning: this statement may fall through [-Wimplicit-fallthrough=]
> host->caps.need_notbusy_for_read_ops = 1;
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
> drivers/mmc/host/atmel-mci.c:2427:2: note: here
> case 0x100:
> ^~~~
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
> ---
> drivers/mmc/host/atmel-mci.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
> index 9ee0bc0ce6d0..c26fbe5f2222 100644
> --- a/drivers/mmc/host/atmel-mci.c
> +++ b/drivers/mmc/host/atmel-mci.c
> @@ -2413,6 +2413,7 @@ static void atmci_get_cap(struct atmel_mci *host)
> case 0x600:
> case 0x500:
> host->caps.has_odd_clk_div = 1;
> + /* Fall through */
> case 0x400:
> case 0x300:
> host->caps.has_dma_conf_reg = 1;
> @@ -2420,13 +2421,16 @@ static void atmci_get_cap(struct atmel_mci *host)
> host->caps.has_cfg_reg = 1;
> host->caps.has_cstor_reg = 1;
> host->caps.has_highspeed = 1;
> + /* Fall through */
> case 0x200:
> host->caps.has_rwproof = 1;
> host->caps.need_blksz_mul_4 = 0;
> host->caps.need_notbusy_for_read_ops = 1;
> + /* Fall through */
> case 0x100:
> host->caps.has_bad_data_ordering = 0;
> host->caps.need_reset_after_xfer = 0;
> + /* Fall through */
> case 0x0:
> break;
> default:
> --
> 2.22.0
>
--
Kees Cook
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mmc: atmel-mci: Mark expected switch fall-throughs
2019-07-29 0:01 [PATCH] mmc: atmel-mci: Mark expected switch fall-throughs Gustavo A. R. Silva
2019-07-29 16:35 ` Kees Cook
@ 2019-07-31 11:32 ` Ludovic Desroches
2019-07-31 16:06 ` Kees Cook
2019-08-02 15:16 ` Ulf Hansson
2 siblings, 1 reply; 6+ messages in thread
From: Ludovic Desroches @ 2019-07-31 11:32 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Ulf Hansson, Nicolas Ferre, Alexandre Belloni, linux-mmc,
linux-arm-kernel, linux-kernel, Stephen Rothwell, Kees Cook
Hi,
On Sun, Jul 28, 2019 at 07:01:23PM -0500, Gustavo A. R. Silva wrote:
>
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warnings:
>
> drivers/mmc/host/atmel-mci.c: In function 'atmci_get_cap':
> drivers/mmc/host/atmel-mci.c:2415:30: warning: this statement may fall through [-Wimplicit-fallthrough=]
> host->caps.has_odd_clk_div = 1;
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
> drivers/mmc/host/atmel-mci.c:2416:2: note: here
> case 0x400:
> ^~~~
> drivers/mmc/host/atmel-mci.c:2422:28: warning: this statement may fall through [-Wimplicit-fallthrough=]
> host->caps.has_highspeed = 1;
> ~~~~~~~~~~~~~~~~~~~~~~~~~^~~
> drivers/mmc/host/atmel-mci.c:2423:2: note: here
> case 0x200:
> ^~~~
> drivers/mmc/host/atmel-mci.c:2426:40: warning: this statement may fall through [-Wimplicit-fallthrough=]
> host->caps.need_notbusy_for_read_ops = 1;
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
> drivers/mmc/host/atmel-mci.c:2427:2: note: here
> case 0x100:
> ^~~~
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
I don't know if there is a policy in the kernel about the expression to
use. As this one does the job
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Thanks
> ---
> drivers/mmc/host/atmel-mci.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
> index 9ee0bc0ce6d0..c26fbe5f2222 100644
> --- a/drivers/mmc/host/atmel-mci.c
> +++ b/drivers/mmc/host/atmel-mci.c
> @@ -2413,6 +2413,7 @@ static void atmci_get_cap(struct atmel_mci *host)
> case 0x600:
> case 0x500:
> host->caps.has_odd_clk_div = 1;
> + /* Fall through */
> case 0x400:
> case 0x300:
> host->caps.has_dma_conf_reg = 1;
> @@ -2420,13 +2421,16 @@ static void atmci_get_cap(struct atmel_mci *host)
> host->caps.has_cfg_reg = 1;
> host->caps.has_cstor_reg = 1;
> host->caps.has_highspeed = 1;
> + /* Fall through */
> case 0x200:
> host->caps.has_rwproof = 1;
> host->caps.need_blksz_mul_4 = 0;
> host->caps.need_notbusy_for_read_ops = 1;
> + /* Fall through */
> case 0x100:
> host->caps.has_bad_data_ordering = 0;
> host->caps.need_reset_after_xfer = 0;
> + /* Fall through */
> case 0x0:
> break;
> default:
> --
> 2.22.0
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mmc: atmel-mci: Mark expected switch fall-throughs
2019-07-31 11:32 ` Ludovic Desroches
@ 2019-07-31 16:06 ` Kees Cook
2019-08-01 7:11 ` Ludovic Desroches
0 siblings, 1 reply; 6+ messages in thread
From: Kees Cook @ 2019-07-31 16:06 UTC (permalink / raw)
To: Gustavo A. R. Silva, Ulf Hansson, Nicolas Ferre,
Alexandre Belloni, linux-mmc, linux-arm-kernel, linux-kernel,
Stephen Rothwell
On Wed, Jul 31, 2019 at 01:32:16PM +0200, Ludovic Desroches wrote:
> > drivers/mmc/host/atmel-mci.c:2426:40: warning: this statement may fall through [-Wimplicit-fallthrough=]
> > host->caps.need_notbusy_for_read_ops = 1;
> > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
> > drivers/mmc/host/atmel-mci.c:2427:2: note: here
> > case 0x100:
> > ^~~~
> >
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> I don't know if there is a policy in the kernel about the expression to
> use. As this one does the job
Yup, documented here:
https://www.kernel.org/doc/html/latest/process/deprecated.html#implicit-switch-case-fall-through
> Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Thanks!
--
Kees Cook
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mmc: atmel-mci: Mark expected switch fall-throughs
2019-07-31 16:06 ` Kees Cook
@ 2019-08-01 7:11 ` Ludovic Desroches
0 siblings, 0 replies; 6+ messages in thread
From: Ludovic Desroches @ 2019-08-01 7:11 UTC (permalink / raw)
To: Kees Cook
Cc: Gustavo A. R. Silva, Ulf Hansson, Nicolas Ferre,
Alexandre Belloni, linux-mmc, linux-arm-kernel, linux-kernel,
Stephen Rothwell
On Wed, Jul 31, 2019 at 09:06:07AM -0700, Kees Cook wrote:
> On Wed, Jul 31, 2019 at 01:32:16PM +0200, Ludovic Desroches wrote:
> > > drivers/mmc/host/atmel-mci.c:2426:40: warning: this statement may fall through [-Wimplicit-fallthrough=]
> > > host->caps.need_notbusy_for_read_ops = 1;
> > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
> > > drivers/mmc/host/atmel-mci.c:2427:2: note: here
> > > case 0x100:
> > > ^~~~
> > >
> > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> >
> > I don't know if there is a policy in the kernel about the expression to
> > use. As this one does the job
>
> Yup, documented here:
> https://www.kernel.org/doc/html/latest/process/deprecated.html#implicit-switch-case-fall-through
Thanks for the pointer.
Regards
Ludovic
>
> > Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
>
> Thanks!
>
> --
> Kees Cook
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mmc: atmel-mci: Mark expected switch fall-throughs
2019-07-29 0:01 [PATCH] mmc: atmel-mci: Mark expected switch fall-throughs Gustavo A. R. Silva
2019-07-29 16:35 ` Kees Cook
2019-07-31 11:32 ` Ludovic Desroches
@ 2019-08-02 15:16 ` Ulf Hansson
2 siblings, 0 replies; 6+ messages in thread
From: Ulf Hansson @ 2019-08-02 15:16 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Ludovic Desroches, Nicolas Ferre, Alexandre Belloni, linux-mmc,
Linux ARM, Linux Kernel Mailing List, Stephen Rothwell,
Kees Cook
On Mon, 29 Jul 2019 at 02:01, Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
>
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warnings:
>
> drivers/mmc/host/atmel-mci.c: In function 'atmci_get_cap':
> drivers/mmc/host/atmel-mci.c:2415:30: warning: this statement may fall through [-Wimplicit-fallthrough=]
> host->caps.has_odd_clk_div = 1;
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
> drivers/mmc/host/atmel-mci.c:2416:2: note: here
> case 0x400:
> ^~~~
> drivers/mmc/host/atmel-mci.c:2422:28: warning: this statement may fall through [-Wimplicit-fallthrough=]
> host->caps.has_highspeed = 1;
> ~~~~~~~~~~~~~~~~~~~~~~~~~^~~
> drivers/mmc/host/atmel-mci.c:2423:2: note: here
> case 0x200:
> ^~~~
> drivers/mmc/host/atmel-mci.c:2426:40: warning: this statement may fall through [-Wimplicit-fallthrough=]
> host->caps.need_notbusy_for_read_ops = 1;
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
> drivers/mmc/host/atmel-mci.c:2427:2: note: here
> case 0x100:
> ^~~~
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/atmel-mci.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
> index 9ee0bc0ce6d0..c26fbe5f2222 100644
> --- a/drivers/mmc/host/atmel-mci.c
> +++ b/drivers/mmc/host/atmel-mci.c
> @@ -2413,6 +2413,7 @@ static void atmci_get_cap(struct atmel_mci *host)
> case 0x600:
> case 0x500:
> host->caps.has_odd_clk_div = 1;
> + /* Fall through */
> case 0x400:
> case 0x300:
> host->caps.has_dma_conf_reg = 1;
> @@ -2420,13 +2421,16 @@ static void atmci_get_cap(struct atmel_mci *host)
> host->caps.has_cfg_reg = 1;
> host->caps.has_cstor_reg = 1;
> host->caps.has_highspeed = 1;
> + /* Fall through */
> case 0x200:
> host->caps.has_rwproof = 1;
> host->caps.need_blksz_mul_4 = 0;
> host->caps.need_notbusy_for_read_ops = 1;
> + /* Fall through */
> case 0x100:
> host->caps.has_bad_data_ordering = 0;
> host->caps.need_reset_after_xfer = 0;
> + /* Fall through */
> case 0x0:
> break;
> default:
> --
> 2.22.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-08-02 15:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-29 0:01 [PATCH] mmc: atmel-mci: Mark expected switch fall-throughs Gustavo A. R. Silva
2019-07-29 16:35 ` Kees Cook
2019-07-31 11:32 ` Ludovic Desroches
2019-07-31 16:06 ` Kees Cook
2019-08-01 7:11 ` Ludovic Desroches
2019-08-02 15:16 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).