From: Dan Carpenter <firstname.lastname@example.org> To: "Aurélien Aptel" <email@example.com> Cc: Colin King <firstname.lastname@example.org>, email@example.com, Steve French <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org, email@example.com Subject: Re: [PATCH] cifs: remove redundant assignment to variable rc Date: Thu, 1 Aug 2019 11:03:43 +0300 [thread overview] Message-ID: <20190801080343.GA1935@kadam> (raw) In-Reply-To: <firstname.lastname@example.org> On Wed, Jul 31, 2019 at 05:34:39PM +0200, Aurélien Aptel wrote: > "Dan Carpenter" <email@example.com> writes: > > You're just turning off GCC's static analysis (and introducing false > > positives) when you do that. We have seen bugs caused by this and never > > seen any bugs prevented by this style. > > You've never seen bugs prevented by initializing uninitialized > variables? Code can change overtime and I don't think coverity is > checked as often as it could be, meaning the var could end up being used > while uninitialized in the future. Of course, we wouldn't see bugs that were prevented so that wasn't entirely fair. There is a several year old bug in GCC where it sometimes initializes these to zero and doesn't warn about the uninitialized variable so it is actually possible to prevent a bug by initializing it to an error code. Smatch also warns about uninitialized variables. I normally run Smatch on linux-next every day but I have been out of office for the past month and my config doesn't cover everything. We haven't been able to enable this "redundant assignment" warning because of all the false positives like this. It mostly finds dead code but it also does find some bugs where we forget to check the error code or we use the wrong variable. regards, dan carpenter
prev parent reply other threads:[~2019-08-01 8:04 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-31 9:05 Colin King 2019-07-31 10:09 ` Aurélien Aptel 2019-07-31 12:28 ` Dan Carpenter 2019-07-31 15:34 ` Aurélien Aptel 2019-07-31 15:54 ` Colin Ian King 2019-08-01 17:00 ` Steve French 2019-08-01 8:03 ` Dan Carpenter [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190801080343.GA1935@kadam \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] cifs: remove redundant assignment to variable rc' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).