* [PATCH -next] drm/vgem: Fix wrong pointer passed to PTR_ERR()
@ 2019-08-02 1:29 Wei Yongjun
0 siblings, 0 replies; only message in thread
From: Wei Yongjun @ 2019-08-02 1:29 UTC (permalink / raw)
To: David Airlie, Daniel Vetter, Rob Clark, Thomas Zimmermann,
Eric Biggers, Sam Ravnborg, Sean Paul
Cc: Wei Yongjun, dri-devel, linux-kernel, kernel-janitors
PTR_ERR should access the value just tested by IS_ERR, otherwise
the wrong error code will be returned.
Fixes: 7e9e5ead55be ("drm/vgem: fix cache synchronization on arm/arm64")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/gpu/drm/vgem/vgem_drv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
index b98689fb0d5d..ef52546f48c4 100644
--- a/drivers/gpu/drm/vgem/vgem_drv.c
+++ b/drivers/gpu/drm/vgem/vgem_drv.c
@@ -304,10 +304,10 @@ static struct page **pin_and_sync(struct drm_vgem_gem_object *bo)
if (IS_ERR(sgt)) {
dev_err(dev->dev,
"failed to allocate sgt: %ld\n",
- PTR_ERR(bo->table));
+ PTR_ERR(sgt));
drm_gem_put_pages(&bo->base, pages, false, false);
mutex_unlock(&bo->pages_lock);
- return ERR_CAST(bo->table);
+ return ERR_CAST(sgt);
}
/*
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-08-02 1:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-02 1:29 [PATCH -next] drm/vgem: Fix wrong pointer passed to PTR_ERR() Wei Yongjun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).