* [PATCH v2] scsi: ufs: Configure clock in .hce_enable_notify() in Cadence UFS
@ 2019-08-02 11:21 Anil Varughese
2019-08-05 8:02 ` Vignesh Raghavendra
2019-08-08 1:51 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Anil Varughese @ 2019-08-02 11:21 UTC (permalink / raw)
To: alim.akhtar, avri.altman, pedrom.sousa
Cc: jejb, martin.petersen, hare, aniljoy, rafalc, mparab, jank,
pawell, vigneshr, linux-scsi, linux-kernel
Configure CDNS_UFS_REG_HCLKDIV in .hce_enable_notify() instead of
.setup_clock() because if UFSHCD resets the controller ip because
of phy or device related errors then CDNS_UFS_REG_HCLKDIV is
reset to default value and .setup_clock() is not called later
in the sequence whereas .hce_enable_notify will be called everytime
controller is reenabled.
Signed-off-by: Anil Varughese <aniljoy@cadence.com>
---
drivers/scsi/ufs/cdns-pltfrm.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/ufs/cdns-pltfrm.c b/drivers/scsi/ufs/cdns-pltfrm.c
index 86dbb723f..993519080 100644
--- a/drivers/scsi/ufs/cdns-pltfrm.c
+++ b/drivers/scsi/ufs/cdns-pltfrm.c
@@ -62,17 +62,16 @@ static int cdns_ufs_set_hclkdiv(struct ufs_hba *hba)
}
/**
- * Sets clocks used by the controller
+ * Called before and after HCE enable bit is set.
* @hba: host controller instance
- * @on: if true, enable clocks, otherwise disable
* @status: notify stage (pre, post change)
*
* Return zero for success and non-zero for failure
*/
-static int cdns_ufs_setup_clocks(struct ufs_hba *hba, bool on,
- enum ufs_notify_change_status status)
+static int cdns_ufs_hce_enable_notify(struct ufs_hba *hba,
+ enum ufs_notify_change_status status)
{
- if ((!on) || (status == PRE_CHANGE))
+ if (status != PRE_CHANGE)
return 0;
return cdns_ufs_set_hclkdiv(hba);
@@ -114,13 +113,13 @@ static int cdns_ufs_m31_16nm_phy_initialization(struct ufs_hba *hba)
static const struct ufs_hba_variant_ops cdns_ufs_pltfm_hba_vops = {
.name = "cdns-ufs-pltfm",
- .setup_clocks = cdns_ufs_setup_clocks,
+ .hce_enable_notify = cdns_ufs_hce_enable_notify,
};
static const struct ufs_hba_variant_ops cdns_ufs_m31_16nm_pltfm_hba_vops = {
.name = "cdns-ufs-pltfm",
.init = cdns_ufs_init,
- .setup_clocks = cdns_ufs_setup_clocks,
+ .hce_enable_notify = cdns_ufs_hce_enable_notify,
.phy_initialization = cdns_ufs_m31_16nm_phy_initialization,
};
--
2.15.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] scsi: ufs: Configure clock in .hce_enable_notify() in Cadence UFS
2019-08-02 11:21 [PATCH v2] scsi: ufs: Configure clock in .hce_enable_notify() in Cadence UFS Anil Varughese
@ 2019-08-05 8:02 ` Vignesh Raghavendra
2019-08-08 1:51 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Vignesh Raghavendra @ 2019-08-05 8:02 UTC (permalink / raw)
To: Anil Varughese, alim.akhtar, avri.altman, pedrom.sousa
Cc: jejb, martin.petersen, hare, rafalc, mparab, jank, pawell,
linux-scsi, linux-kernel
Hi,
On 02/08/19 4:51 PM, Anil Varughese wrote:
> Configure CDNS_UFS_REG_HCLKDIV in .hce_enable_notify() instead of
> .setup_clock() because if UFSHCD resets the controller ip because
> of phy or device related errors then CDNS_UFS_REG_HCLKDIV is
> reset to default value and .setup_clock() is not called later
> in the sequence whereas .hce_enable_notify will be called everytime
> controller is reenabled.
>
> Signed-off-by: Anil Varughese <aniljoy@cadence.com>
> ---
Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com>
> drivers/scsi/ufs/cdns-pltfrm.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/scsi/ufs/cdns-pltfrm.c b/drivers/scsi/ufs/cdns-pltfrm.c
> index 86dbb723f..993519080 100644
> --- a/drivers/scsi/ufs/cdns-pltfrm.c
> +++ b/drivers/scsi/ufs/cdns-pltfrm.c
> @@ -62,17 +62,16 @@ static int cdns_ufs_set_hclkdiv(struct ufs_hba *hba)
> }
>
> /**
> - * Sets clocks used by the controller
> + * Called before and after HCE enable bit is set.
> * @hba: host controller instance
> - * @on: if true, enable clocks, otherwise disable
> * @status: notify stage (pre, post change)
> *
> * Return zero for success and non-zero for failure
> */
> -static int cdns_ufs_setup_clocks(struct ufs_hba *hba, bool on,
> - enum ufs_notify_change_status status)
> +static int cdns_ufs_hce_enable_notify(struct ufs_hba *hba,
> + enum ufs_notify_change_status status)
> {
> - if ((!on) || (status == PRE_CHANGE))
> + if (status != PRE_CHANGE)
> return 0;
>
> return cdns_ufs_set_hclkdiv(hba);
> @@ -114,13 +113,13 @@ static int cdns_ufs_m31_16nm_phy_initialization(struct ufs_hba *hba)
>
> static const struct ufs_hba_variant_ops cdns_ufs_pltfm_hba_vops = {
> .name = "cdns-ufs-pltfm",
> - .setup_clocks = cdns_ufs_setup_clocks,
> + .hce_enable_notify = cdns_ufs_hce_enable_notify,
> };
>
> static const struct ufs_hba_variant_ops cdns_ufs_m31_16nm_pltfm_hba_vops = {
> .name = "cdns-ufs-pltfm",
> .init = cdns_ufs_init,
> - .setup_clocks = cdns_ufs_setup_clocks,
> + .hce_enable_notify = cdns_ufs_hce_enable_notify,
> .phy_initialization = cdns_ufs_m31_16nm_phy_initialization,
> };
>
>
--
Regards
Vignesh
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] scsi: ufs: Configure clock in .hce_enable_notify() in Cadence UFS
2019-08-02 11:21 [PATCH v2] scsi: ufs: Configure clock in .hce_enable_notify() in Cadence UFS Anil Varughese
2019-08-05 8:02 ` Vignesh Raghavendra
@ 2019-08-08 1:51 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2019-08-08 1:51 UTC (permalink / raw)
To: Anil Varughese
Cc: alim.akhtar, avri.altman, pedrom.sousa, jejb, martin.petersen,
hare, rafalc, mparab, jank, pawell, vigneshr, linux-scsi,
linux-kernel
Anil,
> Configure CDNS_UFS_REG_HCLKDIV in .hce_enable_notify() instead of
> .setup_clock() because if UFSHCD resets the controller ip because
> of phy or device related errors then CDNS_UFS_REG_HCLKDIV is
> reset to default value and .setup_clock() is not called later
> in the sequence whereas .hce_enable_notify will be called everytime
> controller is reenabled.
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-08 1:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-02 11:21 [PATCH v2] scsi: ufs: Configure clock in .hce_enable_notify() in Cadence UFS Anil Varughese
2019-08-05 8:02 ` Vignesh Raghavendra
2019-08-08 1:51 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).