* [PATCH] drivers:staging:isdn:hysdn brace same line if
@ 2019-08-02 19:51 Fernando Eckhardt Valle
2019-08-03 6:35 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Fernando Eckhardt Valle @ 2019-08-02 19:51 UTC (permalink / raw)
To: isdn, gregkh, netdev, devel, linux-kernel
Fix checkpatch error "ERROR: that open brace { should be on the previous
line" in drivers/staging/isdn/hysdn/hycapi.c:51.
Signed-off-by: Fernando Eckhardt Valle <phervalle@gmail.com>
---
drivers/staging/isdn/hysdn/hycapi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/isdn/hysdn/hycapi.c b/drivers/staging/isdn/hysdn/hycapi.c
index a2c15cd7b..e5dc707d5 100644
--- a/drivers/staging/isdn/hysdn/hycapi.c
+++ b/drivers/staging/isdn/hysdn/hycapi.c
@@ -49,8 +49,7 @@ static u16 hycapi_send_message(struct capi_ctr *ctrl, struct sk_buff *skb);
static inline int _hycapi_appCheck(int app_id, int ctrl_no)
{
if ((ctrl_no <= 0) || (ctrl_no > CAPI_MAXCONTR) || (app_id <= 0) ||
- (app_id > CAPI_MAXAPPL))
- {
+ (app_id > CAPI_MAXAPPL)) {
printk(KERN_ERR "HYCAPI: Invalid request app_id %d for controller %d", app_id, ctrl_no);
return -1;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers:staging:isdn:hysdn brace same line if
2019-08-02 19:51 [PATCH] drivers:staging:isdn:hysdn brace same line if Fernando Eckhardt Valle
@ 2019-08-03 6:35 ` Greg KH
[not found] ` <CACRBQB+wx3=3vQrvnxjcoiZaZjP7EOF+f0NYa4p-XKTHW79RiA@mail.gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2019-08-03 6:35 UTC (permalink / raw)
To: Fernando Eckhardt Valle; +Cc: isdn, netdev, devel, linux-kernel
On Fri, Aug 02, 2019 at 07:51:05PM +0000, Fernando Eckhardt Valle wrote:
> Fix checkpatch error "ERROR: that open brace { should be on the previous
> line" in drivers/staging/isdn/hysdn/hycapi.c:51.
>
> Signed-off-by: Fernando Eckhardt Valle <phervalle@gmail.com>
> ---
> drivers/staging/isdn/hysdn/hycapi.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Your subject line does not make sense :(
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers:staging:isdn:hysdn brace same line if
[not found] ` <CACRBQB+wx3=3vQrvnxjcoiZaZjP7EOF+f0NYa4p-XKTHW79RiA@mail.gmail.com>
@ 2019-08-05 4:42 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2019-08-05 4:42 UTC (permalink / raw)
To: Fernando Valle; +Cc: isdn, netdev, devel, linux-kernel
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Sun, Aug 04, 2019 at 10:04:40PM -0300, Fernando Valle wrote:
> Sorry Greg, it was my first submission.
> I followed the kernel newbies tutorial and some other found on the internet.
The best description of how to pick a subject line is in the section
entitled "The canonical patch format" in the kernel file,
Documentation/SubmittingPatches. Please read that whole file as it
contains everything you need to know about writing good changelog texts
and everything else.
> So, the correct form of the subject would be -> "staging:isdn:hysdn open
> braces in correct location" !?
That's better than what you currently have, but I know you can do much
better than that :)
good luck!
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-05 4:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-02 19:51 [PATCH] drivers:staging:isdn:hysdn brace same line if Fernando Eckhardt Valle
2019-08-03 6:35 ` Greg KH
[not found] ` <CACRBQB+wx3=3vQrvnxjcoiZaZjP7EOF+f0NYa4p-XKTHW79RiA@mail.gmail.com>
2019-08-05 4:42 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).