* [PATCH] pcmcia: db1xxx_ss: Mark expected switch fall-throughs
@ 2019-08-05 19:49 Gustavo A. R. Silva
2019-08-05 20:18 ` Kees Cook
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2019-08-05 19:49 UTC (permalink / raw)
To: Dominik Brodowski; +Cc: linux-kernel, Gustavo A. R. Silva, Kees Cook
Mark switch cases where we are expecting to fall through.
This patch fixes the following warnings (Building: db1xxx_defconfig mips):
drivers/pcmcia/db1xxx_ss.c:257:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
drivers/pcmcia/db1xxx_ss.c:269:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/pcmcia/db1xxx_ss.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/pcmcia/db1xxx_ss.c b/drivers/pcmcia/db1xxx_ss.c
index eb6168e6ac43..590e594092f2 100644
--- a/drivers/pcmcia/db1xxx_ss.c
+++ b/drivers/pcmcia/db1xxx_ss.c
@@ -255,8 +255,10 @@ static int db1x_pcmcia_configure(struct pcmcia_socket *skt,
switch (state->Vcc) {
case 50:
++v;
+ /* fall through */
case 33:
++v;
+ /* fall through */
case 0:
break;
default:
@@ -267,9 +269,11 @@ static int db1x_pcmcia_configure(struct pcmcia_socket *skt,
switch (state->Vpp) {
case 12:
++p;
+ /* fall through */
case 33:
case 50:
++p;
+ /* fall through */
case 0:
break;
default:
--
2.22.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] pcmcia: db1xxx_ss: Mark expected switch fall-throughs
2019-08-05 19:49 [PATCH] pcmcia: db1xxx_ss: Mark expected switch fall-throughs Gustavo A. R. Silva
@ 2019-08-05 20:18 ` Kees Cook
0 siblings, 0 replies; 2+ messages in thread
From: Kees Cook @ 2019-08-05 20:18 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: Dominik Brodowski, linux-kernel
On Mon, Aug 05, 2019 at 02:49:42PM -0500, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warnings (Building: db1xxx_defconfig mips):
>
> drivers/pcmcia/db1xxx_ss.c:257:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> drivers/pcmcia/db1xxx_ss.c:269:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
> ---
> drivers/pcmcia/db1xxx_ss.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/pcmcia/db1xxx_ss.c b/drivers/pcmcia/db1xxx_ss.c
> index eb6168e6ac43..590e594092f2 100644
> --- a/drivers/pcmcia/db1xxx_ss.c
> +++ b/drivers/pcmcia/db1xxx_ss.c
> @@ -255,8 +255,10 @@ static int db1x_pcmcia_configure(struct pcmcia_socket *skt,
> switch (state->Vcc) {
> case 50:
> ++v;
> + /* fall through */
> case 33:
> ++v;
> + /* fall through */
> case 0:
> break;
> default:
> @@ -267,9 +269,11 @@ static int db1x_pcmcia_configure(struct pcmcia_socket *skt,
> switch (state->Vpp) {
> case 12:
> ++p;
> + /* fall through */
> case 33:
> case 50:
> ++p;
> + /* fall through */
> case 0:
> break;
> default:
> --
> 2.22.0
>
--
Kees Cook
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-05 20:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-05 19:49 [PATCH] pcmcia: db1xxx_ss: Mark expected switch fall-throughs Gustavo A. R. Silva
2019-08-05 20:18 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).