From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Giridhar Prasath R <cristianoprasath@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: pi433 line over 80 characters in multiple places
Date: Mon, 5 Aug 2019 17:03:04 +0200 [thread overview]
Message-ID: <20190805150304.GA746@kroah.com> (raw)
In-Reply-To: <20190805000248.4902-1-cristianoprasath@gmail.com>
On Mon, Aug 05, 2019 at 05:32:45AM +0530, Giridhar Prasath R wrote:
> Fix the following checkpatch warnings:
>
> WARNING: line over 80 characters
> FILE: drivers/staging/pi433/pi433_if.h
>
> Signed-off-by: Giridhar Prasath R <cristianoprasath@gmail.com>
> ---
> drivers/staging/pi433/pi433_if.h | 23 ++++++++++++++++-------
> 1 file changed, 16 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433/pi433_if.h
> index 9feb95c431cb..915bd96910c6 100644
> --- a/drivers/staging/pi433/pi433_if.h
> +++ b/drivers/staging/pi433/pi433_if.h
> @@ -117,9 +117,14 @@ struct pi433_rx_cfg {
>
> /* packet format */
> enum option_on_off enable_sync;
> - enum option_on_off enable_length_byte; /* should be used in combination with sync, only */
> - enum address_filtering enable_address_filtering; /* operational with sync, only */
> - enum option_on_off enable_crc; /* only operational, if sync on and fixed length or length byte is used */
> + /* should be used in combination with sync, only */
> + enum option_on_off enable_length_byte;
> + /* operational with sync, only */
> + enum address_filtering enable_address_filtering;
> + /* only operational,
> + * if sync on and fixed length or length byte is used
> + */
> + enum option_on_off enable_crc;
>
> __u8 sync_length;
> __u8 fixed_message_length;
> @@ -132,10 +137,14 @@ struct pi433_rx_cfg {
>
> #define PI433_IOC_MAGIC 'r'
>
> -#define PI433_IOC_RD_TX_CFG _IOR(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR, char[sizeof(struct pi433_tx_cfg)])
> -#define PI433_IOC_WR_TX_CFG _IOW(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR, char[sizeof(struct pi433_tx_cfg)])
> +#define PI433_IOC_RD_TX_CFG _IOR(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR,\
> +char[sizeof(struct pi433_tx_cfg)])
Ick, that does not look better :(
We write code for humans first, compilers second.
The original is fine, thanks.
greg k-h
prev parent reply other threads:[~2019-08-05 15:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 0:02 [PATCH] staging: pi433 line over 80 characters in multiple places Giridhar Prasath R
2019-08-05 14:36 ` Dan Carpenter
2019-08-05 15:03 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190805150304.GA746@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=cristianoprasath@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).