* [PATCH] gpu: drm: amd: powerplay: Remove logically dead code
@ 2019-08-05 17:21 Hariprasad Kelam
2019-08-06 14:03 ` Alex Deucher
0 siblings, 1 reply; 2+ messages in thread
From: Hariprasad Kelam @ 2019-08-05 17:21 UTC (permalink / raw)
To: Rex Zhu, Evan Quan, Alex Deucher, Christian König,
David (ChunMing) Zhou, David Airlie, Daniel Vetter, amd-gfx,
dri-devel, linux-kernel
Result of pointer airthmentic is never null
fix coverity defect:1451876
Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
---
drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c b/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
index ee739c0..a3acd77 100644
--- a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
+++ b/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
@@ -736,8 +736,6 @@ static int smu_v11_0_write_watermarks_table(struct smu_context *smu)
struct smu_table *table = NULL;
table = &smu_table->tables[SMU_TABLE_WATERMARKS];
- if (!table)
- return -EINVAL;
if (!table->cpu_addr)
return -EINVAL;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpu: drm: amd: powerplay: Remove logically dead code
2019-08-05 17:21 [PATCH] gpu: drm: amd: powerplay: Remove logically dead code Hariprasad Kelam
@ 2019-08-06 14:03 ` Alex Deucher
0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2019-08-06 14:03 UTC (permalink / raw)
To: Hariprasad Kelam
Cc: Rex Zhu, Evan Quan, Alex Deucher, Christian König,
David (ChunMing) Zhou, David Airlie, Daniel Vetter, amd-gfx list,
Maling list - DRI developers, LKML
On Mon, Aug 5, 2019 at 3:01 PM Hariprasad Kelam
<hariprasad.kelam@gmail.com> wrote:
>
> Result of pointer airthmentic is never null
>
> fix coverity defect:1451876
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Applied. thanks!
Alex
> ---
> drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c b/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
> index ee739c0..a3acd77 100644
> --- a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
> +++ b/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
> @@ -736,8 +736,6 @@ static int smu_v11_0_write_watermarks_table(struct smu_context *smu)
> struct smu_table *table = NULL;
>
> table = &smu_table->tables[SMU_TABLE_WATERMARKS];
> - if (!table)
> - return -EINVAL;
>
> if (!table->cpu_addr)
> return -EINVAL;
> --
> 2.7.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-06 14:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-05 17:21 [PATCH] gpu: drm: amd: powerplay: Remove logically dead code Hariprasad Kelam
2019-08-06 14:03 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).