linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Andy Gross <agross@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: [PATCH] soc: qcom: socinfo: Annotate switch cases with fall through
Date: Tue, 6 Aug 2019 19:18:38 -0700	[thread overview]
Message-ID: <20190807021838.GI30636@minitux> (raw)
In-Reply-To: <20190807115043.2ff429c1@canb.auug.org.au>

On Tue 06 Aug 18:50 PDT 2019, Stephen Rothwell wrote:

> Hi Bjorn,
> 
> On Tue,  6 Aug 2019 18:24:57 -0700 Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
> >
> >  				   qcom_socinfo->dbg_root,
> >  				   &qcom_socinfo->info.raw_device_num);
> > +		/* Fall through */
> >  	case SOCINFO_VERSION(0, 11):
> > +		/* Fall through */
> >  	case SOCINFO_VERSION(0, 10):
> > +		/* Fall through */
> >  	case SOCINFO_VERSION(0, 9):
> 
> I don't think you need the comment between consecutive "case"s - just
> where there is actual code.
> 

You're right, will respin the patch.

Thanks,
Bjorn

  reply	other threads:[~2019-08-07  2:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-07  0:08 linux-next: build warning after merge of the qcom tree Stephen Rothwell
2019-08-07  1:24 ` [PATCH] soc: qcom: socinfo: Annotate switch cases with fall through Bjorn Andersson
2019-08-07  1:40   ` Gustavo A. R. Silva
2019-08-07  1:50   ` Stephen Rothwell
2019-08-07  2:18     ` Bjorn Andersson [this message]
2019-08-07  2:23 ` [PATCH v2] " Bjorn Andersson
2019-08-07  4:25   ` Vaishali Thakkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190807021838.GI30636@minitux \
    --to=bjorn.andersson@linaro.org \
    --cc=agross@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).