From: Vaishali Thakkar <vaishali.thakkar@linaro.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: [PATCH v2] soc: qcom: socinfo: Annotate switch cases with fall through
Date: Wed, 7 Aug 2019 09:55:41 +0530 [thread overview]
Message-ID: <CANNG1HVRCfQPk4pP37SbEcR+_Upx7+N_SH95TYUxAhiB+jNLHg@mail.gmail.com> (raw)
In-Reply-To: <20190807022356.8502-1-bjorn.andersson@linaro.org>
On Wed, 7 Aug 2019 at 07:54, Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
>
> Introduce fall through annotations in the switch statements of
> socinfo_debugfs_init() to silence compiler warnings.
Oops, I missed this. Thanks for fixing it!
> Fixes: 9c84c1e78634 ("soc: qcom: socinfo: Expose custom attributes")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Acked-by: Vaishali Thakkar <vaishali.thakkar@linaro.org>
> ---
> drivers/soc/qcom/socinfo.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
> index 855353bed19e..a39ea5061dc5 100644
> --- a/drivers/soc/qcom/socinfo.c
> +++ b/drivers/soc/qcom/socinfo.c
> @@ -323,6 +323,7 @@ static void socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo,
> debugfs_create_x32("raw_device_number", 0400,
> qcom_socinfo->dbg_root,
> &qcom_socinfo->info.raw_device_num);
> + /* Fall through */
> case SOCINFO_VERSION(0, 11):
> case SOCINFO_VERSION(0, 10):
> case SOCINFO_VERSION(0, 9):
> @@ -330,10 +331,12 @@ static void socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo,
>
> debugfs_create_u32("foundry_id", 0400, qcom_socinfo->dbg_root,
> &qcom_socinfo->info.foundry_id);
> + /* Fall through */
> case SOCINFO_VERSION(0, 8):
> case SOCINFO_VERSION(0, 7):
> DEBUGFS_ADD(info, pmic_model);
> DEBUGFS_ADD(info, pmic_die_rev);
> + /* Fall through */
> case SOCINFO_VERSION(0, 6):
> qcom_socinfo->info.hw_plat_subtype =
> __le32_to_cpu(info->hw_plat_subtype);
> @@ -341,6 +344,7 @@ static void socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo,
> debugfs_create_u32("hardware_platform_subtype", 0400,
> qcom_socinfo->dbg_root,
> &qcom_socinfo->info.hw_plat_subtype);
> + /* Fall through */
> case SOCINFO_VERSION(0, 5):
> qcom_socinfo->info.accessory_chip =
> __le32_to_cpu(info->accessory_chip);
> @@ -348,23 +352,27 @@ static void socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo,
> debugfs_create_u32("accessory_chip", 0400,
> qcom_socinfo->dbg_root,
> &qcom_socinfo->info.accessory_chip);
> + /* Fall through */
> case SOCINFO_VERSION(0, 4):
> qcom_socinfo->info.plat_ver = __le32_to_cpu(info->plat_ver);
>
> debugfs_create_u32("platform_version", 0400,
> qcom_socinfo->dbg_root,
> &qcom_socinfo->info.plat_ver);
> + /* Fall through */
> case SOCINFO_VERSION(0, 3):
> qcom_socinfo->info.hw_plat = __le32_to_cpu(info->hw_plat);
>
> debugfs_create_u32("hardware_platform", 0400,
> qcom_socinfo->dbg_root,
> &qcom_socinfo->info.hw_plat);
> + /* Fall through */
> case SOCINFO_VERSION(0, 2):
> qcom_socinfo->info.raw_ver = __le32_to_cpu(info->raw_ver);
>
> debugfs_create_u32("raw_version", 0400, qcom_socinfo->dbg_root,
> &qcom_socinfo->info.raw_ver);
> + /* Fall through */
> case SOCINFO_VERSION(0, 1):
> DEBUGFS_ADD(info, build_id);
> break;
> --
> 2.18.0
>
prev parent reply other threads:[~2019-08-07 4:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 0:08 linux-next: build warning after merge of the qcom tree Stephen Rothwell
2019-08-07 1:24 ` [PATCH] soc: qcom: socinfo: Annotate switch cases with fall through Bjorn Andersson
2019-08-07 1:40 ` Gustavo A. R. Silva
2019-08-07 1:50 ` Stephen Rothwell
2019-08-07 2:18 ` Bjorn Andersson
2019-08-07 2:23 ` [PATCH v2] " Bjorn Andersson
2019-08-07 4:25 ` Vaishali Thakkar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANNG1HVRCfQPk4pP37SbEcR+_Upx7+N_SH95TYUxAhiB+jNLHg@mail.gmail.com \
--to=vaishali.thakkar@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).