* [PATCH] riscv: delay: use do_div() instead of __udivdi3()
@ 2019-08-07 2:07 Paul Walmsley
2019-08-07 6:48 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Paul Walmsley @ 2019-08-07 2:07 UTC (permalink / raw)
To: linux-riscv; +Cc: linux-kernel
In preparation for removing __udivdi3() from the RISC-V
architecture-specific files, convert its one user to use do_div().
This avoids breaking the RV32 build after __udivdi3() is removed.
Signed-off-by: Paul Walmsley <paul.walmsley@sifive.com>
---
arch/riscv/lib/delay.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/arch/riscv/lib/delay.c b/arch/riscv/lib/delay.c
index 87ff89e88f2c..8c686934e0f6 100644
--- a/arch/riscv/lib/delay.c
+++ b/arch/riscv/lib/delay.c
@@ -81,9 +81,14 @@ EXPORT_SYMBOL(__delay);
void udelay(unsigned long usecs)
{
u64 ucycles = (u64)usecs * lpj_fine * UDELAY_MULT;
+ u64 n;
+ u32 rem;
if (unlikely(usecs > MAX_UDELAY_US)) {
- __delay((u64)usecs * riscv_timebase / 1000000ULL);
+ n = (u64)usecs * riscv_timebase;
+ rem = do_div(n, 1000000);
+
+ __delay(n);
return;
}
--
2.22.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] riscv: delay: use do_div() instead of __udivdi3()
2019-08-07 2:07 [PATCH] riscv: delay: use do_div() instead of __udivdi3() Paul Walmsley
@ 2019-08-07 6:48 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2019-08-07 6:48 UTC (permalink / raw)
To: Paul Walmsley; +Cc: linux-riscv, linux-kernel
> diff --git a/arch/riscv/lib/delay.c b/arch/riscv/lib/delay.c
> index 87ff89e88f2c..8c686934e0f6 100644
> --- a/arch/riscv/lib/delay.c
> +++ b/arch/riscv/lib/delay.c
> @@ -81,9 +81,14 @@ EXPORT_SYMBOL(__delay);
> void udelay(unsigned long usecs)
> {
> u64 ucycles = (u64)usecs * lpj_fine * UDELAY_MULT;
> + u64 n;
> + u32 rem;
>
> if (unlikely(usecs > MAX_UDELAY_US)) {
> - __delay((u64)usecs * riscv_timebase / 1000000ULL);
> + n = (u64)usecs * riscv_timebase;
> + rem = do_div(n, 1000000);
> +
> + __delay(n);
> return;
A few comments on the variable usage:
I think you really want a variable of type u64 that contains the usecs
value instead of casting it three times.
n and rem can be easily declared inside the branch.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-07 6:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-07 2:07 [PATCH] riscv: delay: use do_div() instead of __udivdi3() Paul Walmsley
2019-08-07 6:48 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).