From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Philippe Schenker <philippe.schenker@toradex.com>
Cc: "Marcel Ziswiler" <marcel.ziswiler@toradex.com>,
"Max Krummenacher" <max.krummenacher@toradex.com>,
"stefan@agner.ch" <stefan@agner.ch>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Shawn Guo" <shawnguo@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Michal Vokáč" <michal.vokac@ysoft.com>,
"Fabio Estevam" <festevam@gmail.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 09/21] ARM: dts: imx6qdl-colibri: add phy to fec
Date: Wed, 7 Aug 2019 12:51:07 +0200 [thread overview]
Message-ID: <20190807105107.nqqltv64tjxprow6@pengutronix.de> (raw)
In-Reply-To: <20190807082556.5013-10-philippe.schenker@toradex.com>
On Wed, Aug 07, 2019 at 08:26:23AM +0000, Philippe Schenker wrote:
> Add the phy-node and mdio bus to the fec-node, represented as is on
> hardware.
> This commit includes micrel,led-mode that is set to the default
> value, prepared for someone who wants to change this.
>
> Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
> ---
>
> Changes in v3: None
> Changes in v2: None
>
> arch/arm/boot/dts/imx6qdl-colibri.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-colibri.dtsi b/arch/arm/boot/dts/imx6qdl-colibri.dtsi
> index 1beac22266ed..019dda6b88ad 100644
> --- a/arch/arm/boot/dts/imx6qdl-colibri.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-colibri.dtsi
> @@ -140,7 +140,18 @@
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_enet>;
> phy-mode = "rmii";
> + phy-handle = <ðphy>;
> status = "okay";
> +
> + mdio {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + ethphy: ethernet-phy@0 {
> + reg = <0>;
> + micrel,led-mode = <0>;
Doesn't that need a compatible entry to be actually used?
Best regards
Uwe
>
>
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2019-08-07 10:51 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 8:26 [PATCH v3 00/21] Common patches from downstream development Philippe Schenker
2019-08-07 8:26 ` [PATCH v3 01/21] ARM: dts: imx7-colibri: make sure module supplies are always on Philippe Schenker
2019-08-07 8:26 ` [PATCH v3 02/21] ARM: dts: imx7-colibri: disable HS400 Philippe Schenker
2019-08-09 14:05 ` Marcel Ziswiler
2019-08-07 8:26 ` [PATCH v3 03/21] ARM: dts: imx7-colibri: prepare module device tree for FlexCAN Philippe Schenker
2019-08-09 14:07 ` Marcel Ziswiler
2019-08-07 8:26 ` [PATCH v3 04/21] ARM: dts: imx7-colibri: Add sleep mode to ethernet Philippe Schenker
2019-08-09 14:20 ` Marcel Ziswiler
2019-08-07 8:26 ` [PATCH v3 05/21] ARM: dts: add recovery for I2C for iMX7 Philippe Schenker
2019-08-09 14:45 ` Marcel Ziswiler
2019-08-10 21:58 ` [PATCH] ARM: dts: imx7d: sbc-iot-imx7: add recovery for i2c3/4 André Draszik
2019-08-12 8:50 ` Philippe Schenker
2019-08-12 9:15 ` [PATCH v3 05/21] ARM: dts: add recovery for I2C for iMX7 Michal Vokáč
2019-08-12 10:59 ` Philippe Schenker
2019-08-07 8:26 ` [PATCH v3 06/21] ARM: dts: imx7-colibri: add GPIO wakeup key Philippe Schenker
2019-08-09 14:46 ` Marcel Ziswiler
2019-08-07 8:26 ` [PATCH v3 07/21] ARM: dts: imx7-colibri: fix 1.8V/UHS support Philippe Schenker
2019-08-07 11:19 ` Fabio Estevam
2019-08-07 13:41 ` Philippe Schenker
2019-08-09 14:48 ` Marcel Ziswiler
2019-08-07 8:26 ` [PATCH v3 08/21] ARM: dts: imx7-colibri: Add touch controllers Philippe Schenker
2019-08-09 14:56 ` Marcel Ziswiler
2019-08-07 8:26 ` [PATCH v3 09/21] ARM: dts: imx6qdl-colibri: add phy to fec Philippe Schenker
2019-08-07 10:51 ` Uwe Kleine-König [this message]
2019-08-08 8:03 ` Philippe Schenker
2019-08-09 14:59 ` Marcel Ziswiler
2019-08-07 8:26 ` [PATCH v3 10/21] ARM: dts: imx6qdl-colibri: Add missing pin declaration in iomuxc Philippe Schenker
2019-08-09 15:00 ` Marcel Ziswiler
2019-08-07 8:26 ` [PATCH v3 11/21] ARM: dts: imx6qdl-apalis: Add sleep state to can interfaces Philippe Schenker
2019-08-09 15:02 ` Marcel Ziswiler
2019-08-07 8:26 ` [PATCH v3 12/21] ARM: dts: imx6-apalis: Add touchscreens used on Toradex eval boards Philippe Schenker
2019-08-09 15:35 ` Marcel Ziswiler
2019-08-07 8:26 ` [PATCH v3 13/21] ARM: dts: imx6-colibri: Add missing pinmuxing to Toradex eval board Philippe Schenker
2019-08-09 15:36 ` Marcel Ziswiler
2019-08-07 8:26 ` [PATCH v3 14/21] ARM: dts: imx6ull-colibri: Add sleep mode to fec Philippe Schenker
2019-08-09 15:38 ` Marcel Ziswiler
2019-08-07 8:26 ` [PATCH v3 15/21] ARM: dts: imx6ull-colibri: reduce v_batt current in power off Philippe Schenker
2019-08-09 15:40 ` Marcel Ziswiler
2019-08-07 8:26 ` [PATCH v3 16/21] ARM: dts: imx6ull-colibri: Add watchdog Philippe Schenker
2019-08-09 15:43 ` Marcel Ziswiler
2019-08-07 8:26 ` [PATCH v3 17/21] ARM: dts: imx6ull: improve can templates Philippe Schenker
2019-08-09 15:47 ` Marcel Ziswiler
2019-08-12 8:54 ` Philippe Schenker
2019-08-07 8:26 ` [PATCH v3 18/21] ARM: dts: imx6ull-colibri: Add general wakeup key used on Colibri Philippe Schenker
2019-08-09 15:48 ` Marcel Ziswiler
2019-08-07 8:26 ` [PATCH v3 19/21] ARM: dts: imx6/7-colibri: switch dr_mode to otg Philippe Schenker
2019-08-09 15:50 ` Marcel Ziswiler
2019-08-12 12:53 ` Philippe Schenker
2019-08-07 8:26 ` [PATCH v3 20/21] ARM: dts: imx6ull-colibri: Add touchscreen used with Eval Board Philippe Schenker
2019-08-09 15:54 ` Marcel Ziswiler
2019-08-12 13:14 ` Philippe Schenker
2019-08-07 8:26 ` [PATCH v3 21/21] ARM: dts: imx7-colibri: Add UHS support to eval board Philippe Schenker
2019-08-09 15:56 ` Marcel Ziswiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190807105107.nqqltv64tjxprow6@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=mark.rutland@arm.com \
--cc=max.krummenacher@toradex.com \
--cc=michal.vokac@ysoft.com \
--cc=philippe.schenker@toradex.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).