From: "Michal Vokáč" <michal.vokac@ysoft.com>
To: Philippe Schenker <philippe.schenker@toradex.com>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Max Krummenacher <max.krummenacher@toradex.com>,
"stefan@agner.ch" <stefan@agner.ch>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Fabio Estevam <festevam@gmail.com>
Cc: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>
Subject: Re: [PATCH v3 05/21] ARM: dts: add recovery for I2C for iMX7
Date: Mon, 12 Aug 2019 11:15:44 +0200 [thread overview]
Message-ID: <cd0da6ed-6b59-be60-34b2-74eb603aa10d@ysoft.com> (raw)
In-Reply-To: <20190807082556.5013-6-philippe.schenker@toradex.com>
On 07. 08. 19 10:26, Philippe Schenker wrote:
> From: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
>
> - add recovery mode for applicable i2c buses for
> Colibri iMX7 module.
>
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
> Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
> ---
Hi Philippe,
since you are going to send v4 anyway I suggest you update the subject
to be consistent across all the patches.
"ARM: dts: imx7-colibri: add recovery for I2C for iMX7"
fits better I think.
Thank you,
Michal
>
> Changes in v3: None
> Changes in v2: None
>
> arch/arm/boot/dts/imx7-colibri.dtsi | 25 +++++++++++++++++++++++--
> 1 file changed, 23 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi b/arch/arm/boot/dts/imx7-colibri.dtsi
> index a8d992f3e897..2480623c92ff 100644
> --- a/arch/arm/boot/dts/imx7-colibri.dtsi
> +++ b/arch/arm/boot/dts/imx7-colibri.dtsi
> @@ -140,8 +140,12 @@
>
> &i2c1 {
> clock-frequency = <100000>;
> - pinctrl-names = "default";
> + pinctrl-names = "default", "gpio";
> pinctrl-0 = <&pinctrl_i2c1 &pinctrl_i2c1_int>;
> + pinctrl-1 = <&pinctrl_i2c1_recovery &pinctrl_i2c1_int>;
> + scl-gpios = <&gpio1 4 GPIO_ACTIVE_HIGH>;
> + sda-gpios = <&gpio1 5 GPIO_ACTIVE_HIGH>;
> +
> status = "okay";
>
> codec: sgtl5000@a {
> @@ -242,8 +246,11 @@
>
> &i2c4 {
> clock-frequency = <100000>;
> - pinctrl-names = "default";
> + pinctrl-names = "default", "gpio";
> pinctrl-0 = <&pinctrl_i2c4>;
> + pinctrl-1 = <&pinctrl_i2c4_recovery>;
> + scl-gpios = <&gpio7 8 GPIO_ACTIVE_HIGH>;
> + sda-gpios = <&gpio7 9 GPIO_ACTIVE_HIGH>;
> };
>
> &lcdif {
> @@ -540,6 +547,13 @@
> >;
> };
>
> + pinctrl_i2c4_recovery: i2c4-recoverygrp {
> + fsl,pins = <
> + MX7D_PAD_ENET1_RGMII_TD2__GPIO7_IO8 0x4000007f
> + MX7D_PAD_ENET1_RGMII_TD3__GPIO7_IO9 0x4000007f
> + >;
> + };
> +
> pinctrl_lcdif_dat: lcdif-dat-grp {
> fsl,pins = <
> MX7D_PAD_LCD_DATA00__LCD_DATA0 0x79
> @@ -740,6 +754,13 @@
> >;
> };
>
> + pinctrl_i2c1_recovery: i2c1-recoverygrp {
> + fsl,pins = <
> + MX7D_PAD_LPSR_GPIO1_IO04__GPIO1_IO4 0x4000007f
> + MX7D_PAD_LPSR_GPIO1_IO05__GPIO1_IO5 0x4000007f
> + >;
> + };
> +
> pinctrl_cd_usdhc1: usdhc1-cd-grp {
> fsl,pins = <
> MX7D_PAD_LPSR_GPIO1_IO00__GPIO1_IO0 0x59 /* CD */
>
next prev parent reply other threads:[~2019-08-12 9:15 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 8:26 [PATCH v3 00/21] Common patches from downstream development Philippe Schenker
2019-08-07 8:26 ` [PATCH v3 01/21] ARM: dts: imx7-colibri: make sure module supplies are always on Philippe Schenker
2019-08-07 8:26 ` [PATCH v3 02/21] ARM: dts: imx7-colibri: disable HS400 Philippe Schenker
2019-08-09 14:05 ` Marcel Ziswiler
2019-08-07 8:26 ` [PATCH v3 03/21] ARM: dts: imx7-colibri: prepare module device tree for FlexCAN Philippe Schenker
2019-08-09 14:07 ` Marcel Ziswiler
2019-08-07 8:26 ` [PATCH v3 04/21] ARM: dts: imx7-colibri: Add sleep mode to ethernet Philippe Schenker
2019-08-09 14:20 ` Marcel Ziswiler
2019-08-07 8:26 ` [PATCH v3 05/21] ARM: dts: add recovery for I2C for iMX7 Philippe Schenker
2019-08-09 14:45 ` Marcel Ziswiler
2019-08-10 21:58 ` [PATCH] ARM: dts: imx7d: sbc-iot-imx7: add recovery for i2c3/4 André Draszik
2019-08-12 8:50 ` Philippe Schenker
2019-08-12 9:15 ` Michal Vokáč [this message]
2019-08-12 10:59 ` [PATCH v3 05/21] ARM: dts: add recovery for I2C for iMX7 Philippe Schenker
2019-08-07 8:26 ` [PATCH v3 06/21] ARM: dts: imx7-colibri: add GPIO wakeup key Philippe Schenker
2019-08-09 14:46 ` Marcel Ziswiler
2019-08-07 8:26 ` [PATCH v3 07/21] ARM: dts: imx7-colibri: fix 1.8V/UHS support Philippe Schenker
2019-08-07 11:19 ` Fabio Estevam
2019-08-07 13:41 ` Philippe Schenker
2019-08-09 14:48 ` Marcel Ziswiler
2019-08-07 8:26 ` [PATCH v3 08/21] ARM: dts: imx7-colibri: Add touch controllers Philippe Schenker
2019-08-09 14:56 ` Marcel Ziswiler
2019-08-07 8:26 ` [PATCH v3 09/21] ARM: dts: imx6qdl-colibri: add phy to fec Philippe Schenker
2019-08-07 10:51 ` Uwe Kleine-König
2019-08-08 8:03 ` Philippe Schenker
2019-08-09 14:59 ` Marcel Ziswiler
2019-08-07 8:26 ` [PATCH v3 10/21] ARM: dts: imx6qdl-colibri: Add missing pin declaration in iomuxc Philippe Schenker
2019-08-09 15:00 ` Marcel Ziswiler
2019-08-07 8:26 ` [PATCH v3 11/21] ARM: dts: imx6qdl-apalis: Add sleep state to can interfaces Philippe Schenker
2019-08-09 15:02 ` Marcel Ziswiler
2019-08-07 8:26 ` [PATCH v3 12/21] ARM: dts: imx6-apalis: Add touchscreens used on Toradex eval boards Philippe Schenker
2019-08-09 15:35 ` Marcel Ziswiler
2019-08-07 8:26 ` [PATCH v3 13/21] ARM: dts: imx6-colibri: Add missing pinmuxing to Toradex eval board Philippe Schenker
2019-08-09 15:36 ` Marcel Ziswiler
2019-08-07 8:26 ` [PATCH v3 14/21] ARM: dts: imx6ull-colibri: Add sleep mode to fec Philippe Schenker
2019-08-09 15:38 ` Marcel Ziswiler
2019-08-07 8:26 ` [PATCH v3 15/21] ARM: dts: imx6ull-colibri: reduce v_batt current in power off Philippe Schenker
2019-08-09 15:40 ` Marcel Ziswiler
2019-08-07 8:26 ` [PATCH v3 16/21] ARM: dts: imx6ull-colibri: Add watchdog Philippe Schenker
2019-08-09 15:43 ` Marcel Ziswiler
2019-08-07 8:26 ` [PATCH v3 17/21] ARM: dts: imx6ull: improve can templates Philippe Schenker
2019-08-09 15:47 ` Marcel Ziswiler
2019-08-12 8:54 ` Philippe Schenker
2019-08-07 8:26 ` [PATCH v3 18/21] ARM: dts: imx6ull-colibri: Add general wakeup key used on Colibri Philippe Schenker
2019-08-09 15:48 ` Marcel Ziswiler
2019-08-07 8:26 ` [PATCH v3 19/21] ARM: dts: imx6/7-colibri: switch dr_mode to otg Philippe Schenker
2019-08-09 15:50 ` Marcel Ziswiler
2019-08-12 12:53 ` Philippe Schenker
2019-08-07 8:26 ` [PATCH v3 20/21] ARM: dts: imx6ull-colibri: Add touchscreen used with Eval Board Philippe Schenker
2019-08-09 15:54 ` Marcel Ziswiler
2019-08-12 13:14 ` Philippe Schenker
2019-08-07 8:26 ` [PATCH v3 21/21] ARM: dts: imx7-colibri: Add UHS support to eval board Philippe Schenker
2019-08-09 15:56 ` Marcel Ziswiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd0da6ed-6b59-be60-34b2-74eb603aa10d@ysoft.com \
--to=michal.vokac@ysoft.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=mark.rutland@arm.com \
--cc=max.krummenacher@toradex.com \
--cc=oleksandr.suvorov@toradex.com \
--cc=philippe.schenker@toradex.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).