* [PATCH] team: Add vlan tx offload to hw_enc_features
@ 2019-08-07 2:38 YueHaibing
2019-08-08 5:48 ` Jesse Brandeburg
2019-08-08 6:22 ` [PATCH v2] " YueHaibing
0 siblings, 2 replies; 4+ messages in thread
From: YueHaibing @ 2019-08-07 2:38 UTC (permalink / raw)
To: j.vosburgh, vfalico, andy, davem, jiri, jay.vosburgh
Cc: linux-kernel, netdev, YueHaibing
We should also enable bonding's vlan tx offload in hw_enc_features,
pass the vlan packets to the slave devices with vlan tci, let them
to handle vlan tunneling offload implementation.
Fixes: 3268e5cb494d ("team: Advertise tunneling offload features")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/team/team.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
index abfa0da..e8089de 100644
--- a/drivers/net/team/team.c
+++ b/drivers/net/team/team.c
@@ -1004,6 +1004,8 @@ static void __team_compute_features(struct team *team)
team->dev->vlan_features = vlan_features;
team->dev->hw_enc_features = enc_features | NETIF_F_GSO_ENCAP_ALL |
+ NETIF_F_HW_VLAN_CTAG_TX |
+ NETIF_F_HW_VLAN_STAG_TX |
NETIF_F_GSO_UDP_L4;
team->dev->hard_header_len = max_hard_header_len;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] team: Add vlan tx offload to hw_enc_features
2019-08-07 2:38 [PATCH] team: Add vlan tx offload to hw_enc_features YueHaibing
@ 2019-08-08 5:48 ` Jesse Brandeburg
2019-08-08 6:22 ` [PATCH v2] " YueHaibing
1 sibling, 0 replies; 4+ messages in thread
From: Jesse Brandeburg @ 2019-08-08 5:48 UTC (permalink / raw)
To: YueHaibing
Cc: j.vosburgh, vfalico, andy, davem, jiri, jay.vosburgh,
linux-kernel, netdev, jesse.brandeburg
On Wed, 7 Aug 2019 10:38:08 +0800
YueHaibing <yuehaibing@huawei.com> wrote:
> We should also enable bonding's vlan tx offload in hw_enc_features,
You mean team's vlan tx offload?
> pass the vlan packets to the slave devices with vlan tci, let them
s/let them to/let the slave/
> to handle vlan tunneling offload implementation.
>
> Fixes: 3268e5cb494d ("team: Advertise tunneling offload features")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] team: Add vlan tx offload to hw_enc_features
2019-08-07 2:38 [PATCH] team: Add vlan tx offload to hw_enc_features YueHaibing
2019-08-08 5:48 ` Jesse Brandeburg
@ 2019-08-08 6:22 ` YueHaibing
2019-08-09 5:42 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: YueHaibing @ 2019-08-08 6:22 UTC (permalink / raw)
To: j.vosburgh, vfalico, andy, davem, jiri, jay.vosburgh
Cc: linux-kernel, netdev, YueHaibing
We should also enable team's vlan tx offload in hw_enc_features,
pass the vlan packets to the slave devices with vlan tci, let the
slave handle vlan tunneling offload implementation.
Fixes: 3268e5cb494d ("team: Advertise tunneling offload features")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
v2: fix commit log typo
---
drivers/net/team/team.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
index abfa0da..e8089de 100644
--- a/drivers/net/team/team.c
+++ b/drivers/net/team/team.c
@@ -1004,6 +1004,8 @@ static void __team_compute_features(struct team *team)
team->dev->vlan_features = vlan_features;
team->dev->hw_enc_features = enc_features | NETIF_F_GSO_ENCAP_ALL |
+ NETIF_F_HW_VLAN_CTAG_TX |
+ NETIF_F_HW_VLAN_STAG_TX |
NETIF_F_GSO_UDP_L4;
team->dev->hard_header_len = max_hard_header_len;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] team: Add vlan tx offload to hw_enc_features
2019-08-08 6:22 ` [PATCH v2] " YueHaibing
@ 2019-08-09 5:42 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2019-08-09 5:42 UTC (permalink / raw)
To: yuehaibing
Cc: j.vosburgh, vfalico, andy, jiri, jay.vosburgh, linux-kernel, netdev
From: YueHaibing <yuehaibing@huawei.com>
Date: Thu, 8 Aug 2019 14:22:47 +0800
> We should also enable team's vlan tx offload in hw_enc_features,
> pass the vlan packets to the slave devices with vlan tci, let the
> slave handle vlan tunneling offload implementation.
>
> Fixes: 3268e5cb494d ("team: Advertise tunneling offload features")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> v2: fix commit log typo
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-08-09 5:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-07 2:38 [PATCH] team: Add vlan tx offload to hw_enc_features YueHaibing
2019-08-08 5:48 ` Jesse Brandeburg
2019-08-08 6:22 ` [PATCH v2] " YueHaibing
2019-08-09 5:42 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).