* [PATCH] soundwire: fix regmap dependencies and align with other serial links
@ 2019-07-18 23:02 Pierre-Louis Bossart
2019-07-19 9:04 ` Rafael J. Wysocki
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Pierre-Louis Bossart @ 2019-07-18 23:02 UTC (permalink / raw)
To: alsa-devel
Cc: linux-kernel, tiwai, broonie, vkoul, gregkh, jank,
srinivas.kandagatla, Pierre-Louis Bossart, Rafael J. Wysocki,
Sanyog Kale
The existing code has a mixed select/depend usage which makes no sense.
config SOUNDWIRE_BUS
tristate
select REGMAP_SOUNDWIRE
config REGMAP_SOUNDWIRE
tristate
depends on SOUNDWIRE_BUS
Let's remove one layer of Kconfig definitions and align with the
solutions used by all other serial links.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
drivers/base/regmap/Kconfig | 2 +-
drivers/soundwire/Kconfig | 7 +------
drivers/soundwire/Makefile | 2 +-
3 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig
index 6ad5ef48b61e..8cd2ac650b50 100644
--- a/drivers/base/regmap/Kconfig
+++ b/drivers/base/regmap/Kconfig
@@ -44,7 +44,7 @@ config REGMAP_IRQ
config REGMAP_SOUNDWIRE
tristate
- depends on SOUNDWIRE_BUS
+ depends on SOUNDWIRE
config REGMAP_SCCB
tristate
diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
index 3a01cfd70fdc..f518273cfbe3 100644
--- a/drivers/soundwire/Kconfig
+++ b/drivers/soundwire/Kconfig
@@ -4,7 +4,7 @@
#
menuconfig SOUNDWIRE
- bool "SoundWire support"
+ tristate "SoundWire support"
help
SoundWire is a 2-Pin interface with data and clock line ratified
by the MIPI Alliance. SoundWire is used for transporting data
@@ -17,17 +17,12 @@ if SOUNDWIRE
comment "SoundWire Devices"
-config SOUNDWIRE_BUS
- tristate
- select REGMAP_SOUNDWIRE
-
config SOUNDWIRE_CADENCE
tristate
config SOUNDWIRE_INTEL
tristate "Intel SoundWire Master driver"
select SOUNDWIRE_CADENCE
- select SOUNDWIRE_BUS
depends on X86 && ACPI && SND_SOC
help
SoundWire Intel Master driver.
diff --git a/drivers/soundwire/Makefile b/drivers/soundwire/Makefile
index fd99a831b92a..45b7e5001653 100644
--- a/drivers/soundwire/Makefile
+++ b/drivers/soundwire/Makefile
@@ -5,7 +5,7 @@
#Bus Objs
soundwire-bus-objs := bus_type.o bus.o slave.o mipi_disco.o stream.o
-obj-$(CONFIG_SOUNDWIRE_BUS) += soundwire-bus.o
+obj-$(CONFIG_SOUNDWIRE) += soundwire-bus.o
#Cadence Objs
soundwire-cadence-objs := cadence_master.o
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] soundwire: fix regmap dependencies and align with other serial links
2019-07-18 23:02 [PATCH] soundwire: fix regmap dependencies and align with other serial links Pierre-Louis Bossart
@ 2019-07-19 9:04 ` Rafael J. Wysocki
2019-08-07 15:09 ` [alsa-devel] " Pierre-Louis Bossart
2019-08-08 13:48 ` Srinivas Kandagatla
2019-08-09 4:51 ` Vinod Koul
2 siblings, 1 reply; 8+ messages in thread
From: Rafael J. Wysocki @ 2019-07-19 9:04 UTC (permalink / raw)
To: Pierre-Louis Bossart
Cc: moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
Linux Kernel Mailing List, Takashi Iwai, Mark Brown, Vinod Koul,
Greg Kroah-Hartman, jank, Srini Kandagatla, Rafael J. Wysocki,
Sanyog Kale
On Fri, Jul 19, 2019 at 1:02 AM Pierre-Louis Bossart
<pierre-louis.bossart@linux.intel.com> wrote:
>
> The existing code has a mixed select/depend usage which makes no sense.
>
> config SOUNDWIRE_BUS
> tristate
> select REGMAP_SOUNDWIRE
>
> config REGMAP_SOUNDWIRE
> tristate
> depends on SOUNDWIRE_BUS
>
> Let's remove one layer of Kconfig definitions and align with the
> solutions used by all other serial links.
>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
No issues found:
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> drivers/base/regmap/Kconfig | 2 +-
> drivers/soundwire/Kconfig | 7 +------
> drivers/soundwire/Makefile | 2 +-
> 3 files changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig
> index 6ad5ef48b61e..8cd2ac650b50 100644
> --- a/drivers/base/regmap/Kconfig
> +++ b/drivers/base/regmap/Kconfig
> @@ -44,7 +44,7 @@ config REGMAP_IRQ
>
> config REGMAP_SOUNDWIRE
> tristate
> - depends on SOUNDWIRE_BUS
> + depends on SOUNDWIRE
>
> config REGMAP_SCCB
> tristate
> diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
> index 3a01cfd70fdc..f518273cfbe3 100644
> --- a/drivers/soundwire/Kconfig
> +++ b/drivers/soundwire/Kconfig
> @@ -4,7 +4,7 @@
> #
>
> menuconfig SOUNDWIRE
> - bool "SoundWire support"
> + tristate "SoundWire support"
> help
> SoundWire is a 2-Pin interface with data and clock line ratified
> by the MIPI Alliance. SoundWire is used for transporting data
> @@ -17,17 +17,12 @@ if SOUNDWIRE
>
> comment "SoundWire Devices"
>
> -config SOUNDWIRE_BUS
> - tristate
> - select REGMAP_SOUNDWIRE
> -
> config SOUNDWIRE_CADENCE
> tristate
>
> config SOUNDWIRE_INTEL
> tristate "Intel SoundWire Master driver"
> select SOUNDWIRE_CADENCE
> - select SOUNDWIRE_BUS
> depends on X86 && ACPI && SND_SOC
> help
> SoundWire Intel Master driver.
> diff --git a/drivers/soundwire/Makefile b/drivers/soundwire/Makefile
> index fd99a831b92a..45b7e5001653 100644
> --- a/drivers/soundwire/Makefile
> +++ b/drivers/soundwire/Makefile
> @@ -5,7 +5,7 @@
>
> #Bus Objs
> soundwire-bus-objs := bus_type.o bus.o slave.o mipi_disco.o stream.o
> -obj-$(CONFIG_SOUNDWIRE_BUS) += soundwire-bus.o
> +obj-$(CONFIG_SOUNDWIRE) += soundwire-bus.o
>
> #Cadence Objs
> soundwire-cadence-objs := cadence_master.o
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [alsa-devel] [PATCH] soundwire: fix regmap dependencies and align with other serial links
2019-07-19 9:04 ` Rafael J. Wysocki
@ 2019-08-07 15:09 ` Pierre-Louis Bossart
2019-08-07 17:56 ` Mark Brown
0 siblings, 1 reply; 8+ messages in thread
From: Pierre-Louis Bossart @ 2019-08-07 15:09 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
Takashi Iwai, Greg Kroah-Hartman, Linux Kernel Mailing List,
Vinod Koul, Mark Brown, Srini Kandagatla, jank, Sanyog Kale
On 7/19/19 4:04 AM, Rafael J. Wysocki wrote:
> On Fri, Jul 19, 2019 at 1:02 AM Pierre-Louis Bossart
> <pierre-louis.bossart@linux.intel.com> wrote:
>>
>> The existing code has a mixed select/depend usage which makes no sense.
>>
>> config SOUNDWIRE_BUS
>> tristate
>> select REGMAP_SOUNDWIRE
>>
>> config REGMAP_SOUNDWIRE
>> tristate
>> depends on SOUNDWIRE_BUS
>>
>> Let's remove one layer of Kconfig definitions and align with the
>> solutions used by all other serial links.
>>
>> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>
> No issues found:
>
> Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Vinod, Mark, any feedback?
There will be a set of SoundWire codec drivers provided upstream soonish
and we'll get a number of kbuild errors without this patch.
>
>> ---
>> drivers/base/regmap/Kconfig | 2 +-
>> drivers/soundwire/Kconfig | 7 +------
>> drivers/soundwire/Makefile | 2 +-
>> 3 files changed, 3 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig
>> index 6ad5ef48b61e..8cd2ac650b50 100644
>> --- a/drivers/base/regmap/Kconfig
>> +++ b/drivers/base/regmap/Kconfig
>> @@ -44,7 +44,7 @@ config REGMAP_IRQ
>>
>> config REGMAP_SOUNDWIRE
>> tristate
>> - depends on SOUNDWIRE_BUS
>> + depends on SOUNDWIRE
>>
>> config REGMAP_SCCB
>> tristate
>> diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
>> index 3a01cfd70fdc..f518273cfbe3 100644
>> --- a/drivers/soundwire/Kconfig
>> +++ b/drivers/soundwire/Kconfig
>> @@ -4,7 +4,7 @@
>> #
>>
>> menuconfig SOUNDWIRE
>> - bool "SoundWire support"
>> + tristate "SoundWire support"
>> help
>> SoundWire is a 2-Pin interface with data and clock line ratified
>> by the MIPI Alliance. SoundWire is used for transporting data
>> @@ -17,17 +17,12 @@ if SOUNDWIRE
>>
>> comment "SoundWire Devices"
>>
>> -config SOUNDWIRE_BUS
>> - tristate
>> - select REGMAP_SOUNDWIRE
>> -
>> config SOUNDWIRE_CADENCE
>> tristate
>>
>> config SOUNDWIRE_INTEL
>> tristate "Intel SoundWire Master driver"
>> select SOUNDWIRE_CADENCE
>> - select SOUNDWIRE_BUS
>> depends on X86 && ACPI && SND_SOC
>> help
>> SoundWire Intel Master driver.
>> diff --git a/drivers/soundwire/Makefile b/drivers/soundwire/Makefile
>> index fd99a831b92a..45b7e5001653 100644
>> --- a/drivers/soundwire/Makefile
>> +++ b/drivers/soundwire/Makefile
>> @@ -5,7 +5,7 @@
>>
>> #Bus Objs
>> soundwire-bus-objs := bus_type.o bus.o slave.o mipi_disco.o stream.o
>> -obj-$(CONFIG_SOUNDWIRE_BUS) += soundwire-bus.o
>> +obj-$(CONFIG_SOUNDWIRE) += soundwire-bus.o
>>
>> #Cadence Objs
>> soundwire-cadence-objs := cadence_master.o
>> --
>> 2.20.1
>>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [alsa-devel] [PATCH] soundwire: fix regmap dependencies and align with other serial links
2019-08-07 15:09 ` [alsa-devel] " Pierre-Louis Bossart
@ 2019-08-07 17:56 ` Mark Brown
2019-08-07 18:17 ` Pierre-Louis Bossart
0 siblings, 1 reply; 8+ messages in thread
From: Mark Brown @ 2019-08-07 17:56 UTC (permalink / raw)
To: Pierre-Louis Bossart
Cc: Rafael J. Wysocki,
moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
Takashi Iwai, Greg Kroah-Hartman, Linux Kernel Mailing List,
Vinod Koul, Srini Kandagatla, jank, Sanyog Kale
[-- Attachment #1: Type: text/plain, Size: 2977 bytes --]
On Wed, Aug 07, 2019 at 10:09:27AM -0500, Pierre-Louis Bossart wrote:
> Vinod, Mark, any feedback?
> There will be a set of SoundWire codec drivers provided upstream soonish and
> we'll get a number of kbuild errors without this patch.
I think I'm missing context here, I've basically been zoning out all the
soundwire stuff - the patch series are huge and generate a bunch of
discusion. Is the patch below the full thing? I don't see any obvious
problems.
>
> >
> > > ---
> > > drivers/base/regmap/Kconfig | 2 +-
> > > drivers/soundwire/Kconfig | 7 +------
> > > drivers/soundwire/Makefile | 2 +-
> > > 3 files changed, 3 insertions(+), 8 deletions(-)
> > >
> > > diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig
> > > index 6ad5ef48b61e..8cd2ac650b50 100644
> > > --- a/drivers/base/regmap/Kconfig
> > > +++ b/drivers/base/regmap/Kconfig
> > > @@ -44,7 +44,7 @@ config REGMAP_IRQ
> > >
> > > config REGMAP_SOUNDWIRE
> > > tristate
> > > - depends on SOUNDWIRE_BUS
> > > + depends on SOUNDWIRE
> > >
> > > config REGMAP_SCCB
> > > tristate
> > > diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
> > > index 3a01cfd70fdc..f518273cfbe3 100644
> > > --- a/drivers/soundwire/Kconfig
> > > +++ b/drivers/soundwire/Kconfig
> > > @@ -4,7 +4,7 @@
> > > #
> > >
> > > menuconfig SOUNDWIRE
> > > - bool "SoundWire support"
> > > + tristate "SoundWire support"
> > > help
> > > SoundWire is a 2-Pin interface with data and clock line ratified
> > > by the MIPI Alliance. SoundWire is used for transporting data
> > > @@ -17,17 +17,12 @@ if SOUNDWIRE
> > >
> > > comment "SoundWire Devices"
> > >
> > > -config SOUNDWIRE_BUS
> > > - tristate
> > > - select REGMAP_SOUNDWIRE
> > > -
> > > config SOUNDWIRE_CADENCE
> > > tristate
> > >
> > > config SOUNDWIRE_INTEL
> > > tristate "Intel SoundWire Master driver"
> > > select SOUNDWIRE_CADENCE
> > > - select SOUNDWIRE_BUS
> > > depends on X86 && ACPI && SND_SOC
> > > help
> > > SoundWire Intel Master driver.
> > > diff --git a/drivers/soundwire/Makefile b/drivers/soundwire/Makefile
> > > index fd99a831b92a..45b7e5001653 100644
> > > --- a/drivers/soundwire/Makefile
> > > +++ b/drivers/soundwire/Makefile
> > > @@ -5,7 +5,7 @@
> > >
> > > #Bus Objs
> > > soundwire-bus-objs := bus_type.o bus.o slave.o mipi_disco.o stream.o
> > > -obj-$(CONFIG_SOUNDWIRE_BUS) += soundwire-bus.o
> > > +obj-$(CONFIG_SOUNDWIRE) += soundwire-bus.o
> > >
> > > #Cadence Objs
> > > soundwire-cadence-objs := cadence_master.o
> > > --
> > > 2.20.1
> > >
> > _______________________________________________
> > Alsa-devel mailing list
> > Alsa-devel@alsa-project.org
> > https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> >
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [alsa-devel] [PATCH] soundwire: fix regmap dependencies and align with other serial links
2019-08-07 17:56 ` Mark Brown
@ 2019-08-07 18:17 ` Pierre-Louis Bossart
2019-08-07 19:09 ` Mark Brown
0 siblings, 1 reply; 8+ messages in thread
From: Pierre-Louis Bossart @ 2019-08-07 18:17 UTC (permalink / raw)
To: Mark Brown
Cc: Rafael J. Wysocki,
moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
Takashi Iwai, Greg Kroah-Hartman, Linux Kernel Mailing List,
Vinod Koul, Srini Kandagatla, jank, Sanyog Kale
Hi Mark,
>
>> Vinod, Mark, any feedback?
>
>> There will be a set of SoundWire codec drivers provided upstream soonish and
>> we'll get a number of kbuild errors without this patch.
>
> I think I'm missing context here, I've basically been zoning out all the
> soundwire stuff - the patch series are huge and generate a bunch of
> discusion. Is the patch below the full thing? I don't see any obvious
> problems.
Here's a bit of context:
This patch is really independent from the 40-odd fixes I pushed about 10
days ago. I provided an initial version back in April ('[PATCH v2 2/2]
regmap: soundwire: fix Kconfig select/depend issue') during the first
batch of updates. At the time, the suggested solution for the
compilation issues was not agreed on, so the build errors remained - not
a big deal they only show-up with codec drivers that were not upstreamed
so far. It took me a while to come back to it but that was the first in
my TODO list after my Summer break and now that we are almost ready to
upstream those codec drivers it's a good time to revisit this issue.
Your initial feedback was:
"This now makes _SOUNDWIRE different to all the other bus types; if this
is a good change then surely the same thing should be done for all the
other bus types. "
and
"Alignment is a requirement. If you want to optimize
this then it'd be better to optimize all the bus types rather than just
having the one weird bus type that does something different for no
documented reason."
I don't have the knowledge or means to test what I suggested initially
for the other buses, and the optimization was minimal anyways, so this
patch takes the path of least resistance and aligns with others.
if there are no objections it's probably easier to push this patch
through the SoundWire tree, with the relevant Acks.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [alsa-devel] [PATCH] soundwire: fix regmap dependencies and align with other serial links
2019-08-07 18:17 ` Pierre-Louis Bossart
@ 2019-08-07 19:09 ` Mark Brown
0 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2019-08-07 19:09 UTC (permalink / raw)
To: Pierre-Louis Bossart
Cc: Rafael J. Wysocki,
moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
Takashi Iwai, Greg Kroah-Hartman, Linux Kernel Mailing List,
Vinod Koul, Srini Kandagatla, jank, Sanyog Kale
[-- Attachment #1: Type: text/plain, Size: 472 bytes --]
On Wed, Aug 07, 2019 at 01:17:20PM -0500, Pierre-Louis Bossart wrote:
> I don't have the knowledge or means to test what I suggested initially for
> the other buses, and the optimization was minimal anyways, so this patch
> takes the path of least resistance and aligns with others.
> if there are no objections it's probably easier to push this patch through
> the SoundWire tree, with the relevant Acks.
Makes sense I think
Acked-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] soundwire: fix regmap dependencies and align with other serial links
2019-07-18 23:02 [PATCH] soundwire: fix regmap dependencies and align with other serial links Pierre-Louis Bossart
2019-07-19 9:04 ` Rafael J. Wysocki
@ 2019-08-08 13:48 ` Srinivas Kandagatla
2019-08-09 4:51 ` Vinod Koul
2 siblings, 0 replies; 8+ messages in thread
From: Srinivas Kandagatla @ 2019-08-08 13:48 UTC (permalink / raw)
To: Pierre-Louis Bossart, alsa-devel
Cc: linux-kernel, tiwai, broonie, vkoul, gregkh, jank,
Rafael J. Wysocki, Sanyog Kale
On 19/07/2019 00:02, Pierre-Louis Bossart wrote:
> The existing code has a mixed select/depend usage which makes no sense.
>
> config SOUNDWIRE_BUS
> tristate
> select REGMAP_SOUNDWIRE
>
> config REGMAP_SOUNDWIRE
> tristate
> depends on SOUNDWIRE_BUS
>
> Let's remove one layer of Kconfig definitions and align with the
> solutions used by all other serial links.
>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> drivers/base/regmap/Kconfig | 2 +-
> drivers/soundwire/Kconfig | 7 +------
> drivers/soundwire/Makefile | 2 +-
> 3 files changed, 3 insertions(+), 8 deletions(-)
I have been using some thing similar in my setup.
I did test this with Qualcomm WSA881x codec.
Tested-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
--srini
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] soundwire: fix regmap dependencies and align with other serial links
2019-07-18 23:02 [PATCH] soundwire: fix regmap dependencies and align with other serial links Pierre-Louis Bossart
2019-07-19 9:04 ` Rafael J. Wysocki
2019-08-08 13:48 ` Srinivas Kandagatla
@ 2019-08-09 4:51 ` Vinod Koul
2 siblings, 0 replies; 8+ messages in thread
From: Vinod Koul @ 2019-08-09 4:51 UTC (permalink / raw)
To: Pierre-Louis Bossart
Cc: alsa-devel, linux-kernel, tiwai, broonie, gregkh, jank,
srinivas.kandagatla, Rafael J. Wysocki, Sanyog Kale
On 18-07-19, 18:02, Pierre-Louis Bossart wrote:
> The existing code has a mixed select/depend usage which makes no sense.
>
> config SOUNDWIRE_BUS
> tristate
> select REGMAP_SOUNDWIRE
>
> config REGMAP_SOUNDWIRE
> tristate
> depends on SOUNDWIRE_BUS
>
> Let's remove one layer of Kconfig definitions and align with the
> solutions used by all other serial links.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-08-09 4:52 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-18 23:02 [PATCH] soundwire: fix regmap dependencies and align with other serial links Pierre-Louis Bossart
2019-07-19 9:04 ` Rafael J. Wysocki
2019-08-07 15:09 ` [alsa-devel] " Pierre-Louis Bossart
2019-08-07 17:56 ` Mark Brown
2019-08-07 18:17 ` Pierre-Louis Bossart
2019-08-07 19:09 ` Mark Brown
2019-08-08 13:48 ` Srinivas Kandagatla
2019-08-09 4:51 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).