* [PATCH v4 5/8] reboot: Replace strncmp with str_has_prefix
@ 2019-08-09 7:10 Chuhong Yuan
0 siblings, 0 replies; only message in thread
From: Chuhong Yuan @ 2019-08-09 7:10 UTC (permalink / raw)
Cc: linux-kernel, Chuhong Yuan
strncmp(str, const, len) is error-prone because len
is easy to have typo.
The example is the hard-coded len has counting error
or sizeof(const) forgets - 1.
So we prefer using newly introduced str_has_prefix()
to substitute such strncmp to make code better.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
Changes in v4:
- Eliminate assignments in if conditions.
kernel/reboot.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/kernel/reboot.c b/kernel/reboot.c
index c4d472b7f1b4..c79aaac43785 100644
--- a/kernel/reboot.c
+++ b/kernel/reboot.c
@@ -520,6 +520,8 @@ EXPORT_SYMBOL_GPL(orderly_reboot);
static int __init reboot_setup(char *str)
{
+ size_t len;
+
for (;;) {
enum reboot_mode *mode;
@@ -530,9 +532,10 @@ static int __init reboot_setup(char *str)
*/
reboot_default = 0;
- if (!strncmp(str, "panic_", 6)) {
+ len = str_has_prefix(str, "panic_");
+ if (len) {
mode = &panic_reboot_mode;
- str += 6;
+ str += len;
} else {
mode = &reboot_mode;
}
--
2.20.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-08-09 7:10 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-09 7:10 [PATCH v4 5/8] reboot: Replace strncmp with str_has_prefix Chuhong Yuan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).