* [PATCH resend] video: backlight: Drop default m for {LCD,BACKLIGHT_CLASS_DEVICE}
@ 2019-08-13 11:58 Geert Uytterhoeven
2019-08-13 13:19 ` Daniel Thompson
2019-09-02 8:40 ` Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2019-08-13 11:58 UTC (permalink / raw)
To: Alexander Shiyan, Lee Jones, Daniel Thompson, Jingoo Han,
Bartlomiej Zolnierkiewicz
Cc: dri-devel, linux-fbdev, linux-kernel, Geert Uytterhoeven
When running "make oldconfig" on a .config where
CONFIG_BACKLIGHT_LCD_SUPPORT is not set, two new config options
("Lowlevel LCD controls" and "Lowlevel Backlight controls") appear, both
defaulting to "m".
Drop the "default m", as options should default to disabled, and because
several driver config options already select LCD_CLASS_DEVICE or
BACKLIGHT_CLASS_DEVICE when needed.
Fixes: 8c5dc8d9f19c7992 ("video: backlight: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/video/backlight/Kconfig | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
index 8b081d61773e21eb..40676be2e46aae61 100644
--- a/drivers/video/backlight/Kconfig
+++ b/drivers/video/backlight/Kconfig
@@ -10,7 +10,6 @@ menu "Backlight & LCD device support"
#
config LCD_CLASS_DEVICE
tristate "Lowlevel LCD controls"
- default m
help
This framework adds support for low-level control of LCD.
Some framebuffer devices connect to platform-specific LCD modules
@@ -143,7 +142,6 @@ endif # LCD_CLASS_DEVICE
#
config BACKLIGHT_CLASS_DEVICE
tristate "Lowlevel Backlight controls"
- default m
help
This framework adds support for low-level control of the LCD
backlight. This includes support for brightness and power.
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH resend] video: backlight: Drop default m for {LCD,BACKLIGHT_CLASS_DEVICE}
2019-08-13 11:58 [PATCH resend] video: backlight: Drop default m for {LCD,BACKLIGHT_CLASS_DEVICE} Geert Uytterhoeven
@ 2019-08-13 13:19 ` Daniel Thompson
2019-09-02 8:40 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Thompson @ 2019-08-13 13:19 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Alexander Shiyan, Lee Jones, Jingoo Han,
Bartlomiej Zolnierkiewicz, dri-devel, linux-fbdev, linux-kernel
On Tue, Aug 13, 2019 at 01:58:53PM +0200, Geert Uytterhoeven wrote:
> When running "make oldconfig" on a .config where
> CONFIG_BACKLIGHT_LCD_SUPPORT is not set, two new config options
> ("Lowlevel LCD controls" and "Lowlevel Backlight controls") appear, both
> defaulting to "m".
>
> Drop the "default m", as options should default to disabled, and because
> several driver config options already select LCD_CLASS_DEVICE or
> BACKLIGHT_CLASS_DEVICE when needed.
>
> Fixes: 8c5dc8d9f19c7992 ("video: backlight: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
> ---
> drivers/video/backlight/Kconfig | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
> index 8b081d61773e21eb..40676be2e46aae61 100644
> --- a/drivers/video/backlight/Kconfig
> +++ b/drivers/video/backlight/Kconfig
> @@ -10,7 +10,6 @@ menu "Backlight & LCD device support"
> #
> config LCD_CLASS_DEVICE
> tristate "Lowlevel LCD controls"
> - default m
> help
> This framework adds support for low-level control of LCD.
> Some framebuffer devices connect to platform-specific LCD modules
> @@ -143,7 +142,6 @@ endif # LCD_CLASS_DEVICE
> #
> config BACKLIGHT_CLASS_DEVICE
> tristate "Lowlevel Backlight controls"
> - default m
> help
> This framework adds support for low-level control of the LCD
> backlight. This includes support for brightness and power.
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH resend] video: backlight: Drop default m for {LCD,BACKLIGHT_CLASS_DEVICE}
2019-08-13 11:58 [PATCH resend] video: backlight: Drop default m for {LCD,BACKLIGHT_CLASS_DEVICE} Geert Uytterhoeven
2019-08-13 13:19 ` Daniel Thompson
@ 2019-09-02 8:40 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2019-09-02 8:40 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Alexander Shiyan, Daniel Thompson, Jingoo Han,
Bartlomiej Zolnierkiewicz, dri-devel, linux-fbdev, linux-kernel
On Tue, 13 Aug 2019, Geert Uytterhoeven wrote:
> When running "make oldconfig" on a .config where
> CONFIG_BACKLIGHT_LCD_SUPPORT is not set, two new config options
> ("Lowlevel LCD controls" and "Lowlevel Backlight controls") appear, both
> defaulting to "m".
>
> Drop the "default m", as options should default to disabled, and because
> several driver config options already select LCD_CLASS_DEVICE or
> BACKLIGHT_CLASS_DEVICE when needed.
>
> Fixes: 8c5dc8d9f19c7992 ("video: backlight: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> drivers/video/backlight/Kconfig | 2 --
> 1 file changed, 2 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-02 8:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-13 11:58 [PATCH resend] video: backlight: Drop default m for {LCD,BACKLIGHT_CLASS_DEVICE} Geert Uytterhoeven
2019-08-13 13:19 ` Daniel Thompson
2019-09-02 8:40 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).