[PATCH 0/2] Fix support of a few Logitech devices broken in 5.3

linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH 0/2] Fix support of a few Logitech devices broken in 5.3
@ 2019-08-13 13:38 Benjamin Tissoires
  2019-08-13 13:38 ` [PATCH 1/2] Revert "HID: logitech-hidpp: add USB PID for a few more supported mice" Benjamin Tissoires
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Benjamin Tissoires @ 2019-08-13 13:38 UTC (permalink / raw)
  To: Filipe Laíns, Jiri Kosina
  Cc: linux-input, linux-kernel, Benjamin Tissoires

Hi Jiri,

another set of patches to send to Linus ASAP.
It turns out that we have been breaking devices, so this should
be sent before 5.3 final.

Cheers,
Benjamin

Benjamin Tissoires (2):
  Revert "HID: logitech-hidpp: add USB PID for a few more supported
    mice"
  HID: logitech-hidpp: remove support for the G700 over USB

 drivers/hid/hid-logitech-hidpp.c | 22 ----------------------
 1 file changed, 22 deletions(-)

-- 
2.19.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/2] Revert "HID: logitech-hidpp: add USB PID for a few more supported mice"
  2019-08-13 13:38 [PATCH 0/2] Fix support of a few Logitech devices broken in 5.3 Benjamin Tissoires
@ 2019-08-13 13:38 ` Benjamin Tissoires
  2019-08-13 13:38 ` [PATCH 2/2] HID: logitech-hidpp: remove support for the G700 over USB Benjamin Tissoires
  2019-08-13 14:21 ` [PATCH 0/2] Fix support of a few Logitech devices broken in 5.3 Filipe Laíns
  2 siblings, 0 replies; 5+ messages in thread
From: Benjamin Tissoires @ 2019-08-13 13:38 UTC (permalink / raw)
  To: Filipe Laíns, Jiri Kosina
  Cc: linux-input, linux-kernel, Benjamin Tissoires

This partially reverts commit 27fc32fd9417968a459d43d9a7c50fd423d53eb9.

It turns out that the G502 has some issues with hid-logitech-hidpp:
when plugging it in, the driver tries to contact it but it fails.
So the driver bails out leaving only the mouse event node available.

This timeout is problematic as it introduce a delay in the boot,
and having only the mouse event node means that the hardware
macros keys can not be relayed to the userspace.

Filipe and I just gave a shot at the following devices:

G403 Wireless (0xC082)
G703 (0xC087)
G703 Hero (0xC090)
G903 (0xC086)
G903 Hero (0xC091)
G Pro (0xC088)

Reverting the device we are not sure that works flawlessly.

Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
 drivers/hid/hid-logitech-hidpp.c | 20 --------------------
 1 file changed, 20 deletions(-)

diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
index 21268c9fa71a..343052b117a9 100644
--- a/drivers/hid/hid-logitech-hidpp.c
+++ b/drivers/hid/hid-logitech-hidpp.c
@@ -3749,30 +3749,10 @@ static const struct hid_device_id hidpp_devices[] = {
 
 	{ L27MHZ_DEVICE(HID_ANY_ID) },
 
-	{ /* Logitech G203/Prodigy Gaming Mouse */
-	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC084) },
-	{ /* Logitech G302 Gaming Mouse */
-	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC07F) },
-	{ /* Logitech G303 Gaming Mouse */
-	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC080) },
-	{ /* Logitech G400 Gaming Mouse */
-	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC07E) },
 	{ /* Logitech G403 Wireless Gaming Mouse over USB */
 	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC082) },
-	{ /* Logitech G403 Gaming Mouse */
-	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC083) },
-	{ /* Logitech G403 Hero Gaming Mouse over USB */
-	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08F) },
-	{ /* Logitech G502 Proteus Core Gaming Mouse */
-	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC07D) },
-	{ /* Logitech G502 Proteus Spectrum Gaming Mouse over USB */
-	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC332) },
-	{ /* Logitech G502 Hero Gaming Mouse over USB */
-	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08B) },
 	{ /* Logitech G700 Gaming Mouse over USB */
 	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC06B) },
-	{ /* Logitech G700s Gaming Mouse over USB */
-	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC07C) },
 	{ /* Logitech G703 Gaming Mouse over USB */
 	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC087) },
 	{ /* Logitech G703 Hero Gaming Mouse over USB */
-- 
2.19.2


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] HID: logitech-hidpp: remove support for the G700 over USB
  2019-08-13 13:38 [PATCH 0/2] Fix support of a few Logitech devices broken in 5.3 Benjamin Tissoires
  2019-08-13 13:38 ` [PATCH 1/2] Revert "HID: logitech-hidpp: add USB PID for a few more supported mice" Benjamin Tissoires
@ 2019-08-13 13:38 ` Benjamin Tissoires
  2019-08-13 14:21 ` [PATCH 0/2] Fix support of a few Logitech devices broken in 5.3 Filipe Laíns
  2 siblings, 0 replies; 5+ messages in thread
From: Benjamin Tissoires @ 2019-08-13 13:38 UTC (permalink / raw)
  To: Filipe Laíns, Jiri Kosina
  Cc: linux-input, linux-kernel, Benjamin Tissoires, stable

The G700 suffers from the same issue than the G502:
when plugging it in, the driver tries to contact it but it fails.

This timeout is problematic as it introduce a delay in the boot,
and having only the mouse event node means that the hardware
macros keys can not be relayed to the userspace.

Link: https://github.com/libratbag/libratbag/issues/797
Fixes: 91cf9a98ae41 ("HID: logitech-hidpp: make .probe usbhid capable")
Cc: stable@vger.kernel.org # v5.2
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
 drivers/hid/hid-logitech-hidpp.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
index 343052b117a9..0179f7ed77e5 100644
--- a/drivers/hid/hid-logitech-hidpp.c
+++ b/drivers/hid/hid-logitech-hidpp.c
@@ -3751,8 +3751,6 @@ static const struct hid_device_id hidpp_devices[] = {
 
 	{ /* Logitech G403 Wireless Gaming Mouse over USB */
 	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC082) },
-	{ /* Logitech G700 Gaming Mouse over USB */
-	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC06B) },
 	{ /* Logitech G703 Gaming Mouse over USB */
 	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC087) },
 	{ /* Logitech G703 Hero Gaming Mouse over USB */
-- 
2.19.2


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/2] Fix support of a few Logitech devices broken in 5.3
  2019-08-13 13:38 [PATCH 0/2] Fix support of a few Logitech devices broken in 5.3 Benjamin Tissoires
  2019-08-13 13:38 ` [PATCH 1/2] Revert "HID: logitech-hidpp: add USB PID for a few more supported mice" Benjamin Tissoires
  2019-08-13 13:38 ` [PATCH 2/2] HID: logitech-hidpp: remove support for the G700 over USB Benjamin Tissoires
@ 2019-08-13 14:21 ` Filipe Laíns
  2019-08-13 14:36   ` Benjamin Tissoires
  2 siblings, 1 reply; 5+ messages in thread
From: Filipe Laíns @ 2019-08-13 14:21 UTC (permalink / raw)
  To: Benjamin Tissoires, Jiri Kosina; +Cc: linux-input, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 615 bytes --]

On Tue, 2019-08-13 at 15:38 +0200, Benjamin Tissoires wrote:
> Hi Jiri,
> 
> another set of patches to send to Linus ASAP.
> It turns out that we have been breaking devices, so this should
> be sent before 5.3 final.
> 
> Cheers,
> Benjamin
> 
> Benjamin Tissoires (2):
>   Revert "HID: logitech-hidpp: add USB PID for a few more supported
>     mice"
>   HID: logitech-hidpp: remove support for the G700 over USB
> 
>  drivers/hid/hid-logitech-hidpp.c | 22 ----------------------
>  1 file changed, 22 deletions(-)
> 

Reviewed-by: Filipe Laíns <lains@archlinux.org>

Thanks,
Filipe Laíns

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/2] Fix support of a few Logitech devices broken in 5.3
  2019-08-13 14:21 ` [PATCH 0/2] Fix support of a few Logitech devices broken in 5.3 Filipe Laíns
@ 2019-08-13 14:36   ` Benjamin Tissoires
  0 siblings, 0 replies; 5+ messages in thread
From: Benjamin Tissoires @ 2019-08-13 14:36 UTC (permalink / raw)
  To: Filipe Laíns; +Cc: Jiri Kosina, open list:HID CORE LAYER, lkml

On Tue, Aug 13, 2019 at 4:21 PM Filipe Laíns <lains@archlinux.org> wrote:
>
> On Tue, 2019-08-13 at 15:38 +0200, Benjamin Tissoires wrote:
> > Hi Jiri,
> >
> > another set of patches to send to Linus ASAP.
> > It turns out that we have been breaking devices, so this should
> > be sent before 5.3 final.
> >
> > Cheers,
> > Benjamin
> >
> > Benjamin Tissoires (2):
> >   Revert "HID: logitech-hidpp: add USB PID for a few more supported
> >     mice"
> >   HID: logitech-hidpp: remove support for the G700 over USB
> >
> >  drivers/hid/hid-logitech-hidpp.c | 22 ----------------------
> >  1 file changed, 22 deletions(-)
> >
>
> Reviewed-by: Filipe Laíns <lains@archlinux.org>

Thanks.

I have schedule those 2 patches into for-5.3/upstream-fixes.

Cheers,
Benjamin

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-08-13 14:36 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-13 13:38 [PATCH 0/2] Fix support of a few Logitech devices broken in 5.3 Benjamin Tissoires
2019-08-13 13:38 ` [PATCH 1/2] Revert "HID: logitech-hidpp: add USB PID for a few more supported mice" Benjamin Tissoires
2019-08-13 13:38 ` [PATCH 2/2] HID: logitech-hidpp: remove support for the G700 over USB Benjamin Tissoires
2019-08-13 14:21 ` [PATCH 0/2] Fix support of a few Logitech devices broken in 5.3 Filipe Laíns
2019-08-13 14:36   ` Benjamin Tissoires

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).