* [PATCH v1] rapidio: Make it dependent to DMADEVICES
@ 2019-08-13 14:39 Andy Shevchenko
2019-12-09 16:42 ` Andy Shevchenko
2020-09-10 9:06 ` Andy Shevchenko
0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2019-08-13 14:39 UTC (permalink / raw)
To: Matt Porter, linux-kernel; +Cc: Andy Shevchenko, Alexandre Bounine
DMADEVICES option depends on HAS_DMA, and this dependency is ignored
when DMADEVICES is being selected.
Replace 'select' by 'depends on' in Kconfig for RAPIDIO_DMA_ENGINE.
Fixes: e42d98ebe7d7 ("rapidio: add DMA engine support for RIO data transfers")
Cc: Alexandre Bounine <alexandre.bounine@idt.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/rapidio/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rapidio/Kconfig b/drivers/rapidio/Kconfig
index 677d1aff61b7..788e7830771b 100644
--- a/drivers/rapidio/Kconfig
+++ b/drivers/rapidio/Kconfig
@@ -37,7 +37,7 @@ config RAPIDIO_ENABLE_RX_TX_PORTS
config RAPIDIO_DMA_ENGINE
bool "DMA Engine support for RapidIO"
depends on RAPIDIO
- select DMADEVICES
+ depends on DMADEVICES
select DMA_ENGINE
help
Say Y here if you want to use DMA Engine frameork for RapidIO data
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v1] rapidio: Make it dependent to DMADEVICES
2019-08-13 14:39 [PATCH v1] rapidio: Make it dependent to DMADEVICES Andy Shevchenko
@ 2019-12-09 16:42 ` Andy Shevchenko
2020-09-10 9:06 ` Andy Shevchenko
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2019-12-09 16:42 UTC (permalink / raw)
To: Matt Porter, linux-kernel; +Cc: Alexandre Bounine
On Tue, Aug 13, 2019 at 05:39:06PM +0300, Andy Shevchenko wrote:
> DMADEVICES option depends on HAS_DMA, and this dependency is ignored
> when DMADEVICES is being selected.
>
> Replace 'select' by 'depends on' in Kconfig for RAPIDIO_DMA_ENGINE.
Anybody to comment on this?
>
> Fixes: e42d98ebe7d7 ("rapidio: add DMA engine support for RIO data transfers")
> Cc: Alexandre Bounine <alexandre.bounine@idt.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/rapidio/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rapidio/Kconfig b/drivers/rapidio/Kconfig
> index 677d1aff61b7..788e7830771b 100644
> --- a/drivers/rapidio/Kconfig
> +++ b/drivers/rapidio/Kconfig
> @@ -37,7 +37,7 @@ config RAPIDIO_ENABLE_RX_TX_PORTS
> config RAPIDIO_DMA_ENGINE
> bool "DMA Engine support for RapidIO"
> depends on RAPIDIO
> - select DMADEVICES
> + depends on DMADEVICES
> select DMA_ENGINE
> help
> Say Y here if you want to use DMA Engine frameork for RapidIO data
> --
> 2.20.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v1] rapidio: Make it dependent to DMADEVICES
2019-08-13 14:39 [PATCH v1] rapidio: Make it dependent to DMADEVICES Andy Shevchenko
2019-12-09 16:42 ` Andy Shevchenko
@ 2020-09-10 9:06 ` Andy Shevchenko
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2020-09-10 9:06 UTC (permalink / raw)
To: Matt Porter, linux-kernel; +Cc: Alexandre Bounine, Laurent Pinchart
On Tue, Aug 13, 2019 at 05:39:06PM +0300, Andy Shevchenko wrote:
> DMADEVICES option depends on HAS_DMA, and this dependency is ignored
> when DMADEVICES is being selected.
>
> Replace 'select' by 'depends on' in Kconfig for RAPIDIO_DMA_ENGINE.
Yeah, I'm wondering why we got this into kernel much later (as
d2b861002450 ("rapidio: Replace 'select' DMAENGINES 'with depends on'") in
linux next and no one commented on this...
> Fixes: e42d98ebe7d7 ("rapidio: add DMA engine support for RIO data transfers")
> Cc: Alexandre Bounine <alexandre.bounine@idt.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/rapidio/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rapidio/Kconfig b/drivers/rapidio/Kconfig
> index 677d1aff61b7..788e7830771b 100644
> --- a/drivers/rapidio/Kconfig
> +++ b/drivers/rapidio/Kconfig
> @@ -37,7 +37,7 @@ config RAPIDIO_ENABLE_RX_TX_PORTS
> config RAPIDIO_DMA_ENGINE
> bool "DMA Engine support for RapidIO"
> depends on RAPIDIO
> - select DMADEVICES
> + depends on DMADEVICES
> select DMA_ENGINE
> help
> Say Y here if you want to use DMA Engine frameork for RapidIO data
> --
> 2.20.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-10 9:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-13 14:39 [PATCH v1] rapidio: Make it dependent to DMADEVICES Andy Shevchenko
2019-12-09 16:42 ` Andy Shevchenko
2020-09-10 9:06 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).